)]}'
{"swift/cli/manage_shard_ranges.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"dfd5558a602118f75b50bb13423b4f57d5dc06e7","unresolved":false,"context_lines":[{"line_number":435,"context_line":"def _make_parser():"},{"line_number":436,"context_line":"    parser \u003d argparse.ArgumentParser(description\u003d\u0027Manage shard ranges\u0027)"},{"line_number":437,"context_line":"    parser.add_argument(\u0027container_db\u0027)"},{"line_number":438,"context_line":"    parser.add_argument(\u0027--verbose\u0027, \u0027-v\u0027, action\u003d\u0027count\u0027, default\u003d0,"},{"line_number":439,"context_line":"                        help\u003d\u0027Increase output verbosity\u0027)"},{"line_number":440,"context_line":"    subparsers \u003d parser.add_subparsers("},{"line_number":441,"context_line":"        help\u003d\u0027Sub-command help\u0027, title\u003d\u0027Sub-commands\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_147b7bbe","line":438,"updated":"2019-02-19 18:43:16.000000000","message":"I don\u0027t see why this matters, but either solution is fine by me.","commit_id":"e4c54103763e66ee1ebeba7b996308581b5176f5"}],"swift/container/backend.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"4d72d61766f0c3052eaa0d8acd243a75b84a9176","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"            try:"},{"line_number":1427,"context_line":"                return _really_merge_items(conn)"},{"line_number":1428,"context_line":"            except sqlite3.OperationalError as err:"},{"line_number":1429,"context_line":"                # Without the rollback, new enough python/sqlite3 will panic:"},{"line_number":1430,"context_line":"                #   sqlite3.OperationalError: cannot start a transaction"},{"line_number":1431,"context_line":"                #   within a transaction"},{"line_number":1432,"context_line":"                conn.rollback()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_7a718977","line":1429,"updated":"2019-02-19 23:29:45.000000000","message":"\"new enough\" is how much? Is there a version number or should we say \"in Ubuntu LTS 18.04\"?","commit_id":"28c8122ff480f370fae25cc7331251433b485918"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0a274fd76d5c956383ef02be9afadf469be8e51","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"            try:"},{"line_number":1427,"context_line":"                return _really_merge_items(conn)"},{"line_number":1428,"context_line":"            except sqlite3.OperationalError as err:"},{"line_number":1429,"context_line":"                # Without the rollback, new enough python/sqlite3 will panic:"},{"line_number":1430,"context_line":"                #   sqlite3.OperationalError: cannot start a transaction"},{"line_number":1431,"context_line":"                #   within a transaction"},{"line_number":1432,"context_line":"                conn.rollback()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_fab9f9eb","line":1429,"in_reply_to":"9fdfeff1_7a718977","updated":"2019-02-19 23:42:28.000000000","message":"Not entirely sure. I saw it running py37...","commit_id":"28c8122ff480f370fae25cc7331251433b485918"}],"swift/container/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0a274fd76d5c956383ef02be9afadf469be8e51","unresolved":false,"context_lines":[{"line_number":464,"context_line":"            if response:"},{"line_number":465,"context_line":"                return response"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"            broker.put_object(obj, req_timestamp.internal,"},{"line_number":468,"context_line":"                              int(req.headers[\u0027x-size\u0027]),"},{"line_number":469,"context_line":"                              wsgi_to_str(req.headers[\u0027x-content-type\u0027]),"},{"line_number":470,"context_line":"                              wsgi_to_str(req.headers[\u0027x-etag\u0027]), 0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_5afda5af","line":467,"range":{"start_line":467,"start_character":30,"end_line":467,"end_character":33},"updated":"2019-02-19 23:42:28.000000000","message":"This should maybe also get the wsgi_to_str() treatment...","commit_id":"28c8122ff480f370fae25cc7331251433b485918"}],"test/unit/container/test_updater.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"dfd5558a602118f75b50bb13423b4f57d5dc06e7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self.assertEqual(1, len(mock_dump_recon.mock_calls))"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @mock.patch(\u0027swift.container.updater.dump_recon_cache\u0027)"},{"line_number":200,"context_line":"    def test_run_once(self):"},{"line_number":201,"context_line":"        cu \u003d self._get_container_updater()"},{"line_number":202,"context_line":"        cu.run_once()"},{"line_number":203,"context_line":"        containers_dir \u003d os.path.join(self.sda1, DATADIR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cf1c7e79","line":200,"updated":"2019-02-19 18:43:16.000000000","message":"This cannot work. You have to update the def to include the second argument:\n  def test_run_once(self, d_r_c):","commit_id":"e4c54103763e66ee1ebeba7b996308581b5176f5"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2d1c9c3b403b84524d4e56b47afad66a68fd1b29","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                    self.assertTrue(\u0027x-delete-timestamp\u0027 in headers)"},{"line_number":246,"context_line":"                    self.assertTrue(\u0027x-object-count\u0027 in headers)"},{"line_number":247,"context_line":"                    self.assertTrue(\u0027x-bytes-used\u0027 in headers)"},{"line_number":248,"context_line":"            except BaseException as err:"},{"line_number":249,"context_line":"                import traceback"},{"line_number":250,"context_line":"                traceback.print_exc()"},{"line_number":251,"context_line":"                return err"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_1acabd19","side":"PARENT","line":248,"updated":"2019-02-19 23:49:34.000000000","message":"Was this removal intentional? Other such tests retain this printout, so looks inconsistent to me.","commit_id":"07f6a1835722179883c6ba33ff3ef3d2e6628e4b"}]}
