)]}'
{"go/swift-rpc-losf/rpc_http.go":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"9c2038d3db6886311b7203394607ef14f38f77f9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\t\"sync\""},{"line_number":16,"context_line":")"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"type rpcFunc func(*server, context.Context, *[]byte) (*[]byte, error)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"// RegisterVolume registers a new volume (volume) to the KV, given its index number and starting offset."},{"line_number":21,"context_line":"// Will return an error if the volume index already exists."}],"source_content_type":"text/x-go","patch_set":1,"id":"5fc1f717_c74f5d90","line":18,"updated":"2019-03-08 13:35:24.000000000","message":"Almost everything here is copy pasted from existing code.\n\nThe function\u0027s only changes are to take plain bytes and deserialize the protobuf. They also serialize the return.\n\n(gRPC would take care of it in the existing LOSF)","commit_id":"0b9dd77c00ce21b13189ecab60fa57bcf82d132c"}],"swift/obj/rpc_http.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"9c2038d3db6886311b7203394607ef14f38f77f9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.sock \u003d sock"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# This would replace the whole code below, but requires a few changes in"},{"line_number":39,"context_line":"# the index server and in vfile.py. I don\u0027t want to do it all at once until"},{"line_number":40,"context_line":"# I have compared results between gRPC / plain HTTP with otherwise similar"},{"line_number":41,"context_line":"# code."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e72e19a4","line":38,"updated":"2019-03-08 13:35:24.000000000","message":"With a few changes to the index server and in vfile.py, this commented block could replace the rest.\n\nOtherwise, the code is copy pasted from the existing rpc_grpc.py file, and changed to perform the protobuf serialization/deserialization that was previously handled by grpc","commit_id":"0b9dd77c00ce21b13189ecab60fa57bcf82d132c"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"9c2038d3db6886311b7203394607ef14f38f77f9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    Unavailable \u003d 503"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class RpcError(Exception):"},{"line_number":99,"context_line":"    def __init__(self, message, code):"},{"line_number":100,"context_line":"        self.code \u003d code"},{"line_number":101,"context_line":"        super(RpcError, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a20c7f3b","line":98,"updated":"2019-03-08 13:35:24.000000000","message":"This does not have an interface similar to existing grpc.RpcError, so it will cause issues in vfile.py.\n\nWill need to fix it if we go ahead with HTTP.","commit_id":"0b9dd77c00ce21b13189ecab60fa57bcf82d132c"}]}