)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"8cde6c2ed9f35561a8aba2879b23835bd6ad7bb6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not use self in classmethod"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cls should be used in classmethd, instead of self."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I149b18935ce909ef978f2b7147b109e11c22f923"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_4f227254","line":9,"updated":"2019-03-12 03:37:18.000000000","message":"I would have liked this commit message to be a little more detailed. Once it lands it\u0027ll be the main source of information on this change. IE. great I know what it does but where? I would have rathered something more like:\n\n  Do not use self in classmethod\n\n  The create_broker class method in the container backend is using self,\n  this patch corrects it to cls.\n\nSure I don\u0027t mind if it\u0027s a little more generic, something like:\n\n  Do not use self in classmethod\n\n  \u0027cls\u0027 should be used in classmethod, instead of self.\n  This patch corrects this in the following places:\n     - container/backend.py\n\nThis makes it easy to bisect in times of issues or making it easier to write change logs ;)\n\nThis has already got a +A so not going to block it.","commit_id":"13e7f3641e3bffbcf89733ebb50d3ca6847105c6"}],"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c476929af16efecddba2a569e47847981d203124","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        db_dir \u003d storage_directory(DATADIR, part, hsh)"},{"line_number":361,"context_line":"        db_path \u003d make_db_file_path("},{"line_number":362,"context_line":"            os.path.join(device_path, db_dir, hsh + \u0027.db\u0027), epoch)"},{"line_number":363,"context_line":"        broker \u003d ContainerBroker(db_path, account\u003daccount, container\u003dcontainer,"},{"line_number":364,"context_line":"                                 logger\u003dlogger)"},{"line_number":365,"context_line":"        if not os.path.exists(broker.db_file):"},{"line_number":366,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1a66f752","line":363,"range":{"start_line":363,"start_character":17,"end_line":363,"end_character":32},"updated":"2019-03-11 16:00:12.000000000","message":"I wonder if this should use cls...","commit_id":"13e7f3641e3bffbcf89733ebb50d3ca6847105c6"}]}
