)]}'
{"swift/common/middleware/dlo.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d22a93f5cadce1ca577f1ec22999b095b3b3c67c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.logger \u003d logger"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_container_listing(self, req, version, wsgi_account,"},{"line_number":143,"context_line":"                               wsgi_container, wsgi_prefix, wsgi_marker\u003d\u0027\u0027):"},{"line_number":144,"context_line":"        con_req \u003d make_subrequest("},{"line_number":145,"context_line":"            req.environ,"},{"line_number":146,"context_line":"            path\u003dwsgi_quote(\u0027/\u0027.join([\u0027\u0027, version, wsgi_account,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_38cccd33","line":143,"updated":"2019-03-26 22:00:54.000000000","message":"What is the renames are for? As much as I can tell, they do absolutely nothig - there\u0027s no closure that makes them visible anywhere even. Are you trying to nail down their types as wsgi strings, but adding :param foo: comments is too uncouth?","commit_id":"a16ceb61421ab2bbc463daa444ae3a93cff09b2e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6461a5013be709ebd4a367b48477e2ddc37e1dd6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.logger \u003d logger"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_container_listing(self, req, version, wsgi_account,"},{"line_number":143,"context_line":"                               wsgi_container, wsgi_prefix, wsgi_marker\u003d\u0027\u0027):"},{"line_number":144,"context_line":"        con_req \u003d make_subrequest("},{"line_number":145,"context_line":"            req.environ,"},{"line_number":146,"context_line":"            path\u003dwsgi_quote(\u0027/\u0027.join([\u0027\u0027, version, wsgi_account,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_9b75bb66","line":143,"in_reply_to":"5fc1f717_38cccd33","updated":"2019-03-26 22:13:33.000000000","message":"Too much VB6? There\u0027s something reassuring about looking at a variable name and knowing what type to expect, though.\n\nThat, and there were some other places (maybe in some proxy controllers?) where I wanted *both* the native and wsgi strings and I realized decorating the name could serve at least as well as documentation.","commit_id":"a16ceb61421ab2bbc463daa444ae3a93cff09b2e"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d22a93f5cadce1ca577f1ec22999b095b3b3c67c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            elif last_byte \u003c 0:"},{"line_number":213,"context_line":"                break"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            wsgi_marker \u003d bytes_to_wsgi(segments[-1][\u0027name\u0027].encode(\u0027utf8\u0027))"},{"line_number":216,"context_line":"            error_response, segments \u003d self._get_container_listing("},{"line_number":217,"context_line":"                req, version, wsgi_account, wsgi_container, wsgi_prefix,"},{"line_number":218,"context_line":"                wsgi_marker)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_58051913","line":215,"updated":"2019-03-26 22:00:54.000000000","message":"So, I guess you didn\u0027t want to use str_to_wsgi() here because it produces surrogates. But why is that a problem?","commit_id":"a16ceb61421ab2bbc463daa444ae3a93cff09b2e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6461a5013be709ebd4a367b48477e2ddc37e1dd6","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            elif last_byte \u003c 0:"},{"line_number":213,"context_line":"                break"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            wsgi_marker \u003d bytes_to_wsgi(segments[-1][\u0027name\u0027].encode(\u0027utf8\u0027))"},{"line_number":216,"context_line":"            error_response, segments \u003d self._get_container_listing("},{"line_number":217,"context_line":"                req, version, wsgi_account, wsgi_container, wsgi_prefix,"},{"line_number":218,"context_line":"                wsgi_marker)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_1b30eb9e","line":215,"in_reply_to":"5fc1f717_58051913","updated":"2019-03-26 22:13:33.000000000","message":"str_to_wsgi won\u0027t work here on py2 :-(\n\nI think? At the very least, it would do something *different* here, though maybe some other place would fix it up...\n\nMaybe I should add a unicode_to_wsgi, complete the set?","commit_id":"a16ceb61421ab2bbc463daa444ae3a93cff09b2e"}]}