)]}'
{"swift/common/middleware/s3api/s3token.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"edea3cb9bf9d2e16f1fe5e35f13bfe5b7fb62e78","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        if isinstance(string_to_sign, six.text_type):"},{"line_number":277,"context_line":"            string_to_sign \u003d string_to_sign.encode(\u0027utf-8\u0027)"},{"line_number":278,"context_line":"        token \u003d base64.urlsafe_b64encode(string_to_sign)"},{"line_number":279,"context_line":"        if isinstance(token, bytes):"},{"line_number":280,"context_line":"            token \u003d token.decode(\u0027ascii\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(chmou): This is to handle the special case with nova"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_109061ed","line":279,"updated":"2019-04-02 03:58:31.000000000","message":"Use of bytes here is inconsistent with all the six.binary_type above (they all get into JSON below). I understand the logic of not using six unless necessary, but at least maybe keep them all uniform?","commit_id":"2ce52673aed28f019dff30383f70afbe75f697f1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"92ce5482466f9887cbbffe3037e4b6d9f24e80ef","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        if isinstance(string_to_sign, six.text_type):"},{"line_number":277,"context_line":"            string_to_sign \u003d string_to_sign.encode(\u0027utf-8\u0027)"},{"line_number":278,"context_line":"        token \u003d base64.urlsafe_b64encode(string_to_sign)"},{"line_number":279,"context_line":"        if isinstance(token, bytes):"},{"line_number":280,"context_line":"            token \u003d token.decode(\u0027ascii\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(chmou): This is to handle the special case with nova"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6bb75df7","line":279,"in_reply_to":"5fc1f717_109061ed","updated":"2019-04-03 00:48:46.000000000","message":"Hadn\u0027t even looked at the surrounding code for precedent; good catch. Cleaned up.","commit_id":"2ce52673aed28f019dff30383f70afbe75f697f1"}]}
