)]}'
{"test/functional/s3api/s3_test_client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"889ccabada8f985b7d0b053e96b3e1efc3de4681","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        # 404 means NoSuchBucket, NoSuchKey, or NoSuchUpload"},{"line_number":95,"context_line":"                        if e.status !\u003d 404:"},{"line_number":96,"context_line":"                            raise"},{"line_number":97,"context_line":"            except Exception as e:"},{"line_number":98,"context_line":"                exceptions.append(\u0027\u0027.join("},{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_be64aee6","line":97,"range":{"start_line":97,"start_character":19,"end_line":97,"end_character":28},"updated":"2019-04-02 16:55:35.000000000","message":"IDK that we want to make this so broad... did you see some other errors that weren\u0027t getting caught but might\u0027ve been helped by a retry?","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"9adea676b25064e1f973c2364ac2887248ce4f51","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        # 404 means NoSuchBucket, NoSuchKey, or NoSuchUpload"},{"line_number":95,"context_line":"                        if e.status !\u003d 404:"},{"line_number":96,"context_line":"                            raise"},{"line_number":97,"context_line":"            except Exception as e:"},{"line_number":98,"context_line":"                exceptions.append(\u0027\u0027.join("},{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_f2ba676c","line":97,"range":{"start_line":97,"start_character":19,"end_line":97,"end_character":28},"in_reply_to":"5fc1f717_1c35caa8","updated":"2019-04-02 20:41:27.000000000","message":"I\u0027d hate your guts very much if you did \"except Exception\" on the server side, but for the client it\u0027s okay. Well, mostly okay. I\u0027ll only hate you a little, when the functests fail in the gate and there\u0027s no way to tell why.","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d1a3b3c626ce4838592e3e9f666bf5c5047c118b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        # 404 means NoSuchBucket, NoSuchKey, or NoSuchUpload"},{"line_number":95,"context_line":"                        if e.status !\u003d 404:"},{"line_number":96,"context_line":"                            raise"},{"line_number":97,"context_line":"            except Exception as e:"},{"line_number":98,"context_line":"                exceptions.append(\u0027\u0027.join("},{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_1c35caa8","line":97,"range":{"start_line":97,"start_character":19,"end_line":97,"end_character":28},"in_reply_to":"5fc1f717_be64aee6","updated":"2019-04-02 18:33:17.000000000","message":"Yes, BaseHTTPException, some weird boto exceptions, all kinds of shit.\n\nAnd also why not - if it\u0027s a stupid NameError in Swift catch_errors will make it a generic 5XX and if it\u0027s something silly in the test it\u0027s going to blow up anyway?","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"889ccabada8f985b7d0b053e96b3e1efc3de4681","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                            raise"},{"line_number":97,"context_line":"            except Exception as e:"},{"line_number":98,"context_line":"                exceptions.append(\u0027\u0027.join("},{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"},{"line_number":101,"context_line":"            exceptions.insert(0, \u0027Too many errors to continue:\u0027)"},{"line_number":102,"context_line":"            raise Exception(\u0027\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\n\u0027.join(exceptions))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_1ee70249","line":99,"updated":"2019-04-02 16:55:35.000000000","message":"Could just say\n\n exceptions.append(traceback.format_exc())","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d1a3b3c626ce4838592e3e9f666bf5c5047c118b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                            raise"},{"line_number":97,"context_line":"            except Exception as e:"},{"line_number":98,"context_line":"                exceptions.append(\u0027\u0027.join("},{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"},{"line_number":101,"context_line":"            exceptions.insert(0, \u0027Too many errors to continue:\u0027)"},{"line_number":102,"context_line":"            raise Exception(\u0027\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\n\u0027.join(exceptions))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_dc3e628a","line":99,"in_reply_to":"5fc1f717_1ee70249","updated":"2019-04-02 18:33:17.000000000","message":"thanks!","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"889ccabada8f985b7d0b053e96b3e1efc3de4681","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"},{"line_number":101,"context_line":"            exceptions.insert(0, \u0027Too many errors to continue:\u0027)"},{"line_number":102,"context_line":"            raise Exception(\u0027\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\n\u0027.join(exceptions))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def make_request(self, method, bucket\u003d\u0027\u0027, obj\u003d\u0027\u0027, headers\u003dNone, body\u003d\u0027\u0027,"},{"line_number":105,"context_line":"                     query\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_1e9942cf","line":102,"range":{"start_line":102,"start_character":18,"end_line":102,"end_character":27},"updated":"2019-04-02 16:55:35.000000000","message":"I wonder if it\u0027d be worth defining a new CleanupException or something... *shrug*","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d1a3b3c626ce4838592e3e9f666bf5c5047c118b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    traceback.format_exception(*sys.exc_info())))"},{"line_number":100,"context_line":"        if exceptions:"},{"line_number":101,"context_line":"            exceptions.insert(0, \u0027Too many errors to continue:\u0027)"},{"line_number":102,"context_line":"            raise Exception(\u0027\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\n\u0027.join(exceptions))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def make_request(self, method, bucket\u003d\u0027\u0027, obj\u003d\u0027\u0027, headers\u003dNone, body\u003d\u0027\u0027,"},{"line_number":105,"context_line":"                     query\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_1c5e2ae9","line":102,"range":{"start_line":102,"start_character":18,"end_line":102,"end_character":27},"in_reply_to":"5fc1f717_1e9942cf","updated":"2019-04-02 18:33:17.000000000","message":"meh, hard to say - i\u0027d be happy to do it and see what it looks like; but probably either is fine - I doubt it\u0027s worth waffling about.","commit_id":"9d9f8b0ff2865f5b9899f2a60b1bd8bead31186f"}]}
