)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5dc5169855d3206422fff998c543fe6d590ba2da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Romain LE DISEZ \u003cromain.le-disez@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-04 10:14:48 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SSYNC: Remove reverted objects as soon as possible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables the SSYNC receiver to returns the list of objects"},{"line_number":10,"context_line":"hash with their status. If all revert jobs of a given (object, timestamps)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_e8a00a45","line":7,"updated":"2019-04-04 14:31:50.000000000","message":"can you add some more detail, is this \"as soon as possible\" or just \"sooner\"?","commit_id":"77230447ea0583f17b27892c0319a12d711853a7"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"b20f268913c7e8b5d07ff25ece67b5d127a289a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Romain LE DISEZ \u003cromain.le-disez@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-04 10:14:48 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SSYNC: Remove reverted objects as soon as possible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables the SSYNC receiver to returns the list of objects"},{"line_number":10,"context_line":"hash with their status. If all revert jobs of a given (object, timestamps)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_5d5f8b40","line":7,"in_reply_to":"5fc1f717_e8a00a45","updated":"2019-04-05 14:38:17.000000000","message":"With this new code, the reconstructor won\u0027t wait for the whole partition to be reverted before removing it from the handoff device. When an object is confirmed to be reverted on all needed devices, it will be deleted.\n\nMaybe I should write \"Remove reverted objects as soon as it is safe to do\"","commit_id":"77230447ea0583f17b27892c0319a12d711853a7"}],"swift/obj/reconstructor.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5dc5169855d3206422fff998c543fe6d590ba2da","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        reverted_objs \u003d dict((ohash, dict(ts))"},{"line_number":881,"context_line":"                             for (ohash, ts), successes in in_sync_objs.items()"},{"line_number":882,"context_line":"                             if all(successes))"},{"line_number":883,"context_line":"        self.delete_reverted_objs(job, reverted_objs, job[\u0027frag_index\u0027])"},{"line_number":884,"context_line":"        self.logger.timing_since(\u0027partition.delete.timing\u0027, begin)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"    def _get_part_jobs(self, local_dev, part_path, partition, policy):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_68289a96","line":883,"updated":"2019-04-04 14:31:50.000000000","message":"so this is no longer conditional on all the ssync to all node being successful - so that\u0027s sooner.\n\nCan you elaborate on why/how this is still \"correct\"?","commit_id":"77230447ea0583f17b27892c0319a12d711853a7"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"b20f268913c7e8b5d07ff25ece67b5d127a289a1","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        reverted_objs \u003d dict((ohash, dict(ts))"},{"line_number":881,"context_line":"                             for (ohash, ts), successes in in_sync_objs.items()"},{"line_number":882,"context_line":"                             if all(successes))"},{"line_number":883,"context_line":"        self.delete_reverted_objs(job, reverted_objs, job[\u0027frag_index\u0027])"},{"line_number":884,"context_line":"        self.logger.timing_since(\u0027partition.delete.timing\u0027, begin)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"    def _get_part_jobs(self, local_dev, part_path, partition, policy):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fd1e776e","line":883,"in_reply_to":"5fc1f717_68289a96","updated":"2019-04-05 14:38:17.000000000","message":"It should be correct because now the ssync_receiver returns a success status for each (object, timestamps). So, the ssync_sender knows exactly which objects were successfully reverted and it can delete them.","commit_id":"77230447ea0583f17b27892c0319a12d711853a7"}],"swift/obj/ssync_sender.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5dc5169855d3206422fff998c543fe6d590ba2da","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                        self.node.get(\u0027replication_port\u0027),"},{"line_number":413,"context_line":"                        self.node.get(\u0027device\u0027),"},{"line_number":414,"context_line":"                        self.job.get(\u0027partition\u0027), err)"},{"line_number":415,"context_line":"                ohash_successes.append((ohash, success))"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        return ohash_successes"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a8abe21b","line":415,"updated":"2019-04-04 14:31:50.000000000","message":"we add to successes even if not success?","commit_id":"77230447ea0583f17b27892c0319a12d711853a7"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"b20f268913c7e8b5d07ff25ece67b5d127a289a1","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                        self.node.get(\u0027replication_port\u0027),"},{"line_number":413,"context_line":"                        self.node.get(\u0027device\u0027),"},{"line_number":414,"context_line":"                        self.job.get(\u0027partition\u0027), err)"},{"line_number":415,"context_line":"                ohash_successes.append((ohash, success))"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        return ohash_successes"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_00043814","line":415,"in_reply_to":"5fc1f717_a8abe21b","updated":"2019-04-05 14:38:17.000000000","message":"maybe the variable should be renamed ohash_success_status","commit_id":"77230447ea0583f17b27892c0319a12d711853a7"}]}
