)]}'
{"go/swift-rpc-losf/Makefile":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"ca0999efbf313030cbcbf5861926e857382a5349","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\tcmake -S leveldb -B leveldb/build"},{"line_number":46,"context_line":"\t$(MAKE) -C leveldb/build all"},{"line_number":47,"context_line":"\t# TODO: Make sure if it should run after leveldb install"},{"line_number":48,"context_line":"\tCGO_CFLAGS\u003d/usr/local/include CGO_LDFLAGS\u003d\"-L/usr/local/lib\" go get github.com/jmhodges/levigo"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"install-leveldb:"},{"line_number":51,"context_line":"\t$(MAKE) -C leveldb/build install"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5fc1f717_be950042","line":48,"updated":"2019-04-09 21:48:58.000000000","message":"I have had to move this below, in install-leveldb, otherwise it will not build because the include files are not installed.","commit_id":"ed4699150ded496e55b6d4edea3e80aa90c55f1c"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"2b64152de4d5fe0b5d4791f7419e6c471d5e23ab","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"all: build-snappy build-leveldb build-losf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"install: install-snappy install-leveldb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"build-losf:"},{"line_number":23,"context_line":"\tgo get -u github.com/golang/protobuf/protoc-gen-go"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dfbec78f_dece8182","line":20,"updated":"2019-05-02 21:45:39.000000000","message":"Should we do \"install-snappy\" before \"build-leveldb\"? I think it would need snappy\u0027s include files to build leveldb with snappy support","commit_id":"89b6715e6765eb7b804b47cc7fd0db49a3d9ba4a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"d6101c318af57c2b80502a7e03728128b2fbc096","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"all: build-snappy build-leveldb build-losf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"install: install-snappy install-leveldb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"build-losf:"},{"line_number":23,"context_line":"\tgo get -u github.com/golang/protobuf/protoc-gen-go"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dfbec78f_007d8ab0","line":20,"in_reply_to":"dfbec78f_dece8182","updated":"2019-05-03 18:13:12.000000000","message":"Question resolved at the later patch https://review.opendev.org/#/c/656576/13","commit_id":"89b6715e6765eb7b804b47cc7fd0db49a3d9ba4a"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"239aabad578c2835449337367579457cf0b9df83","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"build-snappy:"},{"line_number":33,"context_line":"\tgit submodule update --init snappy"},{"line_number":34,"context_line":"\tsed -i \u0027s/\\(BUILD_SHARED_LIBS \"Build.*\\) OFF/\\1 ON/\u0027 snappy/CMakeLists.txt"},{"line_number":35,"context_line":"\tmkdir -p snappy/build"},{"line_number":36,"context_line":"\tcmake -S snappy -B snappy/build"},{"line_number":37,"context_line":"\t$(MAKE) -C snappy/build all"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dfbec78f_236f86c6","line":34,"updated":"2019-05-02 21:08:43.000000000","message":"Could we use \" -DBUILD_SHARED_LIBS\u003dON \" instead, in the cmake command below?","commit_id":"89b6715e6765eb7b804b47cc7fd0db49a3d9ba4a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"d6101c318af57c2b80502a7e03728128b2fbc096","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"build-snappy:"},{"line_number":33,"context_line":"\tgit submodule update --init snappy"},{"line_number":34,"context_line":"\tsed -i \u0027s/\\(BUILD_SHARED_LIBS \"Build.*\\) OFF/\\1 ON/\u0027 snappy/CMakeLists.txt"},{"line_number":35,"context_line":"\tmkdir -p snappy/build"},{"line_number":36,"context_line":"\tcmake -S snappy -B snappy/build"},{"line_number":37,"context_line":"\t$(MAKE) -C snappy/build all"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dfbec78f_a04b5e85","line":34,"in_reply_to":"dfbec78f_236f86c6","updated":"2019-05-03 18:13:12.000000000","message":"Ditto","commit_id":"89b6715e6765eb7b804b47cc7fd0db49a3d9ba4a"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"239aabad578c2835449337367579457cf0b9df83","unresolved":false,"context_lines":[{"line_number":42,"context_line":"build-leveldb:"},{"line_number":43,"context_line":"\tgit submodule update --init leveldb"},{"line_number":44,"context_line":"\t# add set(BUILD_SHARED_LIBS ON) to leveldb/CMakeLists.txt (only if it doesn\u0027t exist)"},{"line_number":45,"context_line":"\tgrep -q -x -F \u0027set(BUILD_SHARED_LIBS ON)\u0027 leveldb/CMakeLists.txt || echo \u0027set(BUILD_SHARED_LIBS ON)\u0027 \u003e\u003e leveldb/CMakeLists.txt"},{"line_number":46,"context_line":"\tmkdir -p leveldb/build"},{"line_number":47,"context_line":"\tcmake -S leveldb -B leveldb/build"},{"line_number":48,"context_line":"\t$(MAKE) -C leveldb/build all"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dfbec78f_230d4690","line":45,"updated":"2019-05-02 21:08:43.000000000","message":"Same here, use -D option?","commit_id":"89b6715e6765eb7b804b47cc7fd0db49a3d9ba4a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"d6101c318af57c2b80502a7e03728128b2fbc096","unresolved":false,"context_lines":[{"line_number":42,"context_line":"build-leveldb:"},{"line_number":43,"context_line":"\tgit submodule update --init leveldb"},{"line_number":44,"context_line":"\t# add set(BUILD_SHARED_LIBS ON) to leveldb/CMakeLists.txt (only if it doesn\u0027t exist)"},{"line_number":45,"context_line":"\tgrep -q -x -F \u0027set(BUILD_SHARED_LIBS ON)\u0027 leveldb/CMakeLists.txt || echo \u0027set(BUILD_SHARED_LIBS ON)\u0027 \u003e\u003e leveldb/CMakeLists.txt"},{"line_number":46,"context_line":"\tmkdir -p leveldb/build"},{"line_number":47,"context_line":"\tcmake -S leveldb -B leveldb/build"},{"line_number":48,"context_line":"\t$(MAKE) -C leveldb/build all"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dfbec78f_c050d235","line":45,"in_reply_to":"dfbec78f_230d4690","updated":"2019-05-03 18:13:12.000000000","message":"ditto","commit_id":"89b6715e6765eb7b804b47cc7fd0db49a3d9ba4a"}],"go/swift-rpc-losf/README.md":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"ca0999efbf313030cbcbf5861926e857382a5349","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Setup"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":"You will need a working golang environment, gcc and tools (build-essential), and cmake \u003e\u003d 3.9 (ubuntu 16.04 has a version that is too old, get it from cmake.org)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"GO\u003e\u003d1.11 is required to support go modules (https://github.com/golang/go/wiki/Modules)."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5fc1f717_9eb04442","line":5,"updated":"2019-04-09 21:48:58.000000000","message":"I think we will need to change this, with cmake 3.10 it fails to build, I think because the \"B\" option has changed. With 3.14 from cmake.org it works","commit_id":"ed4699150ded496e55b6d4edea3e80aa90c55f1c"}]}