)]}'
{"go/swift-rpc-losf/Makefile":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"0055a2ab542b05a8dca71c5980c6bbc474701822","unresolved":false,"context_lines":[{"line_number":39,"context_line":"build-leveldb:"},{"line_number":40,"context_line":"\tgit submodule update --init leveldb"},{"line_number":41,"context_line":"\t# add set(BUILD_SHARED_LIBS ON) to leveldb/CMakeLists.txt (only if it doesn\u0027t exist)"},{"line_number":42,"context_line":"\t# grep -q -x -F \u0027set(BUILD_SHARED_LIBS ON)\u0027 leveldb/CMakeLists.txt || echo \u0027set(BUILD_SHARED_LIBS ON)\u0027 \u003e\u003e leveldb/CMakeLists.txt"},{"line_number":43,"context_line":"\tmkdir -p leveldb/build"},{"line_number":44,"context_line":"\tcmake -DBUILD_SHARED_LIBS\u003dON -S leveldb -B leveldb/build"},{"line_number":45,"context_line":"\t# $(MAKE) -C leveldb/build all"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5fc1f717_4cf0e491","line":42,"updated":"2019-04-10 12:46:59.000000000","message":"this does not work because it should appear earlier in the file. I found it easier to pass the \"D\" option, which I did not know about previously","commit_id":"59665483a52d9caac8f9eaedfd1c26ed885d0d65"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2bf648e017c64d0774671c6ade0ffdda434fdcca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"build-leveldb:"},{"line_number":40,"context_line":"\tgit submodule update --init leveldb"},{"line_number":41,"context_line":"\t# add set(BUILD_SHARED_LIBS ON) to leveldb/CMakeLists.txt (only if it doesn\u0027t exist)"},{"line_number":42,"context_line":"\t# grep -q -x -F \u0027set(BUILD_SHARED_LIBS ON)\u0027 leveldb/CMakeLists.txt || echo \u0027set(BUILD_SHARED_LIBS ON)\u0027 \u003e\u003e leveldb/CMakeLists.txt"},{"line_number":43,"context_line":"\tmkdir -p leveldb/build"},{"line_number":44,"context_line":"\tcmake -DBUILD_SHARED_LIBS\u003dON -S leveldb -B leveldb/build"},{"line_number":45,"context_line":"\t# $(MAKE) -C leveldb/build all"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fce034c_b64725bd","line":42,"in_reply_to":"5fc1f717_4cf0e491","updated":"2019-05-02 00:27:29.000000000","message":"OK. It looks fine.\nIf we don\u0027t need this line, please remove it instead of commenting out.","commit_id":"59665483a52d9caac8f9eaedfd1c26ed885d0d65"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2bf648e017c64d0774671c6ade0ffdda434fdcca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t# add set(BUILD_SHARED_LIBS ON) to leveldb/CMakeLists.txt (only if it doesn\u0027t exist)"},{"line_number":42,"context_line":"\t# grep -q -x -F \u0027set(BUILD_SHARED_LIBS ON)\u0027 leveldb/CMakeLists.txt || echo \u0027set(BUILD_SHARED_LIBS ON)\u0027 \u003e\u003e leveldb/CMakeLists.txt"},{"line_number":43,"context_line":"\tmkdir -p leveldb/build"},{"line_number":44,"context_line":"\tcmake -DBUILD_SHARED_LIBS\u003dON -S leveldb -B leveldb/build"},{"line_number":45,"context_line":"\t# $(MAKE) -C leveldb/build all"},{"line_number":46,"context_line":"\tcmake --build leveldb/build"},{"line_number":47,"context_line":"\t# TODO: Make sure if it should run after leveldb install"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fce034c_b675e5fc","line":44,"updated":"2019-05-02 00:27:29.000000000","message":"OK. cmake supports -D option for supporting specific vars.\n\n https://cmake.org/cmake/help/v3.5/manual/cmake.1.html","commit_id":"59665483a52d9caac8f9eaedfd1c26ed885d0d65"}]}