)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eeff9cbf6f4dc537c8f566b54629d0629054a4da","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added a test for S3 v1 listings that use URL encoding and have non-ASCII"},{"line_number":10,"context_line":"characters. In the process discovered that the XML schema for"},{"line_number":11,"context_line":"ListBucketResult had a small problem: Delimiter and EncodingType needed"},{"line_number":12,"context_line":"to be reordered."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib3124ea079a73a577b86de97657603a64b16f965"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_92a03292","line":12,"updated":"2019-05-29 22:08:17.000000000","message":"OK, so the *schema* had a bug, but the *implementation* didn\u0027t, have I got that right? And it hadn\u0027t come up before because we only use this particular schema for parsing results in func tests, and our func tests previously didn\u0027t cover the combination of delimiter and encoding-type.","commit_id":"dade632b0fbb10ef9419f2f9bcd063f3f962dbbf"},{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"0ec4dedf59600fa1daf41d9bbd2380f3e5ac16e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added a test for S3 v1 listings that use URL encoding and have non-ASCII"},{"line_number":10,"context_line":"characters. In the process discovered that the XML schema for"},{"line_number":11,"context_line":"ListBucketResult had a small problem: Delimiter and EncodingType needed"},{"line_number":12,"context_line":"to be reordered."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib3124ea079a73a577b86de97657603a64b16f965"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_f2df2e0a","line":12,"in_reply_to":"bfb3d3c7_92a03292","updated":"2019-05-29 22:10:52.000000000","message":"Yes, for the testing issue. The other bug was the not handling of non-ASCII characters in the listing code.","commit_id":"dade632b0fbb10ef9419f2f9bcd063f3f962dbbf"}],"swift/common/middleware/s3api/controllers/bucket.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"eeff9cbf6f4dc537c8f566b54629d0629054a4da","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                    else:"},{"line_number":180,"context_line":"                        name \u003d objects[-1][\u0027subdir\u0027]"},{"line_number":181,"context_line":"                    if encoding_type \u003d\u003d \u0027url\u0027:"},{"line_number":182,"context_line":"                        name \u003d quote(name.encode(\u0027utf-8\u0027))"},{"line_number":183,"context_line":"                    SubElement(elem, \u0027NextMarker\u0027).text \u003d name"},{"line_number":184,"context_line":"            elif listing_type \u003d\u003d \u0027version-2\u0027:"},{"line_number":185,"context_line":"                if is_truncated:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_b2a9b690","line":182,"updated":"2019-05-29 22:08:17.000000000","message":"Good -- looks like passing bytes to quote() on py3 behaves sanely:\n\n \u003e\u003e\u003e quote(u\u0027\\u1234\u0027.encode(\u0027utf8\u0027))\n \u0027%E1%88%B4\u0027","commit_id":"dade632b0fbb10ef9419f2f9bcd063f3f962dbbf"}]}