)]}'
{"id":"openstack%2Fswift~657706","triplet_id":"openstack%2Fswift~master~Ib3124ea079a73a577b86de97657603a64b16f965","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"Ib3124ea079a73a577b86de97657603a64b16f965","subject":"S3Api: handle non-ASCII markers in v1 listings.","status":"MERGED","created":"2019-05-07 23:17:40.000000000","updated":"2019-05-29 23:33:44.000000000","submitted":"2019-05-29 23:32:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"657706-1559172740231-01fcf80d","meta_rev_id":"6179e116a6e45460d2542601e0df4c8a54ec096e","_number":657706,"virtual_id_number":657706,"owner":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-29 23:32:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"date":"2019-05-29 22:10:52.000000000","_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-29 22:08:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-29 22:08:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-29 22:08:17.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-05-29 23:32:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dde833a29ea1ba29326794448b76d19d2830c0f3","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2019-05-07 23:17:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33eb70d73eb85bbd7dde506375e7722ef0f4b626","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-07 23:58:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/06/657706/1/check/openstack-tox-docs/cf69ee9/html/ : SUCCESS in 4m 13s\n- swift-tox-py27 http://logs.openstack.org/06/657706/1/check/swift-tox-py27/1074638/ : SUCCESS in 12m 50s\n- swift-tox-py36 http://logs.openstack.org/06/657706/1/check/swift-tox-py36/b51c0cf/ : FAILURE in 9m 30s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/06/657706/1/check/swift-tox-py37/9570677/ : FAILURE in 10m 12s\n- swift-tox-func http://logs.openstack.org/06/657706/1/check/swift-tox-func/f8683e6/ : SUCCESS in 10m 23s\n- swift-tox-func-encryption http://logs.openstack.org/06/657706/1/check/swift-tox-func-encryption/c599d74/ : SUCCESS in 8m 13s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/06/657706/1/check/swift-tox-func-domain-remap-staticweb/6298dc1/ : SUCCESS in 8m 24s\n- swift-tox-func-ec http://logs.openstack.org/06/657706/1/check/swift-tox-func-ec/114d153/ : SUCCESS in 11m 04s\n- swift-tox-func-s3api http://logs.openstack.org/06/657706/1/check/swift-tox-func-s3api/731c398/ : SUCCESS in 12m 23s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/06/657706/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/2d4d34f/ : SUCCESS in 11m 17s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/06/657706/1/check/swift-probetests-centos-7/ef8641e/ : SUCCESS in 30m 26s\n- swift-dsvm-functional http://logs.openstack.org/06/657706/1/check/swift-dsvm-functional/d4d413c/ : SUCCESS in 26m 49s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/06/657706/1/check/swift-dsvm-functional-ipv6/763e2d5/ : SUCCESS in 27m 29s\n- swift-tox-lower-constraints http://logs.openstack.org/06/657706/1/check/swift-tox-lower-constraints/3291df6/ : SUCCESS in 11m 28s\n- openstack-tox-pep8 http://logs.openstack.org/06/657706/1/check/openstack-tox-pep8/0d3a0f7/ : SUCCESS in 7m 47s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/06/657706/1/check/swift-multinode-rolling-upgrade/9ef766a/ : FAILURE in 8m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"29c4bb4565dce8192deace91af6641aeb966957a","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2019-05-08 19:17:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7a124907446c2561c909587337c06726ee419a05","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-08 20:10:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/06/657706/2/check/openstack-tox-docs/5776dcb/html/ : SUCCESS in 5m 09s\n- swift-build-image http://logs.openstack.org/06/657706/2/check/swift-build-image/e314b3b/ : SUCCESS in 7m 35s\n- swift-tox-py27 http://logs.openstack.org/06/657706/2/check/swift-tox-py27/8f010c7/ : SUCCESS in 19m 45s\n- swift-tox-py36 http://logs.openstack.org/06/657706/2/check/swift-tox-py36/43d1ed8/ : SUCCESS in 7m 46s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/06/657706/2/check/swift-tox-py37/228e226/ : SUCCESS in 16m 27s\n- swift-tox-func http://logs.openstack.org/06/657706/2/check/swift-tox-func/df19dec/ : SUCCESS in 7m 51s\n- swift-tox-func-encryption http://logs.openstack.org/06/657706/2/check/swift-tox-func-encryption/f58a8d3/ : SUCCESS in 8m 44s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/06/657706/2/check/swift-tox-func-domain-remap-staticweb/94afa05/ : SUCCESS in 17m 00s\n- swift-tox-func-ec http://logs.openstack.org/06/657706/2/check/swift-tox-func-ec/53e1e6c/ : SUCCESS in 16m 31s\n- swift-tox-func-s3api http://logs.openstack.org/06/657706/2/check/swift-tox-func-s3api/0309b30/ : SUCCESS in 9m 14s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/06/657706/2/check/swift-tox-func-s3api-ceph-s3tests-tempauth/34dc4da/ : SUCCESS in 13m 48s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/06/657706/2/check/swift-probetests-centos-7/e7acc62/ : SUCCESS in 32m 06s\n- swift-dsvm-functional http://logs.openstack.org/06/657706/2/check/swift-dsvm-functional/7d44311/ : SUCCESS in 22m 37s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/06/657706/2/check/swift-dsvm-functional-ipv6/8a60429/ : SUCCESS in 31m 35s\n- swift-tox-lower-constraints http://logs.openstack.org/06/657706/2/check/swift-tox-lower-constraints/35d78dc/ : SUCCESS in 11m 59s\n- openstack-tox-pep8 http://logs.openstack.org/06/657706/2/check/openstack-tox-pep8/9f46fbd/ : SUCCESS in 6m 07s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/06/657706/2/check/swift-multinode-rolling-upgrade/3ea4bcf/ : FAILURE in 7m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"eeff9cbf6f4dc537c8f566b54629d0629054a4da","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-05-29 22:08:17.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"6dddfdb5f6a322f0dac635ca8c2eecbc566963d5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 22:09:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0ec4dedf59600fa1daf41d9bbd2380f3e5ac16e5","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2019-05-29 22:10:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"91afa88f6c83203a1cbf0910e669234274ff3cc6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 23:32:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/06/657706/2/gate/openstack-tox-docs/0a5fbc9/html/ : SUCCESS in 3m 43s\n- swift-upload-image http://logs.openstack.org/06/657706/2/gate/swift-upload-image/c1371d0/ : SUCCESS in 8m 34s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/06/657706/2/gate/swift-tox-py27/68f97fd/ : SUCCESS in 11m 42s\n- swift-tox-py37 http://logs.openstack.org/06/657706/2/gate/swift-tox-py37/3a63f8f/ : SUCCESS in 11m 06s\n- swift-tox-func http://logs.openstack.org/06/657706/2/gate/swift-tox-func/6de7c37/ : SUCCESS in 8m 43s\n- swift-tox-func-py37 http://logs.openstack.org/06/657706/2/gate/swift-tox-func-py37/6e15de0/ : SUCCESS in 8m 32s\n- swift-tox-func-encryption http://logs.openstack.org/06/657706/2/gate/swift-tox-func-encryption/33de004/ : SUCCESS in 10m 10s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/06/657706/2/gate/swift-tox-func-domain-remap-staticweb/5f8d7cb/ : SUCCESS in 8m 32s\n- swift-tox-func-ec http://logs.openstack.org/06/657706/2/gate/swift-tox-func-ec/253b418/ : SUCCESS in 28m 58s\n- swift-tox-func-s3api http://logs.openstack.org/06/657706/2/gate/swift-tox-func-s3api/3b4a02d/ : SUCCESS in 11m 54s\n- swift-probetests-centos-7 http://logs.openstack.org/06/657706/2/gate/swift-probetests-centos-7/3c9f10c/ : SUCCESS in 29m 32s\n- swift-dsvm-functional http://logs.openstack.org/06/657706/2/gate/swift-dsvm-functional/c716e76/ : SUCCESS in 30m 34s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/06/657706/2/gate/swift-dsvm-functional-ipv6/83fbcd2/ : SUCCESS in 29m 01s\n- swift-tox-lower-constraints http://logs.openstack.org/06/657706/2/gate/swift-tox-lower-constraints/47235c6/ : SUCCESS in 12m 52s\n- openstack-tox-pep8 http://logs.openstack.org/06/657706/2/gate/openstack-tox-pep8/154b8e0/ : SUCCESS in 5m 22s","accounts_in_message":[],"_revision_number":2},{"id":"f187f7a71e5dde815d1c9eb73b7d022979d9abbe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 23:32:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"6179e116a6e45460d2542601e0df4c8a54ec096e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 23:33:44.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- swift-promote-image http://logs.openstack.org/06/657706/2/promote/swift-promote-image/8b712ff/ : SUCCESS in 49s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dade632b0fbb10ef9419f2f9bcd063f3f962dbbf","revisions":{"1faeaa69931cdbee916160941e30515c19596849":{"kind":"REWORK","_number":1,"created":"2019-05-07 23:17:40.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/06/657706/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/06/657706/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/657706/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/657706/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/657706/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/06/657706/1"}}},"commit":{"parents":[{"commit":"e85dda286e975d69b8a00ab978b9147b3a74a965","subject":"Merge \"Require logger passed to broker in unit tests for account-reaper\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e85dda286e975d69b8a00ab978b9147b3a74a965"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2019-05-07 23:15:59.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2019-05-07 23:17:34.000000000","tz":-420},"subject":"S3Api: handle non-ASCII markers in v1 listings.","message":"S3Api: handle non-ASCII markers in v1 listings.\n\nAdded a test for S3 v1 listings that use URL encoding and have non-ASCII\ncharacters. In the process discovered that the XML schema for\nListBucketResult had a small problem: Delimiter and EncodingType needed\nto be reordered.\n\nChange-Id: Ib3124ea079a73a577b86de97657603a64b16f965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1faeaa69931cdbee916160941e30515c19596849"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1faeaa69931cdbee916160941e30515c19596849"}]},"branch":"refs/heads/master"},"dade632b0fbb10ef9419f2f9bcd063f3f962dbbf":{"kind":"REWORK","_number":2,"created":"2019-05-08 19:17:38.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/06/657706/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/06/657706/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/657706/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/657706/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/06/657706/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/06/657706/2"}}},"commit":{"parents":[{"commit":"e85dda286e975d69b8a00ab978b9147b3a74a965","subject":"Merge \"Require logger passed to broker in unit tests for account-reaper\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e85dda286e975d69b8a00ab978b9147b3a74a965"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2019-05-07 23:15:59.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2019-05-08 19:17:38.000000000","tz":-420},"subject":"S3Api: handle non-ASCII markers in v1 listings.","message":"S3Api: handle non-ASCII markers in v1 listings.\n\nAdded a test for S3 v1 listings that use URL encoding and have non-ASCII\ncharacters. In the process discovered that the XML schema for\nListBucketResult had a small problem: Delimiter and EncodingType needed\nto be reordered.\n\nChange-Id: Ib3124ea079a73a577b86de97657603a64b16f965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/dade632b0fbb10ef9419f2f9bcd063f3f962dbbf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/dade632b0fbb10ef9419f2f9bcd063f3f962dbbf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}