)]}'
{"id":"openstack%2Fswift~658921","triplet_id":"openstack%2Fswift~master~I283757cd3084b1c83a1e9bf0f46b6ce9d7ee8eb9","project":"openstack/swift","branch":"master","topic":"s3-api-tests","hashtags":[],"change_id":"I283757cd3084b1c83a1e9bf0f46b6ce9d7ee8eb9","subject":"Have a separate s3api functional test suite","status":"MERGED","created":"2019-05-13 21:03:12.000000000","updated":"2019-06-04 18:04:14.000000000","submitted":"2019-06-04 18:02:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658921-1559671369696-b9ca8759","meta_rev_id":"f3145ce2c98a837f2f650e94591e17e0179ad434","_number":658921,"virtual_id_number":658921,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-04 18:02:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-24 20:26:32.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":2,"date":"2019-06-04 16:48:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":1,"date":"2019-06-04 16:48:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-04 16:48:43.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-06-04 18:02:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b19855897d3d2882d05197493a0d2267cff5697b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-05-13 21:03:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"88d3d089b17d5fcefdad39cb5176176375aa70fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 23:16:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/21/658921/1/check/openstack-tox-docs/7c0f08b/html/ : SUCCESS in 4m 16s\n- swift-build-image http://logs.openstack.org/21/658921/1/check/swift-build-image/4b9c00d/ : SUCCESS in 8m 27s\n- swift-tox-py27 http://logs.openstack.org/21/658921/1/check/swift-tox-py27/e5187be/ : SUCCESS in 10m 39s\n- swift-tox-py36 http://logs.openstack.org/21/658921/1/check/swift-tox-py36/ba17cee/ : SUCCESS in 8m 58s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/21/658921/1/check/swift-tox-py37/33277b5/ : SUCCESS in 8m 02s\n- swift-tox-func http://logs.openstack.org/21/658921/1/check/swift-tox-func/ad1c477/ : SUCCESS in 8m 34s\n- swift-tox-func-encryption http://logs.openstack.org/21/658921/1/check/swift-tox-func-encryption/b85c4bf/ : SUCCESS in 8m 23s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/21/658921/1/check/swift-tox-func-domain-remap-staticweb/cfd8db4/ : SUCCESS in 8m 14s\n- swift-tox-func-ec http://logs.openstack.org/21/658921/1/check/swift-tox-func-ec/a374337/ : FAILURE in 21m 22s\n- swift-tox-func-s3api http://logs.openstack.org/21/658921/1/check/swift-tox-func-s3api/7c0e5d2/ : FAILURE in 19m 33s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/21/658921/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/bd05034/ : SUCCESS in 13m 08s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/21/658921/1/check/swift-probetests-centos-7/73dd86b/ : SUCCESS in 28m 57s\n- swift-dsvm-functional http://logs.openstack.org/21/658921/1/check/swift-dsvm-functional/48d0e8a/ : SUCCESS in 27m 46s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/21/658921/1/check/swift-dsvm-functional-ipv6/3f6dccd/ : SUCCESS in 27m 18s\n- swift-tox-lower-constraints http://logs.openstack.org/21/658921/1/check/swift-tox-lower-constraints/bb7e971/ : SUCCESS in 11m 32s\n- openstack-tox-pep8 http://logs.openstack.org/21/658921/1/check/openstack-tox-pep8/e135801/ : SUCCESS in 5m 07s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/21/658921/1/check/swift-multinode-rolling-upgrade/4fe8baf/ : FAILURE in 8m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7a9c6105f0afec906f525bd9cea2a81d676ddd6d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-05-18 04:26:38.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"f07da8c60d9183bbeddf492db94ad37732444598","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-18 05:15:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/21/658921/1/check/openstack-tox-docs/b822895/html/ : SUCCESS in 4m 38s\n- swift-build-image http://logs.openstack.org/21/658921/1/check/swift-build-image/fb0ec8e/ : SUCCESS in 8m 11s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/21/658921/1/check/swift-tox-py27/949f7e1/ : SUCCESS in 11m 14s\n- swift-tox-py36 http://logs.openstack.org/21/658921/1/check/swift-tox-py36/5077c1f/ : SUCCESS in 10m 38s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/21/658921/1/check/swift-tox-py37/244ab9b/ : SUCCESS in 10m 13s\n- swift-tox-func http://logs.openstack.org/21/658921/1/check/swift-tox-func/86cb272/ : SUCCESS in 9m 03s\n- swift-tox-func-encryption http://logs.openstack.org/21/658921/1/check/swift-tox-func-encryption/5cd308a/ : SUCCESS in 9m 48s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/21/658921/1/check/swift-tox-func-domain-remap-staticweb/eb0bd59/ : SUCCESS in 9m 12s\n- swift-tox-func-ec http://logs.openstack.org/21/658921/1/check/swift-tox-func-ec/3e43ec5/ : SUCCESS in 10m 21s\n- swift-tox-func-s3api http://logs.openstack.org/21/658921/1/check/swift-tox-func-s3api/d5f1ea4/ : SUCCESS in 11m 12s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/21/658921/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/e4c6765/ : SUCCESS in 14m 58s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/21/658921/1/check/swift-probetests-centos-7/e523f7b/ : SUCCESS in 31m 13s\n- swift-dsvm-functional http://logs.openstack.org/21/658921/1/check/swift-dsvm-functional/de74dad/ : SUCCESS in 35m 07s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/21/658921/1/check/swift-dsvm-functional-ipv6/e827348/ : SUCCESS in 24m 24s\n- swift-tox-lower-constraints http://logs.openstack.org/21/658921/1/check/swift-tox-lower-constraints/a9eb858/ : SUCCESS in 12m 13s\n- openstack-tox-pep8 http://logs.openstack.org/21/658921/1/check/openstack-tox-pep8/b89d809/ : SUCCESS in 5m 51s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/21/658921/1/check/swift-multinode-rolling-upgrade/03e5d63/ : FAILURE in 8m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3ee18fd9a4aec6dbe4bbd570ed6086ffe1825adb","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-05-23 20:04:03.000000000","message":"Patch Set 1: Code-Review-1\n\nAll these tests are failing for me, I\u0027m having some kind of configuration problem...\n\nIn my proxy config I have:\n\n\t[filter:tempauth]\n\tuse \u003d egg:swift#tempauth\n\tuser_admin_admin \u003d admin .admin .reseller_admin\n\tuser_test_tester \u003d testing .admin\n\tuser_test_tester2 \u003d testing2 .admin\n\tuser_test_tester3 \u003d testing3\n\tuser_test2_tester2 \u003d testing2 .admin\n\n... and in my test.conf I\u0027ve added:\n\n\t[s3api_test]\n\tendpoint \u003d http://saio:8080\n\taccess_key1 \u003d test:tester\n\tsecret_key1 \u003d testing\n\taccess_key2 \u003d test:tester2\n\tsecret_key2 \u003d testing2\n\taccess_key3 \u003d test:tester3\n\tsecret_key3 \u003d testing3\n\nBut I\u0027m getting either AccessDenied or something about the bucket listing not working.\n\nMaybe worse I have no idea how to map all these required access secrets to users on my for-realzy aws account!?\n\nIf we simplify this to start and just do one user and then start porting func.s3api tests to boto3 under this new suite - how far do you think we can get before we need to add these additional accounts?","accounts_in_message":[],"_revision_number":1},{"id":"050e34de1d7132784330ee2e124db1b7b630f1a0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-05-24 16:32:15.000000000","message":"Patch Set 1:\n\nHmm... I wonder if that\u0027s related to https://review.opendev.org/#/c/660196/ ...","accounts_in_message":[],"_revision_number":1},{"id":"a06282fc53837d07b63c9a9f715eaff4dad65832","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-05-24 20:26:32.000000000","message":"Patch Set 1:\n\nNope! Never mind -- that\u0027s unrelated.\n\nSince we\u0027re explicitly targeting S3\u0027s API, we have to be more opinionated about our s3api config. Try setting\n\n s3_acl \u003d True\n check_bucket_owner \u003d True\n\nI\u0027ll have to update the commit message to reflect that.","accounts_in_message":[],"_revision_number":1},{"id":"c5af1fb19e0e1d400a8a32a5d9b2f2b31ec37f56","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-06-04 16:48:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThat worked, thanks Tim!\n\nGood to go with vsaio:\n\nhttps://github.com/swiftstack/vagrant-swift-all-in-one/commit/39962df3ee46c646c7cdb5a633602467cfb7b731\n\nHopefully next person can figure it out more easily:\n\nhttps://review.opendev.org/#/c/663098/1","accounts_in_message":[],"_revision_number":1},{"id":"fa4fe50681cf90d077a4a55478e3b1dc7b20cb47","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 16:49:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2589cff3f5463ad7e4a589786fd61bae5ed04fc1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 18:02:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/21/658921/1/gate/openstack-tox-docs/d5165b5/html/ : SUCCESS in 4m 52s\n- swift-upload-image http://logs.openstack.org/21/658921/1/gate/swift-upload-image/54e6216/ : SUCCESS in 11m 27s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/21/658921/1/gate/swift-tox-py27/1af0f2b/ : SUCCESS in 27m 06s\n- swift-tox-py37 http://logs.openstack.org/21/658921/1/gate/swift-tox-py37/eea1bf4/ : SUCCESS in 11m 21s\n- swift-tox-func http://logs.openstack.org/21/658921/1/gate/swift-tox-func/cac00c4/ : SUCCESS in 14m 59s\n- swift-tox-func-py37 http://logs.openstack.org/21/658921/1/gate/swift-tox-func-py37/5ed089c/ : SUCCESS in 6m 42s\n- swift-tox-func-encryption http://logs.openstack.org/21/658921/1/gate/swift-tox-func-encryption/8efaaaf/ : SUCCESS in 16m 00s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/21/658921/1/gate/swift-tox-func-domain-remap-staticweb/04c6cb2/ : SUCCESS in 8m 22s\n- swift-tox-func-ec http://logs.openstack.org/21/658921/1/gate/swift-tox-func-ec/ad94127/ : SUCCESS in 9m 15s\n- swift-tox-func-s3api http://logs.openstack.org/21/658921/1/gate/swift-tox-func-s3api/67be27e/ : SUCCESS in 12m 27s\n- swift-probetests-centos-7 http://logs.openstack.org/21/658921/1/gate/swift-probetests-centos-7/4021e21/ : SUCCESS in 35m 21s\n- swift-dsvm-functional http://logs.openstack.org/21/658921/1/gate/swift-dsvm-functional/06d866e/ : SUCCESS in 26m 46s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/21/658921/1/gate/swift-dsvm-functional-ipv6/0363afb/ : SUCCESS in 33m 29s\n- swift-tox-lower-constraints http://logs.openstack.org/21/658921/1/gate/swift-tox-lower-constraints/4312b65/ : SUCCESS in 20m 48s\n- openstack-tox-pep8 http://logs.openstack.org/21/658921/1/gate/openstack-tox-pep8/a1ea613/ : SUCCESS in 5m 43s","accounts_in_message":[],"_revision_number":1},{"id":"3adf5a93a20c388d5ccd5528c83acb6552dc3b45","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 18:02:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"547b47cf9caf7533156c1dfca16833a3121a2bc3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 18:04:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- swift-promote-image http://logs.openstack.org/21/658921/1/promote/swift-promote-image/bda0064/ : SUCCESS in 1m 00s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"89c9c6f0b27fcc208996590610df8b04bec2ebc8","revisions":{"89c9c6f0b27fcc208996590610df8b04bec2ebc8":{"kind":"REWORK","_number":1,"created":"2019-05-13 21:03:12.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/21/658921/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/21/658921/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/21/658921/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/21/658921/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/21/658921/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/21/658921/1"}}},"commit":{"parents":[{"commit":"1c899f78d4636f7e6105241a77c55637c419a11b","subject":"Merge \"py3: Stop using stdlib\u0027s putrequest(); it only does ASCII\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1c899f78d4636f7e6105241a77c55637c419a11b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-05-03 23:38:29.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-05-13 21:03:03.000000000","tz":-420},"subject":"Have a separate s3api functional test suite","message":"Have a separate s3api functional test suite\n\nThe idea is that we should have a suite of pure-S3 tests that we can\npoint at AWS to verify that we\u0027ve written accurate tests, then point at\nSwift-with-s3api to verify that we\u0027ve correctly implemented the S3 api.\n\nAs a start, just check GET Service; go ahead and create a few buckets\nso we can see them in the service listing.\n\nChange-Id: I283757cd3084b1c83a1e9bf0f46b6ce9d7ee8eb9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/89c9c6f0b27fcc208996590610df8b04bec2ebc8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/89c9c6f0b27fcc208996590610df8b04bec2ebc8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}