)]}'
{"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"5937962082519c39b1a34b96e8f682524f67fe7e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class md5(object):"},{"line_number":74,"context_line":"    def __init__(self, s\u003db\u0027\u0027):"},{"line_number":75,"context_line":"        if not isinstance(s, bytes):"},{"line_number":76,"context_line":"            s \u003d s.encode(\u0027ascii\u0027)"},{"line_number":77,"context_line":"        self.md \u003d _md5(s)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update(self, s\u003db\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_b5dbe24c","line":76,"updated":"2019-05-16 02:12:09.000000000","message":"This is for test strings, right? In that case, it probably should not be \u0027ascii\u0027, for test_body\u003d\"テスト\" and the like.","commit_id":"7974e68213197791e833da01f1ff236f4f7f8de7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ff2b18077a39593a3c27ae58268044c2b34575fb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class md5(object):"},{"line_number":74,"context_line":"    def __init__(self, s\u003db\u0027\u0027):"},{"line_number":75,"context_line":"        if not isinstance(s, bytes):"},{"line_number":76,"context_line":"            s \u003d s.encode(\u0027ascii\u0027)"},{"line_number":77,"context_line":"        self.md \u003d _md5(s)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update(self, s\u003db\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_9801333b","line":76,"in_reply_to":"dfbec78f_b5dbe24c","updated":"2019-05-16 04:29:50.000000000","message":"Mainly for things like filenames, actually; I was getting tired of changing things like\n\n            hasher \u003d md5()\n            hasher.update(metadata_filename)\n            hasher.update(timestamp.internal + \u0027.durable\u0027)\n\nto be\n\n            hasher \u003d md5()\n            hasher.update(metadata_filename.encode())\n            hasher.update(timestamp.internal.encode() + b\u0027.durable\u0027)\n\nFor any object data, I\u0027d still prefer something like\n\n test_body \u003d b\u0027\\xe3\\x83\\x86\\xe3\\x82\\xb9\\xe3\\x83\\x88\u0027\n\nor\n\n test_body \u003d u\u0027テスト\u0027.encode(\u0027utf8\u0027)","commit_id":"7974e68213197791e833da01f1ff236f4f7f8de7"}]}