)]}'
{"id":"openstack%2Fswift~660196","triplet_id":"openstack%2Fswift~master~I571c16c196dae4e4f8fb41904c8850d0054b1fe9","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I571c16c196dae4e4f8fb41904c8850d0054b1fe9","subject":"s3api: Allow clients to upload with UNSIGNED-PAYLOAD","status":"MERGED","created":"2019-05-20 18:44:48.000000000","updated":"2019-06-06 01:17:51.000000000","submitted":"2019-06-06 01:16:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"660196-1559783809514-bc982933","meta_rev_id":"fd0ed497c2d18bb26f3036e76aa7f3ace760e49c","_number":660196,"virtual_id_number":660196,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2019-06-06 01:16:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2019-06-05 23:56:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2019-06-05 23:56:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-05 23:56:13.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-06-06 01:16:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1e2d690b032f77b4b4a2419cd3183f8ed71baa80","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-05-20 18:44:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8c92893b22996031d633e91f036e8626cc68976","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 22:55:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/96/660196/1/check/openstack-tox-docs/303605b/html/ : SUCCESS in 5m 47s\n- swift-build-image http://logs.openstack.org/96/660196/1/check/swift-build-image/74933f4/ : SUCCESS in 8m 05s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/96/660196/1/check/swift-tox-py27/3582ec8/ : SUCCESS in 10m 25s\n- swift-tox-py36 http://logs.openstack.org/96/660196/1/check/swift-tox-py36/4f42175/ : SUCCESS in 10m 03s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/96/660196/1/check/swift-tox-py37/03b3508/ : SUCCESS in 10m 18s\n- swift-tox-func http://logs.openstack.org/96/660196/1/check/swift-tox-func/569b2dc/ : SUCCESS in 8m 36s\n- swift-tox-func-py37 http://logs.openstack.org/96/660196/1/check/swift-tox-func-py37/7ec0338/ : SUCCESS in 11m 52s\n- swift-tox-func-encryption http://logs.openstack.org/96/660196/1/check/swift-tox-func-encryption/3bc738e/ : SUCCESS in 12m 22s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/96/660196/1/check/swift-tox-func-domain-remap-staticweb/4f09fbe/ : SUCCESS in 8m 25s\n- swift-tox-func-ec http://logs.openstack.org/96/660196/1/check/swift-tox-func-ec/8f58ce1/ : SUCCESS in 11m 09s\n- swift-tox-func-s3api http://logs.openstack.org/96/660196/1/check/swift-tox-func-s3api/fb478eb/ : SUCCESS in 13m 14s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/96/660196/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/6b684ac/ : SUCCESS in 12m 03s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/96/660196/1/check/swift-probetests-centos-7/1c88e0d/ : SUCCESS in 37m 16s\n- swift-dsvm-functional http://logs.openstack.org/96/660196/1/check/swift-dsvm-functional/56a547d/ : SUCCESS in 26m 22s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/96/660196/1/check/swift-dsvm-functional-ipv6/9782252/ : SUCCESS in 25m 48s\n- swift-tox-lower-constraints http://logs.openstack.org/96/660196/1/check/swift-tox-lower-constraints/fc60652/ : SUCCESS in 11m 37s\n- openstack-tox-pep8 http://logs.openstack.org/96/660196/1/check/openstack-tox-pep8/07a7b96/ : SUCCESS in 5m 37s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/96/660196/1/check/swift-multinode-rolling-upgrade/1ee15dc/ : FAILURE in 9m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cb2c37da20e6986771dcf6e24bd0891a1408f71d","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-06-05 23:56:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nchange and test seem straight forward and make sense...\n\nI just wish we had more detail on the client observed the issue in the first place so we could duplicate it and make sure it\u0027s fixed.","accounts_in_message":[],"_revision_number":1},{"id":"b9688c30efcd03db9d2cfd104ba1a15a011dbd3a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 23:56:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"10d79e7c77734cfa8cdc74c2476dda55f442774d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-06 01:16:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/96/660196/1/gate/openstack-tox-docs/c3c4b98/html/ : SUCCESS in 3m 58s\n- swift-upload-image http://logs.openstack.org/96/660196/1/gate/swift-upload-image/a292d3d/ : SUCCESS in 7m 57s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/96/660196/1/gate/swift-tox-py27/e2722d7/ : SUCCESS in 10m 15s\n- swift-tox-py37 http://logs.openstack.org/96/660196/1/gate/swift-tox-py37/b576ae7/ : SUCCESS in 10m 38s\n- swift-tox-func http://logs.openstack.org/96/660196/1/gate/swift-tox-func/43f730f/ : SUCCESS in 11m 02s\n- swift-tox-func-py37 http://logs.openstack.org/96/660196/1/gate/swift-tox-func-py37/f30f593/ : SUCCESS in 8m 18s\n- swift-tox-func-encryption http://logs.openstack.org/96/660196/1/gate/swift-tox-func-encryption/566b878/ : SUCCESS in 8m 21s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/96/660196/1/gate/swift-tox-func-domain-remap-staticweb/516199a/ : SUCCESS in 8m 39s\n- swift-tox-func-ec http://logs.openstack.org/96/660196/1/gate/swift-tox-func-ec/0bc3e28/ : SUCCESS in 15m 23s\n- swift-tox-func-s3api http://logs.openstack.org/96/660196/1/gate/swift-tox-func-s3api/4267e8a/ : SUCCESS in 11m 41s\n- swift-probetests-centos-7 http://logs.openstack.org/96/660196/1/gate/swift-probetests-centos-7/f77c465/ : SUCCESS in 30m 59s\n- swift-dsvm-functional http://logs.openstack.org/96/660196/1/gate/swift-dsvm-functional/69da61e/ : SUCCESS in 29m 23s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/96/660196/1/gate/swift-dsvm-functional-ipv6/f022495/ : SUCCESS in 26m 04s\n- swift-tox-lower-constraints http://logs.openstack.org/96/660196/1/gate/swift-tox-lower-constraints/8ec591e/ : SUCCESS in 23m 51s\n- openstack-tox-pep8 http://logs.openstack.org/96/660196/1/gate/openstack-tox-pep8/0896e24/ : SUCCESS in 5m 34s","accounts_in_message":[],"_revision_number":1},{"id":"9c0585de618ffa13c2e76e35f9e3f0922927af84","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-06 01:16:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fd0ed497c2d18bb26f3036e76aa7f3ace760e49c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-06 01:17:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- swift-promote-image http://logs.openstack.org/96/660196/1/promote/swift-promote-image/622dfff/ : SUCCESS in 39s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"82e446a8a0c0fd6a81f06717b76ed3d1be26a281","revisions":{"82e446a8a0c0fd6a81f06717b76ed3d1be26a281":{"kind":"REWORK","_number":1,"created":"2019-05-20 18:44:48.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/96/660196/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/96/660196/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/660196/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/660196/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/96/660196/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/96/660196/1"}}},"commit":{"parents":[{"commit":"f17b9d2e24b22c29dcf09265d7c59d2550262385","subject":"Merge \"Be explicit that a code path is just for py2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f17b9d2e24b22c29dcf09265d7c59d2550262385"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-05-20 18:44:21.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-05-20 18:44:21.000000000","tz":-420},"subject":"s3api: Allow clients to upload with UNSIGNED-PAYLOAD","message":"s3api: Allow clients to upload with UNSIGNED-PAYLOAD\n\n(Some versions of?) awscli/boto3 will do v4 signatures but send a\nContent-MD5 for end-to-end validation. Since a X-Amz-Content-SHA256\nis still required to calculate signatures, it uses UNSIGNED-PAYLOAD\nsimilar to how signatures work for pre-signed URLs.\n\nLook for UNSIGNED-PAYLOAD and skip SHA256 validation if set.\n\nChange-Id: I571c16c196dae4e4f8fb41904c8850d0054b1fe9\nRelated-Change: I61eb12455c37376be4d739eee55a5f439216f0e9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/82e446a8a0c0fd6a81f06717b76ed3d1be26a281"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/82e446a8a0c0fd6a81f06717b76ed3d1be26a281"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}