)]}'
{"swift/obj/vfile_utils.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"31a275f3fb368b2f14cae0e7d3452700f21987ff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return ext_map.get(extension, VOLUME_DEFAULT)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def valid_volume_name(name):"},{"line_number":44,"context_line":"    \"\"\"Returns True if name is a valid volume name, False otherwise\"\"\""},{"line_number":45,"context_line":"    if volume_name_re.match(name):"},{"line_number":46,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_65761873","line":43,"updated":"2019-06-13 11:51:44.000000000","message":"This could just raise ValueError rather than False, but because it does not return anything, I think it would look strange in the caller ?\nYou would have a single \"valid_volume_name(name)\" line\n(something like an assert).\nI can change it.","commit_id":"78be6fe7f3aa92a0d544191d6dded329097a77d3"}],"test/unit/obj/test_vfile_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f376608b777f08b25df61587bb20c78df9eceaad","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        volume_path \u003d \"/sdc1/losf-2/volumes/v0000234\""},{"line_number":37,"context_line":"        expected \u003d \"/sdc1/losf-2/rpc.socket\""},{"line_number":38,"context_line":"        socket_path \u003d vfile_utils.get_socket_path_from_volume_path(volume_path)"},{"line_number":39,"context_line":"        self.assertEqual(expected, socket_path)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_get_mountpoint_from_volume_path(self):"},{"line_number":42,"context_line":"        volume_path \u003d \"/srv/node/sdb1/losf/volumes/v0000001\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_be23fbbc","line":39,"updated":"2019-06-10 19:31:37.000000000","message":"Might could use some error cases, but that could be in a follow-up. For example, should any of these raise errors? If not, what\u0027s the expected socket path?\n\n /srv/node/sdb1/losf/volumes/not-a-volume\n /volumes/v0000001\n /srv/node/sdb1/losf-notAnInt/volumes/v0000001\n /srv/node/sdb1/losf/not-volumes/v0000001","commit_id":"025084f63b6f389931bd52aab54acf007bea362d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f376608b777f08b25df61587bb20c78df9eceaad","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        volume_path \u003d \"/sdb1/losf-2/volumes/v0000234\""},{"line_number":48,"context_line":"        expected \u003d \"/sdb1\""},{"line_number":49,"context_line":"        mountpoint \u003d vfile_utils.get_mountpoint_from_volume_path(volume_path)"},{"line_number":50,"context_line":"        self.assertEqual(expected, mountpoint)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_get_volume_index(self):"},{"line_number":53,"context_line":"        v_index \u003d vfile_utils.get_volume_index(\"v0000001\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7e290399","line":50,"updated":"2019-06-10 19:31:37.000000000","message":"Similar feedback as above.","commit_id":"025084f63b6f389931bd52aab54acf007bea362d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f376608b777f08b25df61587bb20c78df9eceaad","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":60,"context_line":"            v_index \u003d vfile_utils.get_volume_index(\"v1\")"},{"line_number":61,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":62,"context_line":"            v_index \u003d vfile_utils.get_volume_index(\"v12345678\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_next_aligned_offset(self):"},{"line_number":65,"context_line":"        test_data \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7e02630d","line":62,"updated":"2019-06-10 19:31:37.000000000","message":"Should it always start with \"v\"? What\u0027s expected if you hand it\n\n x0000001\n\nor\n\n 12345678\n\n?","commit_id":"025084f63b6f389931bd52aab54acf007bea362d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ea2b692af5ef7d6a8c14789201e8f49b400e11d0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertEqual(expected, mountpoint)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        volume_path \u003d \"/losf-99/volumes/v0000001\""},{"line_number":74,"context_line":"        expected \u003d \"/\""},{"line_number":75,"context_line":"        socket_path \u003d vfile_utils.get_mountpoint_from_volume_path(volume_path)"},{"line_number":76,"context_line":"        self.assertEqual(expected, socket_path)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_0ddde7de","line":74,"updated":"2019-06-14 16:03:35.000000000","message":"O_o","commit_id":"78be6fe7f3aa92a0d544191d6dded329097a77d3"}]}