)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"1aabc2025690fbb184df2ef015e4a9dae5012a74","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        found_invalidation_entry \u003d False"},{"line_number":400,"context_line":"        try:"},{"line_number":401,"context_line":"            with open(invalidations_file, \u0027r\u0027) as inv_fh:"},{"line_number":402,"context_line":"                for line in inv_fh:"},{"line_number":403,"context_line":"                    found_invalidation_entry \u003d True"},{"line_number":404,"context_line":"                    suffix \u003d line.strip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_bfaf887b","side":"PARENT","line":401,"updated":"2019-05-24 14:05:32.000000000","message":"We were already opening the file as a text file here","commit_id":"657b022689ebe252a67e2ae46d233df79d6c0bdd"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"161d63c2b0d9bff27f4f323f3d826d5d9afcbc30","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        found_invalidation_entry \u003d False"},{"line_number":400,"context_line":"        try:"},{"line_number":401,"context_line":"            with open(invalidations_file, \u0027r\u0027) as inv_fh:"},{"line_number":402,"context_line":"                for line in inv_fh:"},{"line_number":403,"context_line":"                    found_invalidation_entry \u003d True"},{"line_number":404,"context_line":"                    suffix \u003d line.strip()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_b37c9f1f","line":401,"range":{"start_line":401,"start_character":43,"end_line":401,"end_character":44},"updated":"2019-05-24 17:26:30.000000000","message":"But when we *read* the invalidations file, it now comes out as native strings, no? I wonder if this may have been fixed by https://review.opendev.org/#/c/659390/3/swift/obj/diskfile.py@401","commit_id":"d889758bd8f4788c50db417fc4ad69c8b47137bb"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"1aabc2025690fbb184df2ef015e4a9dae5012a74","unresolved":false,"context_lines":[{"line_number":6852,"context_line":"                found_hashes \u003d pickle.load(f)"},{"line_number":6853,"context_line":"                self.assertTrue(hashes[\u0027valid\u0027])"},{"line_number":6854,"context_line":"                self.assertEqual(hashes, found_hashes)"},{"line_number":6855,"context_line":"            with open(invalidations_file, \u0027r\u0027) as f:"},{"line_number":6856,"context_line":"                self.assertEqual(\"\", f.read())"},{"line_number":6857,"context_line":"            return hashes"},{"line_number":6858,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_1f96d440","side":"PARENT","line":6855,"updated":"2019-05-24 14:05:32.000000000","message":"Changing this to \u0027rb\u0027 shows the problem with py3","commit_id":"657b022689ebe252a67e2ae46d233df79d6c0bdd"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"161d63c2b0d9bff27f4f323f3d826d5d9afcbc30","unresolved":false,"context_lines":[{"line_number":6852,"context_line":"                found_hashes \u003d pickle.load(f)"},{"line_number":6853,"context_line":"                self.assertTrue(hashes[\u0027valid\u0027])"},{"line_number":6854,"context_line":"                self.assertEqual(hashes, found_hashes)"},{"line_number":6855,"context_line":"            with open(invalidations_file, \u0027r\u0027) as f:"},{"line_number":6856,"context_line":"                self.assertEqual(\"\", f.read())"},{"line_number":6857,"context_line":"            return hashes"},{"line_number":6858,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_f39bf762","side":"PARENT","line":6855,"in_reply_to":"bfb3d3c7_1f96d440","updated":"2019-05-24 17:26:30.000000000","message":"...which definitely had to change: https://review.opendev.org/#/c/659390/3/test/unit/obj/test_diskfile.py@6855","commit_id":"657b022689ebe252a67e2ae46d233df79d6c0bdd"}]}