)]}'
{"id":"openstack%2Fswift~665488","triplet_id":"openstack%2Fswift~master~I5f3bc6416207cab2c7e3a77ee6689360b55990e7","project":"openstack/swift","branch":"master","topic":"exception-flow-control","hashtags":[],"change_id":"I5f3bc6416207cab2c7e3a77ee6689360b55990e7","subject":"Move calls to self.app outside of error handling","status":"MERGED","created":"2019-06-14 22:47:24.000000000","updated":"2019-07-12 22:13:44.000000000","submitted":"2019-07-12 22:12:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665488-1562969548913-3de93a84","meta_rev_id":"defab8ab7663e80e6ff9b65907b76f4a1ed3ff92","_number":665488,"virtual_id_number":665488,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2019-07-12 22:12:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":2,"date":"2019-07-12 20:44:45.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":1,"date":"2019-07-12 20:44:45.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-12 20:44:45.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2019-07-12 22:12:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bab39589d61e9ec80962f4e24f32ce1d781b6195","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-06-14 22:47:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6918720fcec41a7a55181c225385c7776aa8db2f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-15 06:25:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/88/665488/1/check/openstack-tox-docs/4abcd71/html/ : SUCCESS in 4m 14s\n- swift-build-image http://logs.openstack.org/88/665488/1/check/swift-build-image/bfde6a7/ : SUCCESS in 8m 48s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/88/665488/1/check/swift-tox-py27/1a0f415/ : SUCCESS in 11m 36s\n- swift-tox-py36 http://logs.openstack.org/88/665488/1/check/swift-tox-py36/45f078f/ : SUCCESS in 11m 22s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/88/665488/1/check/swift-tox-py37/cb7444b/ : SUCCESS in 11m 12s\n- swift-tox-func http://logs.openstack.org/88/665488/1/check/swift-tox-func/bc34fe0/ : SUCCESS in 10m 29s\n- swift-tox-func-py37 http://logs.openstack.org/88/665488/1/check/swift-tox-func-py37/b516b89/ : SUCCESS in 10m 46s\n- swift-tox-func-encryption http://logs.openstack.org/88/665488/1/check/swift-tox-func-encryption/8fd46b4/ : SUCCESS in 11m 06s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/88/665488/1/check/swift-tox-func-domain-remap-staticweb/e5d986a/ : SUCCESS in 20m 13s\n- swift-tox-func-ec http://logs.openstack.org/88/665488/1/check/swift-tox-func-ec/29edc1d/ : SUCCESS in 12m 07s\n- swift-tox-func-s3api http://logs.openstack.org/88/665488/1/check/swift-tox-func-s3api/25a7e63/ : SUCCESS in 12m 18s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/88/665488/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/8b28a12/ : SUCCESS in 13m 21s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/88/665488/1/check/swift-probetests-centos-7/5675ff5/ : SUCCESS in 31m 54s\n- swift-dsvm-functional http://logs.openstack.org/88/665488/1/check/swift-dsvm-functional/0731c43/ : SUCCESS in 30m 07s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/88/665488/1/check/swift-dsvm-functional-ipv6/a3fecc4/ : SUCCESS in 31m 00s\n- swift-tox-lower-constraints http://logs.openstack.org/88/665488/1/check/swift-tox-lower-constraints/70468fc/ : SUCCESS in 11m 03s\n- openstack-tox-pep8 http://logs.openstack.org/88/665488/1/check/openstack-tox-pep8/fed86a2/ : SUCCESS in 5m 08s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/88/665488/1/check/swift-multinode-rolling-upgrade/3148917/ : FAILURE in 7m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ce23e0457c3eac7701f27d1d6ae08eb9bc6f0527","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-06-17 20:44:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"091866ae235d0db31d84a14b0eb884b5e83797fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 01:02:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/88/665488/2/check/openstack-tox-docs/734d4d6/html/ : SUCCESS in 4m 33s\n- swift-build-image http://logs.openstack.org/88/665488/2/check/swift-build-image/85401c2/ : SUCCESS in 8m 10s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/88/665488/2/check/swift-tox-py27/1857d44/ : SUCCESS in 11m 33s\n- swift-tox-py36 http://logs.openstack.org/88/665488/2/check/swift-tox-py36/5b2d84a/ : SUCCESS in 10m 29s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/88/665488/2/check/swift-tox-py37/cf25baf/ : SUCCESS in 11m 32s\n- swift-tox-func http://logs.openstack.org/88/665488/2/check/swift-tox-func/1bd550b/ : SUCCESS in 11m 34s\n- swift-tox-func-py37 http://logs.openstack.org/88/665488/2/check/swift-tox-func-py37/f0d4b9b/ : SUCCESS in 13m 36s\n- swift-tox-func-encryption http://logs.openstack.org/88/665488/2/check/swift-tox-func-encryption/cf7f316/ : SUCCESS in 9m 23s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/88/665488/2/check/swift-tox-func-domain-remap-staticweb/9f632db/ : SUCCESS in 22m 09s\n- swift-tox-func-ec http://logs.openstack.org/88/665488/2/check/swift-tox-func-ec/9b296c6/ : SUCCESS in 9m 24s\n- swift-tox-func-s3api http://logs.openstack.org/88/665488/2/check/swift-tox-func-s3api/8a13a17/ : SUCCESS in 11m 30s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/88/665488/2/check/swift-tox-func-s3api-ceph-s3tests-tempauth/3023e2b/ : SUCCESS in 20m 37s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/88/665488/2/check/swift-probetests-centos-7/50c5e4d/ : SUCCESS in 32m 25s\n- swift-dsvm-functional http://logs.openstack.org/88/665488/2/check/swift-dsvm-functional/26a14b8/ : SUCCESS in 27m 49s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/88/665488/2/check/swift-dsvm-functional-ipv6/7e572a4/ : SUCCESS in 26m 44s\n- swift-tox-lower-constraints http://logs.openstack.org/88/665488/2/check/swift-tox-lower-constraints/fe7a62b/ : SUCCESS in 11m 39s\n- openstack-tox-pep8 http://logs.openstack.org/88/665488/2/check/openstack-tox-pep8/bc065d1/ : SUCCESS in 5m 40s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/88/665488/2/check/swift-multinode-rolling-upgrade/31e0333/ : FAILURE in 10m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"48158bb563996ec13c4bf027589df3ff8d41ae62","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-07-12 20:44:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"51667d27244e258533963b380e40dde49d3a0973","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 20:45:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0e6000bbd5f51f981a7cd152a891db178f93ff27","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 22:12:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/88/665488/2/gate/openstack-tox-docs/c4993f4/html/ : SUCCESS in 4m 14s\n- swift-upload-image http://logs.openstack.org/88/665488/2/gate/swift-upload-image/dab6e29/ : SUCCESS in 8m 47s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/88/665488/2/gate/swift-tox-py27/c106a9a/ : SUCCESS in 9m 47s\n- swift-tox-py37 http://logs.openstack.org/88/665488/2/gate/swift-tox-py37/ee8a31e/ : SUCCESS in 12m 33s\n- swift-tox-func http://logs.openstack.org/88/665488/2/gate/swift-tox-func/e924d36/ : SUCCESS in 8m 57s\n- swift-tox-func-py37 http://logs.openstack.org/88/665488/2/gate/swift-tox-func-py37/16f48f2/ : SUCCESS in 9m 05s\n- swift-tox-func-encryption http://logs.openstack.org/88/665488/2/gate/swift-tox-func-encryption/d0b712c/ : SUCCESS in 8m 17s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/88/665488/2/gate/swift-tox-func-domain-remap-staticweb/4b2cfb0/ : SUCCESS in 8m 46s\n- swift-tox-func-ec http://logs.openstack.org/88/665488/2/gate/swift-tox-func-ec/4e2dcb1/ : SUCCESS in 9m 45s\n- swift-tox-func-s3api http://logs.openstack.org/88/665488/2/gate/swift-tox-func-s3api/dec1bc9/ : SUCCESS in 13m 10s\n- swift-tox-func-domain-remap-staticweb-py37 http://logs.openstack.org/88/665488/2/gate/swift-tox-func-domain-remap-staticweb-py37/8681ca5/ : SUCCESS in 7m 33s\n- swift-probetests-centos-7 http://logs.openstack.org/88/665488/2/gate/swift-probetests-centos-7/4d5e62a/ : SUCCESS in 30m 53s\n- swift-dsvm-functional http://logs.openstack.org/88/665488/2/gate/swift-dsvm-functional/537d62f/ : SUCCESS in 27m 37s\n- swift-dsvm-functional-py3 http://logs.openstack.org/88/665488/2/gate/swift-dsvm-functional-py3/61e581e/ : SUCCESS in 28m 02s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/88/665488/2/gate/swift-dsvm-functional-ipv6/f9df369/ : SUCCESS in 27m 03s\n- swift-tox-lower-constraints http://logs.openstack.org/88/665488/2/gate/swift-tox-lower-constraints/b9d39d9/ : SUCCESS in 12m 38s\n- openstack-tox-pep8 http://logs.openstack.org/88/665488/2/gate/openstack-tox-pep8/675f705/ : SUCCESS in 6m 10s","accounts_in_message":[],"_revision_number":2},{"id":"a1365fea5ebf7f63182ff06ea37fe4e29ec9bc16","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 22:12:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"4160f2909d92dd8dff589f6e0b64e8730c66a835","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 22:13:44.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- swift-promote-image http://logs.openstack.org/88/665488/2/promote/swift-promote-image/c9f5c91/ : SUCCESS in 55s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"557335465561b7a00d08cc5a370d5fcd6e7d83b0","revisions":{"0b45140a33a67733c23ff08810405ba449d38d3d":{"kind":"REWORK","_number":1,"created":"2019-06-14 22:47:24.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/88/665488/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/665488/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/665488/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/665488/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/665488/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/665488/1"}}},"commit":{"parents":[{"commit":"74e1f2e05339880b724161241f3acbb6af6ea769","subject":"Merge \"Update mailmap for Kota Tsuyuzaki\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/74e1f2e05339880b724161241f3acbb6af6ea769"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-06-01 17:46:54.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-06-14 22:47:09.000000000","tz":-420},"subject":"Move calls to self.app outside of error handling","message":"Move calls to self.app outside of error handling\n\nOn py3, if/when you hit an error, you can get very noisy tracebacks like\n\n  \u003ctraceback coming out of split_path()\u003e\n\n  During handling of the above exception, another exception occurred:\n\n  \u003cmeaningful traceback\u003e\n\nIn general, I like this, but when we\u0027ve used exception handling for\nflow-control, it gets difficult to separate the wheat from the chaff.\n\nChange-Id: I5f3bc6416207cab2c7e3a77ee6689360b55990e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0b45140a33a67733c23ff08810405ba449d38d3d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0b45140a33a67733c23ff08810405ba449d38d3d"}]},"branch":"refs/heads/master"},"557335465561b7a00d08cc5a370d5fcd6e7d83b0":{"kind":"REWORK","_number":2,"created":"2019-06-17 20:44:52.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/88/665488/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/665488/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/665488/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/665488/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/665488/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/665488/2"}}},"commit":{"parents":[{"commit":"74e1f2e05339880b724161241f3acbb6af6ea769","subject":"Merge \"Update mailmap for Kota Tsuyuzaki\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/74e1f2e05339880b724161241f3acbb6af6ea769"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-06-01 17:46:54.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-06-17 20:43:48.000000000","tz":-420},"subject":"Move calls to self.app outside of error handling","message":"Move calls to self.app outside of error handling\n\nOn py3, if/when you hit an error, you can get very noisy tracebacks like\n\n  \u003ctraceback coming out of split_path()\u003e\n\n  During handling of the above exception, another exception occurred:\n\n  \u003cmeaningful traceback\u003e\n\nIn general, I like this, but when we\u0027ve used exception handling for\nflow-control, it gets difficult to separate the wheat from the chaff.\n\nChange-Id: I5f3bc6416207cab2c7e3a77ee6689360b55990e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/557335465561b7a00d08cc5a370d5fcd6e7d83b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/557335465561b7a00d08cc5a370d5fcd6e7d83b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}