)]}'
{"id":"openstack%2Fswift~665984","triplet_id":"openstack%2Fswift~master~Iaa9208fb20545ae9ac990f0e180899108d983123","project":"openstack/swift","branch":"master","topic":"remove_nobarrier","hashtags":[],"change_id":"Iaa9208fb20545ae9ac990f0e180899108d983123","subject":"Remove nobarrier option","status":"MERGED","created":"2019-06-18 13:50:37.000000000","updated":"2019-06-19 03:22:50.000000000","submitted":"2019-06-19 03:21:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665984-1560914489257-fc442d7a","meta_rev_id":"ab5442511ae34298654757e8ba7ee59da8f1814e","_number":665984,"virtual_id_number":665984,"owner":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"date":"2019-06-18 16:26:05.000000000","_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":2,"date":"2019-06-19 03:21:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":2,"date":"2019-06-18 23:48:23.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-18 15:21:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":1,"date":"2019-06-18 23:48:23.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-18 15:21:53.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-06-18 23:48:23.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2019-06-19 03:21:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"167e8b9bd96efa768da38b33dc13068f29af9b21","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-06-18 13:50:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"12cd646c88eaf66eb06a51ced004d9b1c4ad2168","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-06-18 15:21:53.000000000","message":"Patch Set 1: Code-Review+1\n\nDeprecated in https://github.com/torvalds/linux/commit/4cf4573 (so, 4.10), removed in https://github.com/torvalds/linux/commit/1c02d50 (so, 4.19). The deprecation commit says\n\n\u003e We always perform integrity operations now, so these mount options don\u0027t do anything.\n\nDo we know when that started? Just debating about whether it makes sense to include a note about the option for older kernels -- looks like xenial\u0027s on 4.4 and CentOS 7\u0027s on 3.10 (!).","accounts_in_message":[],"_revision_number":1},{"id":"1ac1aae00469d04895800ca6c752893fffeb8303","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-06-18 16:26:05.000000000","message":"Patch Set 1:\n\n@tim: I don\u0027t know when it was deprecated in Ubuntu and RHEL. One of the challenges with RHEL is that even thou the official kernel version is 3.10, they usually backport a lot of patches, so it is possible that this deprecation has been backported to a specific 7.X release.","accounts_in_message":[],"_revision_number":1},{"id":"4238e0bef8b03b2fdacf8a5c2415d95db3338504","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-06-18 23:48:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nBest part is, the option was only intended for testing of simulations to begin with. But every production Swift cluster used it. Way to go.","accounts_in_message":[],"_revision_number":1},{"id":"b5dd356c62094e10d95a045f70ffd11eb5ec791f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 00:52:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/84/665984/1/check/openstack-tox-docs/1199fef/html/ : SUCCESS in 4m 22s\n- swift-build-image http://logs.openstack.org/84/665984/1/check/swift-build-image/6d425cb/ : SUCCESS in 7m 31s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/84/665984/1/check/swift-tox-py27/0bd23bb/ : SUCCESS in 11m 32s\n- swift-tox-py36 http://logs.openstack.org/84/665984/1/check/swift-tox-py36/827dd7f/ : SUCCESS in 11m 02s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/84/665984/1/check/swift-tox-py37/39ddabd/ : SUCCESS in 17m 09s\n- swift-tox-func http://logs.openstack.org/84/665984/1/check/swift-tox-func/67ae61d/ : SUCCESS in 9m 14s\n- swift-tox-func-py37 http://logs.openstack.org/84/665984/1/check/swift-tox-func-py37/34e4704/ : SUCCESS in 8m 45s\n- swift-tox-func-encryption http://logs.openstack.org/84/665984/1/check/swift-tox-func-encryption/5e79772/ : SUCCESS in 10m 39s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/84/665984/1/check/swift-tox-func-domain-remap-staticweb/c9f1bf7/ : SUCCESS in 12m 04s\n- swift-tox-func-ec http://logs.openstack.org/84/665984/1/check/swift-tox-func-ec/cfd6d37/ : SUCCESS in 13m 16s\n- swift-tox-func-s3api http://logs.openstack.org/84/665984/1/check/swift-tox-func-s3api/1c06f90/ : SUCCESS in 17m 11s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/84/665984/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/a7e8ee5/ : SUCCESS in 13m 53s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/84/665984/1/check/swift-probetests-centos-7/3efd6f6/ : SUCCESS in 33m 52s\n- swift-dsvm-functional http://logs.openstack.org/84/665984/1/check/swift-dsvm-functional/fda8e17/ : SUCCESS in 45m 36s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/84/665984/1/check/swift-dsvm-functional-ipv6/472c997/ : SUCCESS in 44m 44s\n- swift-tox-lower-constraints http://logs.openstack.org/84/665984/1/check/swift-tox-lower-constraints/40959df/ : SUCCESS in 11m 52s\n- openstack-tox-pep8 http://logs.openstack.org/84/665984/1/check/openstack-tox-pep8/de804a0/ : SUCCESS in 5m 53s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/84/665984/1/check/swift-multinode-rolling-upgrade/9376bfd/ : FAILURE in 8m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a3119243a679a39bc2868d9268c5293b64ad1427","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 00:53:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4b29871bc3626c728ff34ab38c01fa03586a963f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 03:21:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/84/665984/1/gate/openstack-tox-docs/3fb9f6f/html/ : SUCCESS in 4m 34s\n- swift-upload-image http://logs.openstack.org/84/665984/1/gate/swift-upload-image/b45f332/ : SUCCESS in 9m 24s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/84/665984/1/gate/swift-tox-py27/f68bc0b/ : SUCCESS in 12m 09s\n- swift-tox-py37 http://logs.openstack.org/84/665984/1/gate/swift-tox-py37/c517f2b/ : SUCCESS in 11m 10s\n- swift-tox-func http://logs.openstack.org/84/665984/1/gate/swift-tox-func/c688e6f/ : SUCCESS in 9m 09s\n- swift-tox-func-py37 http://logs.openstack.org/84/665984/1/gate/swift-tox-func-py37/2e2a929/ : SUCCESS in 9m 25s\n- swift-tox-func-encryption http://logs.openstack.org/84/665984/1/gate/swift-tox-func-encryption/bde9749/ : SUCCESS in 10m 32s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/84/665984/1/gate/swift-tox-func-domain-remap-staticweb/2396ebc/ : SUCCESS in 9m 49s\n- swift-tox-func-ec http://logs.openstack.org/84/665984/1/gate/swift-tox-func-ec/86e85c2/ : SUCCESS in 10m 00s\n- swift-tox-func-s3api http://logs.openstack.org/84/665984/1/gate/swift-tox-func-s3api/cdd3cf4/ : SUCCESS in 13m 02s\n- swift-probetests-centos-7 http://logs.openstack.org/84/665984/1/gate/swift-probetests-centos-7/654d5ef/ : SUCCESS in 30m 42s\n- swift-dsvm-functional http://logs.openstack.org/84/665984/1/gate/swift-dsvm-functional/345bc06/ : SUCCESS in 27m 15s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/84/665984/1/gate/swift-dsvm-functional-ipv6/ea6c995/ : SUCCESS in 30m 45s\n- swift-tox-lower-constraints http://logs.openstack.org/84/665984/1/gate/swift-tox-lower-constraints/3cb1265/ : SUCCESS in 12m 07s\n- openstack-tox-pep8 http://logs.openstack.org/84/665984/1/gate/openstack-tox-pep8/fe5f91d/ : SUCCESS in 6m 18s","accounts_in_message":[],"_revision_number":1},{"id":"7995305574a596e7eebd7388ef2787ec99c42bad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 03:21:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"49b18fe43e9c62cce38ff9344d25babea99c118d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 03:22:50.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- swift-promote-image http://logs.openstack.org/84/665984/1/promote/swift-promote-image/d415f93/ : SUCCESS in 49s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4ab3706b75362b39cebf7ae5f325c191459c2690","revisions":{"4ab3706b75362b39cebf7ae5f325c191459c2690":{"kind":"REWORK","_number":1,"created":"2019-06-18 13:50:37.000000000","uploader":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"ref":"refs/changes/84/665984/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/84/665984/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/84/665984/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/84/665984/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/84/665984/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/84/665984/1"}}},"commit":{"parents":[{"commit":"761a16acbabd29019d020447529c1d248b4b1a86","subject":"Merge \"Fix :param: in docstring\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/761a16acbabd29019d020447529c1d248b4b1a86"}]}],"author":{"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","date":"2019-06-18 13:47:39.000000000","tz":60},"committer":{"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","date":"2019-06-18 13:47:39.000000000","tz":60},"subject":"Remove nobarrier option","message":"Remove nobarrier option\n\nXFS no longer supports nobarrier mount option.\nIt has been deprecated for a long time[1] and removed in\nrecent kernel versions resulting in an error when trying to\nmount: \"kernel: XFS (loop0): unknown mount option [nobarrier].\"\n\n[1] - https://patchwork.kernel.org/patch/9486549/\n\nChange-Id: Iaa9208fb20545ae9ac990f0e180899108d983123\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ab3706b75362b39cebf7ae5f325c191459c2690"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ab3706b75362b39cebf7ae5f325c191459c2690"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}