)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b287ca721b9e7cb88ebf8e6c4100ce901b2ab974","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \u0027status\u0027: status_int,"},{"line_number":179,"context_line":"        \u0027read_acl\u0027: headers.get(\u0027x-container-read\u0027),"},{"line_number":180,"context_line":"        \u0027write_acl\u0027: headers.get(\u0027x-container-write\u0027),"},{"line_number":181,"context_line":"        \u0027sync_key\u0027: headers.get(\u0027x-container-sync-key\u0027),"},{"line_number":182,"context_line":"        \u0027last_modified\u0027: headers.get(\u0027last-modified\u0027),"},{"line_number":183,"context_line":"        \u0027object_count\u0027: headers.get(\u0027x-container-object-count\u0027),"},{"line_number":184,"context_line":"        \u0027bytes\u0027: headers.get(\u0027x-container-bytes-used\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_fcdd9f6f","line":181,"range":{"start_line":181,"start_character":33,"end_line":181,"end_character":53},"updated":"2019-07-01 22:32:56.000000000","message":"I think we\u0027re also going to need to record x-container-sync-to -- time to revive https://review.opendev.org/#/c/311760/?","commit_id":"302a001f6facb4ea1e795b84be9d1db3ae9e1dc4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b287ca721b9e7cb88ebf8e6c4100ce901b2ab974","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \u0027read_acl\u0027: headers.get(\u0027x-container-read\u0027),"},{"line_number":180,"context_line":"        \u0027write_acl\u0027: headers.get(\u0027x-container-write\u0027),"},{"line_number":181,"context_line":"        \u0027sync_key\u0027: headers.get(\u0027x-container-sync-key\u0027),"},{"line_number":182,"context_line":"        \u0027last_modified\u0027: headers.get(\u0027last-modified\u0027),"},{"line_number":183,"context_line":"        \u0027object_count\u0027: headers.get(\u0027x-container-object-count\u0027),"},{"line_number":184,"context_line":"        \u0027bytes\u0027: headers.get(\u0027x-container-bytes-used\u0027),"},{"line_number":185,"context_line":"        \u0027versions\u0027: headers.get(\u0027x-versions-location\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_218554ad","line":182,"updated":"2019-07-01 22:32:56.000000000","message":"The unit test changes had to do with this change, which affected our expectations in tests.","commit_id":"302a001f6facb4ea1e795b84be9d1db3ae9e1dc4"}],"swift/proxy/controllers/container.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b287ca721b9e7cb88ebf8e6c4100ce901b2ab974","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            return HTTPNotFound(request\u003dreq)"},{"line_number":280,"context_line":"        elif is_success(info[\u0027status\u0027]):"},{"line_number":281,"context_line":"            headers \u003d HeaderKeyDict({"},{"line_number":282,"context_line":"                \u0027last-modified\u0027: info.get(\u0027last_modified\u0027),"},{"line_number":283,"context_line":"                \u0027x-container-read\u0027: info[\u0027read_acl\u0027],"},{"line_number":284,"context_line":"                \u0027x-container-write\u0027: info[\u0027write_acl\u0027],"},{"line_number":285,"context_line":"                \u0027x-container-sync-key\u0027: info[\u0027sync_key\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_81bf605f","line":282,"range":{"start_line":282,"start_character":38,"end_line":282,"end_character":41},"updated":"2019-07-01 22:32:56.000000000","message":"Has to be .get(); pre-upgrade cache entries won\u0027t have this.","commit_id":"302a001f6facb4ea1e795b84be9d1db3ae9e1dc4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b287ca721b9e7cb88ebf8e6c4100ce901b2ab974","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                for key in self.app.swift_owner_headers:"},{"line_number":301,"context_line":"                    if key in headers:"},{"line_number":302,"context_line":"                        del headers[key]"},{"line_number":303,"context_line":"            headers \u003d {h: str(v) for h, v in headers.items() if v is not None}"},{"line_number":304,"context_line":"            return HTTPNoContent(request\u003dreq, headers\u003dheaders)"},{"line_number":305,"context_line":"        # Else, we did the request -- at least translate the status"},{"line_number":306,"context_line":"        return Response(request\u003dreq, status\u003dinfo[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_61b82c74","line":303,"range":{"start_line":303,"start_character":64,"end_line":303,"end_character":77},"updated":"2019-07-01 22:32:56.000000000","message":"... in which case, neither will the response served from cache.","commit_id":"302a001f6facb4ea1e795b84be9d1db3ae9e1dc4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b287ca721b9e7cb88ebf8e6c4100ce901b2ab974","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            headers \u003d {h: str(v) for h, v in headers.items() if v is not None}"},{"line_number":304,"context_line":"            return HTTPNoContent(request\u003dreq, headers\u003dheaders)"},{"line_number":305,"context_line":"        # Else, we did the request -- at least translate the status"},{"line_number":306,"context_line":"        return Response(request\u003dreq, status\u003dinfo[\u0027status\u0027])"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @public"},{"line_number":309,"context_line":"    @cors_validation"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_a11e246d","line":306,"updated":"2019-07-01 22:32:56.000000000","message":"I\u0027m still not sure I like this fallback, though. Seems likely to lose information -- such as we\u0027d need for https://github.com/openstack/swift/blob/2.21.0/test/unit/proxy/test_server.py#L8009 :-(","commit_id":"302a001f6facb4ea1e795b84be9d1db3ae9e1dc4"}],"test/unit/proxy/controllers/test_container.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"225835e9a7f5685a19f0ff679e8f78a747578019","unresolved":false,"context_lines":[{"line_number":545,"context_line":"                          \u0027X-Container-Bytes-Used\u0027: size_all_objects - 1,"},{"line_number":546,"context_line":"                          \u0027X-Container-Meta-Flavour\u0027: \u0027peach\u0027,"},{"line_number":547,"context_line":"                          \u0027X-Backend-Storage-Policy-Index\u0027: 0,"},{"line_number":548,"context_line":"                          \u0027Last-Modified\u0027: \u0027some date\u0027}"},{"line_number":549,"context_line":"        root_shard_resp_hdrs \u003d dict(root_resp_hdrs)"},{"line_number":550,"context_line":"        root_shard_resp_hdrs[\u0027X-Backend-Record-Type\u0027] \u003d \u0027shard\u0027"},{"line_number":551,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_16b09442","line":548,"updated":"2019-07-01 20:19:14.000000000","message":"Since it defaults to off I don\u0027t think I really understand what changed here...","commit_id":"302a001f6facb4ea1e795b84be9d1db3ae9e1dc4"}]}