)]}'
{"id":"openstack%2Fswift~668963","triplet_id":"openstack%2Fswift~master~I32f51f42d76db38271442a261600089404a00f91","project":"openstack/swift","branch":"master","topic":"bug/1835260","hashtags":[],"change_id":"I32f51f42d76db38271442a261600089404a00f91","subject":"container-replicator: Add a timeout for get_shard_ranges","status":"MERGED","created":"2019-07-03 17:40:26.000000000","updated":"2019-07-08 22:21:45.000000000","submitted":"2019-07-08 22:20:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668963-1562624424976-10db0568","meta_rev_id":"2bce5a41213b9c3dd357a96dbe205c2546669061","_number":668963,"virtual_id_number":668963,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2019-07-08 22:20:24.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2019-07-08 19:55:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2019-07-08 19:55:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-08 19:55:55.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-07-08 22:20:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"59259116dc5b03223c1561eec91c7d89b7bdc5b9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-07-03 17:40:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"62886c8ff6cb3a1e60f878e7c43ff583a1381ab2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 20:02:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/63/668963/1/check/openstack-tox-docs/8f8d606/html/ : SUCCESS in 4m 16s\n- swift-build-image http://logs.openstack.org/63/668963/1/check/swift-build-image/85f7b2b/ : SUCCESS in 9m 22s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/63/668963/1/check/swift-tox-py27/bee5ad1/ : SUCCESS in 10m 38s\n- swift-tox-py36 http://logs.openstack.org/63/668963/1/check/swift-tox-py36/f225d17/ : SUCCESS in 10m 36s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/63/668963/1/check/swift-tox-py37/df58412/ : SUCCESS in 10m 54s\n- swift-tox-func http://logs.openstack.org/63/668963/1/check/swift-tox-func/889fa5f/ : SUCCESS in 10m 30s\n- swift-tox-func-py37 http://logs.openstack.org/63/668963/1/check/swift-tox-func-py37/98136cb/ : SUCCESS in 13m 58s\n- swift-tox-func-encryption http://logs.openstack.org/63/668963/1/check/swift-tox-func-encryption/f55875e/ : SUCCESS in 9m 50s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/63/668963/1/check/swift-tox-func-domain-remap-staticweb/34d7bdb/ : SUCCESS in 8m 48s\n- swift-tox-func-ec http://logs.openstack.org/63/668963/1/check/swift-tox-func-ec/c13e526/ : SUCCESS in 9m 36s\n- swift-tox-func-s3api http://logs.openstack.org/63/668963/1/check/swift-tox-func-s3api/5c0178a/ : SUCCESS in 12m 00s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/63/668963/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/7f55c01/ : SUCCESS in 13m 59s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/63/668963/1/check/swift-probetests-centos-7/6691ad3/ : SUCCESS in 29m 51s\n- swift-dsvm-functional http://logs.openstack.org/63/668963/1/check/swift-dsvm-functional/e317b8d/ : SUCCESS in 31m 59s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/63/668963/1/check/swift-dsvm-functional-ipv6/1e515d3/ : SUCCESS in 34m 14s\n- swift-tox-lower-constraints http://logs.openstack.org/63/668963/1/check/swift-tox-lower-constraints/3a15871/ : SUCCESS in 11m 00s\n- openstack-tox-pep8 http://logs.openstack.org/63/668963/1/check/openstack-tox-pep8/db12c3d/ : FAILURE in 5m 14s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/63/668963/1/check/swift-multinode-rolling-upgrade/7dfed12/ : FAILURE in 7m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8a6634d97373566dd42aa0341b8f17f85bd20ce2","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-07-03 20:27:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(5 comments)\n\nit\u0027ll be nice to get this fixed, might be a few other things to cleanup when you\u0027re making pep8 happy","accounts_in_message":[],"_revision_number":1},{"id":"5d7449b64d642c24bbce3085f95edf02e21257e8","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-07-04 05:29:20.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nHeh, that\u0027s what I get for mostly writing this on the train.","accounts_in_message":[],"_revision_number":1},{"id":"d35337db330acb6336592ce13143feb3419c6892","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-07-04 05:30:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4a58a07dffdcca421d423d0483186a6557d80d9c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-04 06:09:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/63/668963/2/check/openstack-tox-docs/c94e311/html/ : SUCCESS in 4m 14s\n- swift-build-image http://logs.openstack.org/63/668963/2/check/swift-build-image/89fe6b7/ : SUCCESS in 7m 59s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/63/668963/2/check/swift-tox-py27/e470ebb/ : SUCCESS in 10m 22s\n- swift-tox-py36 http://logs.openstack.org/63/668963/2/check/swift-tox-py36/c911c65/ : SUCCESS in 12m 03s (non-voting)\n- swift-tox-py37 http://logs.openstack.org/63/668963/2/check/swift-tox-py37/f836d8d/ : SUCCESS in 11m 08s\n- swift-tox-func http://logs.openstack.org/63/668963/2/check/swift-tox-func/6f9740c/ : SUCCESS in 9m 31s\n- swift-tox-func-py37 http://logs.openstack.org/63/668963/2/check/swift-tox-func-py37/14b41f9/ : SUCCESS in 10m 03s\n- swift-tox-func-encryption http://logs.openstack.org/63/668963/2/check/swift-tox-func-encryption/1a84e0b/ : SUCCESS in 9m 30s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/63/668963/2/check/swift-tox-func-domain-remap-staticweb/e0c6a09/ : SUCCESS in 9m 28s\n- swift-tox-func-ec http://logs.openstack.org/63/668963/2/check/swift-tox-func-ec/a1e8fff/ : SUCCESS in 9m 43s\n- swift-tox-func-s3api http://logs.openstack.org/63/668963/2/check/swift-tox-func-s3api/495d1d0/ : SUCCESS in 13m 17s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/63/668963/2/check/swift-tox-func-s3api-ceph-s3tests-tempauth/bcdca5a/ : SUCCESS in 14m 23s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/63/668963/2/check/swift-probetests-centos-7/62e1dc3/ : SUCCESS in 37m 53s\n- swift-dsvm-functional http://logs.openstack.org/63/668963/2/check/swift-dsvm-functional/502e300/ : SUCCESS in 27m 17s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/63/668963/2/check/swift-dsvm-functional-ipv6/ddd2f2e/ : SUCCESS in 25m 15s\n- swift-tox-lower-constraints http://logs.openstack.org/63/668963/2/check/swift-tox-lower-constraints/e3548e6/ : SUCCESS in 11m 15s\n- openstack-tox-pep8 http://logs.openstack.org/63/668963/2/check/openstack-tox-pep8/228410b/ : SUCCESS in 6m 55s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/63/668963/2/check/swift-multinode-rolling-upgrade/c1cb18f/ : FAILURE in 9m 06s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"234676ba9d82fc608a38f8af19fc14d8b766b1e5","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-07-08 19:55:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\nSo I think my original concern with the test was that if some regression made get_shard_ranges rpc to raise an exception this test wouldn\u0027t be able to tell the difference between that and a timeout.\n\nBut I couldn\u0027t find a reasonable way to make get_shard_ranges explode that wasn\u0027t covered by some other test.\n\nSlowness in the gate could potentially cause the small 0.001 timeout to pop before the sleep(0.1) fires - but I guess that\u0027s testing the timeout regardless of the race so it\u0027s unlikely to cause a false failure.\n\n:shipit:","accounts_in_message":[],"_revision_number":2},{"id":"aede4daf8a2a4ef1742aaa9eeafd7a78b7aa5d17","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 19:56:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e039610b99abe10c172d07009da0434eec4113e1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 22:20:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"92188b7c77a150d8da1921280f1d93c61404c8d0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 22:20:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/63/668963/2/gate/openstack-tox-docs/0d1082b/html/ : SUCCESS in 4m 48s\n- swift-upload-image http://logs.openstack.org/63/668963/2/gate/swift-upload-image/399f879/ : SUCCESS in 8m 26s (non-voting)\n- swift-tox-py27 http://logs.openstack.org/63/668963/2/gate/swift-tox-py27/c77c3df/ : SUCCESS in 11m 00s\n- swift-tox-py37 http://logs.openstack.org/63/668963/2/gate/swift-tox-py37/5e99c37/ : SUCCESS in 10m 34s\n- swift-tox-func http://logs.openstack.org/63/668963/2/gate/swift-tox-func/f1272dd/ : SUCCESS in 9m 39s\n- swift-tox-func-py37 http://logs.openstack.org/63/668963/2/gate/swift-tox-func-py37/278d962/ : SUCCESS in 13m 02s\n- swift-tox-func-encryption http://logs.openstack.org/63/668963/2/gate/swift-tox-func-encryption/74430a4/ : SUCCESS in 13m 03s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/63/668963/2/gate/swift-tox-func-domain-remap-staticweb/d7e2f9c/ : SUCCESS in 13m 06s\n- swift-tox-func-ec http://logs.openstack.org/63/668963/2/gate/swift-tox-func-ec/67ed129/ : SUCCESS in 13m 56s\n- swift-tox-func-s3api http://logs.openstack.org/63/668963/2/gate/swift-tox-func-s3api/961c006/ : SUCCESS in 19m 44s\n- swift-probetests-centos-7 http://logs.openstack.org/63/668963/2/gate/swift-probetests-centos-7/1c5299d/ : SUCCESS in 30m 50s\n- swift-dsvm-functional http://logs.openstack.org/63/668963/2/gate/swift-dsvm-functional/8828508/ : SUCCESS in 33m 49s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/63/668963/2/gate/swift-dsvm-functional-ipv6/9a78000/ : SUCCESS in 28m 23s\n- swift-tox-lower-constraints http://logs.openstack.org/63/668963/2/gate/swift-tox-lower-constraints/96c54de/ : SUCCESS in 11m 29s\n- openstack-tox-pep8 http://logs.openstack.org/63/668963/2/gate/openstack-tox-pep8/e643975/ : SUCCESS in 6m 15s","accounts_in_message":[],"_revision_number":2},{"id":"972c5874118ef9f325917cf5c7b14817de59aa51","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 22:21:45.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- swift-promote-image http://logs.openstack.org/63/668963/2/promote/swift-promote-image/43f7dd2/ : SUCCESS in 59s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4c4bd778ea8fe8d02a2892524c7918da0ca25ea9","revisions":{"8980666419d9ede13c5fb27def20c6ecf3673c46":{"kind":"REWORK","_number":1,"created":"2019-07-03 17:40:26.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/63/668963/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/63/668963/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/63/668963/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/63/668963/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/63/668963/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/63/668963/1"}}},"commit":{"parents":[{"commit":"dc84c69c652d899bf6b8177fa352cf980ae5ff8a","subject":"Merge \"Add information about secret_cache_duration to sample config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/dc84c69c652d899bf6b8177fa352cf980ae5ff8a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-07-03 16:52:41.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-07-03 17:39:55.000000000","tz":-420},"subject":"container-replicator: Add a timeout for get_shard_ranges","message":"container-replicator: Add a timeout for get_shard_ranges\n\nPreviously this had no timeout, which meant that the replicator might\nhang and fail to make progress indefinitely while trying to receive\nshard ranges.\n\nWhile we\u0027re at it, only call get_shard_ranges when the remote indicates\nthat it has shard ranges for us to sync -- this reduces the number of\nrequests necessary to bring unsharded replicas in sync.\n\nChange-Id: I32f51f42d76db38271442a261600089404a00f91\nCloses-Bug: #1835260\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8980666419d9ede13c5fb27def20c6ecf3673c46"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8980666419d9ede13c5fb27def20c6ecf3673c46"}]},"branch":"refs/heads/master"},"4c4bd778ea8fe8d02a2892524c7918da0ca25ea9":{"kind":"REWORK","_number":2,"created":"2019-07-04 05:30:15.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/63/668963/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/63/668963/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/63/668963/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/63/668963/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/63/668963/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/63/668963/2"}}},"commit":{"parents":[{"commit":"dc84c69c652d899bf6b8177fa352cf980ae5ff8a","subject":"Merge \"Add information about secret_cache_duration to sample config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/dc84c69c652d899bf6b8177fa352cf980ae5ff8a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-07-03 16:52:41.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-07-04 05:29:47.000000000","tz":-420},"subject":"container-replicator: Add a timeout for get_shard_ranges","message":"container-replicator: Add a timeout for get_shard_ranges\n\nPreviously this had no timeout, which meant that the replicator might\nhang and fail to make progress indefinitely while trying to receive\nshard ranges.\n\nWhile we\u0027re at it, only call get_shard_ranges when the remote indicates\nthat it has shard ranges for us to sync -- this reduces the number of\nrequests necessary to bring unsharded replicas in sync.\n\nChange-Id: I32f51f42d76db38271442a261600089404a00f91\nCloses-Bug: #1835260\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4c4bd778ea8fe8d02a2892524c7918da0ca25ea9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4c4bd778ea8fe8d02a2892524c7918da0ca25ea9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}