)]}'
{"swift/common/storage_policy.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"a2ed07e3531c02ab47f33f7801d73fb9e5ee975e","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class StoragePolicySingleton(object):"},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    An instance of this class is global references as the module level global"},{"line_number":164,"context_line":"    POLICIES.   This global references wraps _POLICIES who is normally"},{"line_number":165,"context_line":"    instanticated by parsing swift.conf and will result in an instance of"},{"line_number":166,"context_line":"    StoragePolicyCollection."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FDNg%3D","line":163,"updated":"2014-01-17 22:41:15.000000000","message":"Do you mean to say:\n\n\"An instance of this class serves as the value assigned to the module level \u0027POLICIES\u0027 attribute.  This object wraps _POLICIES, normally instantiated by parsing swift.conf (see below) resulting in an instance of StoragePolicyCollection.\"","commit_id":"48434b7568a183aea77ee344dc1297d4f45426be"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"159830d4b3ea7986438849d06b227bfdbb8ac9b9","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class StoragePolicySingleton(object):"},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    An instance of this class is global references as the module level global"},{"line_number":164,"context_line":"    POLICIES.   This global references wraps _POLICIES who is normally"},{"line_number":165,"context_line":"    instanticated by parsing swift.conf and will result in an instance of"},{"line_number":166,"context_line":"    StoragePolicyCollection."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FCHM%3D","line":163,"in_reply_to":"AAAAUH%2F%2FDNg%3D","updated":"2014-01-18 07:18:48.000000000","message":"darnit, yeah I *wish* I would have said that.  We should have fixed that before everyone rebased.  I\u0027ll pick it up in the Updater patch.  thanks","commit_id":"48434b7568a183aea77ee344dc1297d4f45426be"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"a2ed07e3531c02ab47f33f7801d73fb9e5ee975e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"Expected \u0027%s\u0027, encountered \u0027%s\u0027\" % (exp, headers[:len(exp)])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"def unpatch_policies(f):"},{"line_number":255,"context_line":"    \"\"\""},{"line_number":256,"context_line":"    This will unset a TestCase level patch_policies to use the module level"},{"line_number":257,"context_line":"    policies setup for the _test_servers instead."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FDK8%3D","line":254,"updated":"2014-01-17 22:41:15.000000000","message":"The need for this method seems to highlight the fact that not all the tests in this module rely on the setup() provided environment. That seems to be the cause of the need to \"unpat ch\" many tests. Those marked might be worth placing under a different class, and moving setup/teardown to be class level methods.\n\nOr not. :)","commit_id":"48434b7568a183aea77ee344dc1297d4f45426be"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"159830d4b3ea7986438849d06b227bfdbb8ac9b9","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"Expected \u0027%s\u0027, encountered \u0027%s\u0027\" % (exp, headers[:len(exp)])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"def unpatch_policies(f):"},{"line_number":255,"context_line":"    \"\"\""},{"line_number":256,"context_line":"    This will unset a TestCase level patch_policies to use the module level"},{"line_number":257,"context_line":"    policies setup for the _test_servers instead."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FCHQ%3D","line":254,"in_reply_to":"AAAAUH%2F%2FDK8%3D","updated":"2014-01-18 07:18:48.000000000","message":"That was patch set1 - it was 3400 lines.","commit_id":"48434b7568a183aea77ee344dc1297d4f45426be"}]}