)]}'
{"swift/container/sync.py":[{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"d1668b0346b1509b7e2c47beb378c85a182a3fcd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.http_proxies \u003d ["},{"line_number":137,"context_line":"            a.strip()"},{"line_number":138,"context_line":"            for a in conf.get(\u0027sync_proxy\u0027, \u0027\u0027).split(\u0027,\u0027)"},{"line_number":139,"context_line":"            if a.strip()]"},{"line_number":140,"context_line":"        #: Number of containers with sync turned on that were successfully"},{"line_number":141,"context_line":"        #: synced."},{"line_number":142,"context_line":"        self.container_syncs \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FIG0%3D","line":139,"updated":"2014-01-17 07:06:45.000000000","message":"Do we need to check the url format of proxies and warn or ignore incorrect values before it is used at connection time?","commit_id":"dff3ceed3e9fdd4673d5a019e6cd7132505dec45"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"a68a528bec003674cf2c454d879e5a45fea1b01d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.http_proxies \u003d ["},{"line_number":137,"context_line":"            a.strip()"},{"line_number":138,"context_line":"            for a in conf.get(\u0027sync_proxy\u0027, \u0027\u0027).split(\u0027,\u0027)"},{"line_number":139,"context_line":"            if a.strip()]"},{"line_number":140,"context_line":"        #: Number of containers with sync turned on that were successfully"},{"line_number":141,"context_line":"        #: synced."},{"line_number":142,"context_line":"        self.container_syncs \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bs6Q%3D","line":139,"in_reply_to":"AAAAUH%2F%2FIG0%3D","updated":"2014-01-23 01:24:33.000000000","message":"While a good idea, when I went to implement it I realized that urlparse will successfully parse most any string. Without writing full url parser of our own, we can only really know if a url is bad when we try to use it. I\u0027d rather not write a full url parser for this config value, it\u0027d probably introduce more issues than it would solve.","commit_id":"dff3ceed3e9fdd4673d5a019e6cd7132505dec45"}],"test/unit/container/test_sync.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"05b8084b496ede03a189878c46fe2dc9ac5f6b38","unresolved":false,"context_lines":[{"line_number":928,"context_line":"        cs \u003d sync.ContainerSync("},{"line_number":929,"context_line":"            {\u0027sync_proxy\u0027: \u0027http://one,http://two,http://three\u0027},"},{"line_number":930,"context_line":"            container_ring\u003dFakeRing(),"},{"line_number":931,"context_line":"            object_ring\u003dFakeRing())"},{"line_number":932,"context_line":"        self.assertTrue(cs.select_http_proxy() in ["},{"line_number":933,"context_line":"            \u0027http://one\u0027, \u0027http://two\u0027, \u0027http://three\u0027])"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B%2BF4%3D","line":931,"updated":"2014-01-20 09:16:05.000000000","message":"Maybe add a check here to ensure cs.http_proxies is set correctly? Something like:\n\nself.assertEqual(set(cs.http_proxies), set([\u0027http://one\u0027, \u0027http://two\u0027, \u0027http://three\u0027]))\n\nOtherwise we can\u0027t be sure that cs.http_proxies is really a list with multiple items, because the next check would also pass if there is only item in the list.","commit_id":"dff3ceed3e9fdd4673d5a019e6cd7132505dec45"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"a68a528bec003674cf2c454d879e5a45fea1b01d","unresolved":false,"context_lines":[{"line_number":928,"context_line":"        cs \u003d sync.ContainerSync("},{"line_number":929,"context_line":"            {\u0027sync_proxy\u0027: \u0027http://one,http://two,http://three\u0027},"},{"line_number":930,"context_line":"            container_ring\u003dFakeRing(),"},{"line_number":931,"context_line":"            object_ring\u003dFakeRing())"},{"line_number":932,"context_line":"        self.assertTrue(cs.select_http_proxy() in ["},{"line_number":933,"context_line":"            \u0027http://one\u0027, \u0027http://two\u0027, \u0027http://three\u0027])"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bs6I%3D","line":931,"in_reply_to":"AAAAUH%2F%2B%2BF4%3D","updated":"2014-01-23 01:24:33.000000000","message":"Done","commit_id":"dff3ceed3e9fdd4673d5a019e6cd7132505dec45"}]}