)]}'
{"id":"openstack%2Fswift~677608","triplet_id":"openstack%2Fswift~master~Ie6f46267d4bb567ecc0cc195d1fd7ce55c8cb325","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"Ie6f46267d4bb567ecc0cc195d1fd7ce55c8cb325","subject":"ec: log durability of frags that fail to reconstruct","status":"MERGED","created":"2019-08-21 05:23:32.000000000","updated":"2019-08-21 17:38:29.000000000","submitted":"2019-08-21 17:34:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677608-1566408895242-16970a7d","meta_rev_id":"9dd9cf9bfd66f9ffee742bcff58f71127011d5c9","_number":677608,"virtual_id_number":677608,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2019-08-21 17:34:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-21 15:41:42.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":2,"date":"2019-08-21 12:51:44.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2019-08-21 13:39:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2019-08-21 13:39:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-21 12:51:44.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2019-08-21 13:39:02.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-08-21 17:34:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d46606df65a8e8f4428dbefb408a39dabc561897","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-08-21 05:23:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fb46b6dbefe143ce0a6be7e27215e5b4beccb781","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 06:29:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/17a85a852ffd404190e47048bcf53a62 : SUCCESS in 5m 39s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d4ad1a34664a46b28f0b2ed1f5e71a8a : SUCCESS in 1h 00m 14s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/fa1e09a179a74996a99a435d13991249 : SUCCESS in 56m 53s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b05cc2e4567c43b7b805dd292e42bbf9 : SUCCESS in 10m 17s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/0e20c1e29e1947b89935a2fdbd0ba6a0 : SUCCESS in 11m 14s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/47f8debacc324e828baf4398f3a427b8 : SUCCESS in 11m 13s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/7e3d466724584f46b770dff44e429ba1 : SUCCESS in 11m 09s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/29bf0ae9f8cb427c814c83ca99f93aa0 : SUCCESS in 9m 32s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/9b4ab7bf7b204a66a647a01907cb51b7 : SUCCESS in 9m 49s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/f14184e05cad4190bca5b1b2075c4ca7 : SUCCESS in 9m 52s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/5db82fe545924f6a86e17d8685623961 : SUCCESS in 10m 06s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/fb19136846b64628840840c5f9aeb96c : SUCCESS in 12m 30s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c9e950c896ff4c0c884e20b21a60520b : SUCCESS in 13m 26s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/a81378bc7157465b9e913e5f1dd5e9e9 : SUCCESS in 10m 00s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/e94ff92a31aa4b0aa723822552ee274b : SUCCESS in 9m 59s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/117b91eda58a4580a6a24d17135ec5b4 : SUCCESS in 13m 13s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/5cc7e6b3f39346788956b07132da69f6 : SUCCESS in 13m 19s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/57494c70d8314404a389879b043deab5 : SUCCESS in 16m 48s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/8032bc30ce59437eade0c9a6083cd1b5 : SUCCESS in 34m 16s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f1cade4c7aff41bc881a4689a1ac6db0 : SUCCESS in 34m 13s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/f712682a912b4ecbb258de28c01ba57b : SUCCESS in 28m 58s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/f7eb3952d5ab43c4b774aa2b543006d2 : SUCCESS in 27m 02s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a7c18c4fe21843e49a46e637b5bbcbd7 : SUCCESS in 12m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6b6f7a8bcd1842cda4edfaf7b7d5837c : SUCCESS in 6m 09s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/de7708fe1d9d4bafa5680450e9abea34 : SUCCESS in 18m 39s","accounts_in_message":[],"_revision_number":1},{"id":"defde58053c17377016f7d3ac97853b2569a960c","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-08-21 12:51:44.000000000","message":"Patch Set 1: Code-Review+2\n\nAdmittedly I do not understand a thing about this, but the code seems not adding any performance impact and otherwise harmless.","accounts_in_message":[],"_revision_number":1},{"id":"3d0b42c13c578a53a20126c9cbe73bb4b1029378","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-08-21 13:39:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)\n\nHeader seems legit:\n\nvagrant@saio:~$ curl -g -I -XHEAD \"http://127.0.0.1:6040/sdb4/58/AUTH_test/ec-test/test\" -H \"X-Backend-Storage-Policy-Index: 1\"\nHTTP/1.1 200 OK\nContent-Length: 84\nX-Backend-Timestamp: 1566394648.72902\nX-Object-Sysmeta-Ec-Frag-Index: 0\nContent-Type: application/octet-stream\nX-Object-Sysmeta-Ec-Content-Length: 9\nX-Object-Sysmeta-Ec-Etag: e55cedc11adb39c404b7365f7d6291fa\nX-Backend-Fragments: {\"1566394648.72902\": [0]}\nLast-Modified: Wed, 21 Aug 2019 13:37:29 GMT\nEtag: \"eab2c2cecf97b86c5d8b518daf24c84c\"\nX-Timestamp: 1566394648.72902\nX-Backend-Data-Timestamp: 1566394648.72902\nX-Backend-Durable-Timestamp: 1566394648.72902\nX-Object-Sysmeta-Ec-Scheme: liberasurecode_rs_vand 4+2\nX-Object-Meta-Mtime: 1558121315.546175\nX-Object-Sysmeta-Ec-Segment-Size: 1048576\nDate: Wed, 21 Aug 2019 13:37:55 GMT\n\nextra info is good!","accounts_in_message":[],"_revision_number":1},{"id":"e2f89b368724258beb5e226d7596e87d488462eb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 13:39:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"33f85d5b8439b16494081edf41d373e560c2c73d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-08-21 15:41:42.000000000","message":"Patch Set 1:\n\nFWIW, the context was that somebody was doing some stress testing, to the point that there were 503s returned to the client, and we saw some log lines like\n\n Aug 20 17:47:10 sm-s2 object-reconstructor: [worker 2/3 pid\u003d9775] Unable to get enough responses (2/4) to reconstruct 192.168.3.42:6003/... policy#2 frag#4 with ETag 2d6426fa25e4ccf0eda7c0c89a28c8aa\n Aug 20 17:47:10 sm-s2 object-reconstructor: [worker 2/3 pid\u003d9775] Unable to get enough responses (4 error responses) to reconstruct 192.168.3.42:6003/... policy#2 frag#4\n\nand it\u0027d be nice to know whether that\u0027s actually indicative of a problem, or just some non-durable crud that a \"reasonable\" client would try to upload again.","accounts_in_message":[],"_revision_number":1},{"id":"5e79b6e0e35aab1c6a18eef4dc20fbd0bfc2800e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 17:34:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f858fef9f2a445d289ed35375bbfa5da : SUCCESS in 6m 56s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0de7eccedf8e43119df1fd88a812d4b5 : SUCCESS in 1h 02m 57s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/feb3d6337fd84768bf224c6d2e25b5a9 : SUCCESS in 50m 37s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/9995f171a8124fc48436937ec733dbc3 : SUCCESS in 11m 28s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/5741148803e544eca93d65815f4a1abd : SUCCESS in 14m 10s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/15f833c3217e4d1887503254bcace875 : SUCCESS in 12m 49s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/adec031b5c0a41c4953987e770729c93 : SUCCESS in 14m 58s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/be3fd1f06e8744ae8e25ebef628c56bc : SUCCESS in 10m 24s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/ade9e1d2e7764331b304b2dcc6d7450a : SUCCESS in 12m 13s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/cebb719669af466682d9d32668e4dc61 : SUCCESS in 12m 22s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/111c373504ba4e5c9c7ac480edc3b0d8 : SUCCESS in 11m 58s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/c9de880ddadd46c3ac7e42573ead3ee6 : SUCCESS in 15m 11s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/a51acdaf81054964ada167758632e6da : SUCCESS in 14m 19s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/9929c006b6a64e1eafeb1fad2b3ae072 : SUCCESS in 10m 31s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/683364f881aa4ee2850ae1ff8212e455 : SUCCESS in 18m 07s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/7f4a941ca3184bcc9b42f7859665085a : SUCCESS in 12m 05s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a4e907635a92436fa80f054a9bab0b22 : SUCCESS in 30m 29s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/84fb2c4bfb494876bfb6d9ce1066bc29 : SUCCESS in 28m 53s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/95ff1d945f01461b9a7cb99df219c5a0 : SUCCESS in 33m 25s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/d7381e4bb67b4ae398e98fb8ffc15ff8 : SUCCESS in 31m 55s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/53aa5ed9609d450781550119faa587f3 : SUCCESS in 11m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b88da3b95bde4d42a784efd059ecc72c : SUCCESS in 7m 05s","accounts_in_message":[],"_revision_number":1},{"id":"24846fd0da176dae926dcccf0c1803261a21a590","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 17:34:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9dd9cf9bfd66f9ffee742bcff58f71127011d5c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 17:38:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/55848b5dc00449f5bd82d5564f79debe : SUCCESS in 1m 04s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/4db780d81e5840edba174bd82ef1f7bc : SUCCESS in 1m 10s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ff5ea003b3a1b37d8417aa17d3521237768dfe62","revisions":{"ff5ea003b3a1b37d8417aa17d3521237768dfe62":{"kind":"REWORK","_number":1,"created":"2019-08-21 05:23:32.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/677608/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/677608/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/677608/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/677608/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/677608/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/677608/1"}}},"commit":{"parents":[{"commit":"f70520239c7fa2d22e4b9ee604bfaf7123b39095","subject":"Merge \"Fix symlink docstring\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f70520239c7fa2d22e4b9ee604bfaf7123b39095"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-08-21 05:20:44.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-08-21 05:23:00.000000000","tz":-420},"subject":"ec: log durability of frags that fail to reconstruct","message":"ec: log durability of frags that fail to reconstruct\n\nWhether the frag is durable or non-durable greatly affects how much I\ncare whether I can reconstruct it.\n\nChange-Id: Ie6f46267d4bb567ecc0cc195d1fd7ce55c8cb325\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ff5ea003b3a1b37d8417aa17d3521237768dfe62"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ff5ea003b3a1b37d8417aa17d3521237768dfe62"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}