)]}'
{"go/swift-rpc-losf/go.mod":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"671fdb6f0ec02ccae67b3f694df3fb01f22e411c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"require ("},{"line_number":10,"context_line":"\tgithub.com/alecuyer/statsd/v2 v2.0.6"},{"line_number":11,"context_line":"\tgithub.com/golang/protobuf v1.3.2"},{"line_number":12,"context_line":"\tgithub.com/golang/snappy v0.0.1 // indirect"},{"line_number":13,"context_line":"\tgithub.com/jmhodges/levigo v1.0.0"},{"line_number":14,"context_line":"\tgithub.com/konsorten/go-windows-terminal-sequences v1.0.2 // indirect"},{"line_number":15,"context_line":"\tgithub.com/kr/pretty v0.1.0 // indirect"}],"source_content_type":"audio/x-mod","patch_set":4,"id":"7faddb67_92f356e7","line":12,"updated":"2019-09-04 19:11:18.000000000","message":"I\u0027m not sure about all these new \"indirect\" dependencies.\n\"go mod graph\" did not help much, I\u0027ll want to check why they are now pulled (\"go-windows-terminal-sequences\"?)","commit_id":"7a4bbfd2329554204adfa7211b66edc025373aa4"}],"requirements.txt":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"d55111ea5844c34d4c030e3ac17a38dee498e7e0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# grpcio will fail to work with eventlet starting with 1.3.5."},{"line_number":18,"context_line":"# see this for a similar issue with gevent: https://github.com/grpc/grpc/issues/4629 and https://github.com/gevent/gevent/issues/786"},{"line_number":19,"context_line":"# don\u0027t use eventlet for the object-server ?"},{"line_number":20,"context_line":"grpcio\u003e\u003d1.10.0"},{"line_number":21,"context_line":"fusepy\u003e\u003d2.0.4"},{"line_number":22,"context_line":"protobuf\u003d\u003d3.9.1"}],"source_content_type":"text/plain","patch_set":1,"id":"7faddb67_32c5340b","line":20,"updated":"2019-08-28 10:20:17.000000000","message":"Missed removing grpcio.. this is not needed now (just need to figure how to get the protobuf compiler to work without having grpc installed. works for golang, not for python)","commit_id":"2c1289fd929a2863d55f80e1ba6395be2be099ee"}],"swift/obj/objectrpcmanager.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"d55111ea5844c34d4c030e3ac17a38dee498e7e0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                try:"},{"line_number":143,"context_line":"                    state \u003d rpc.get_kv_state(socket_path)"},{"line_number":144,"context_line":"                    if not state.isClean:"},{"line_number":145,"context_line":"                        self.logger.debug(volcheck_args)"},{"line_number":146,"context_line":"                        subprocess.call(volcheck_args)"},{"line_number":147,"context_line":"                except Exception:"},{"line_number":148,"context_line":"                    self.logger.exception(\"state check failed, continue\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b2d844f0","line":145,"updated":"2019-08-28 10:20:17.000000000","message":"to be removed","commit_id":"2c1289fd929a2863d55f80e1ba6395be2be099ee"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"d55111ea5844c34d4c030e3ac17a38dee498e7e0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                sleep(10)"},{"line_number":150,"context_line":"        else:"},{"line_number":151,"context_line":"            losf_args \u003d [\u0027swift-losf-rpc\u0027, \u0027-diskPath\u0027, str(disk_path),"},{"line_number":152,"context_line":"                         \u0027-debug\u0027, \u0027info\u0027,"},{"line_number":153,"context_line":"                         \u0027-policyIdx\u0027, str(policy_idx),"},{"line_number":154,"context_line":"                         \u0027-waitForMount\u003d{}\u0027.format(str(self.mount_check))]"},{"line_number":155,"context_line":"            if self.use_go_leveldb:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d2d380d2","line":152,"updated":"2019-08-28 10:20:17.000000000","message":"to be removed","commit_id":"2c1289fd929a2863d55f80e1ba6395be2be099ee"}],"swift/obj/rpc_http.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"83567811be9e05813c84e107e6bcb0e1b2ec9373","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Implements RPC: protobuf over a UNIX domain socket"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import socket"},{"line_number":19,"context_line":"from swift.common.bufferedhttp import httplib"},{"line_number":20,"context_line":"from swift.obj import fmgr_pb2 as pb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_8f17b2ee","line":19,"updated":"2019-09-04 16:11:48.000000000","message":"is this the right thing to do ?","commit_id":"7a4bbfd2329554204adfa7211b66edc025373aa4"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"248158b09f2caabebfbd1cbcf323c869d803d163","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Implements RPC: protobuf over a UNIX domain socket"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import socket"},{"line_number":19,"context_line":"from swift.common.bufferedhttp import httplib"},{"line_number":20,"context_line":"from swift.obj import fmgr_pb2 as pb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_39cc8988","line":19,"in_reply_to":"7faddb67_6ac104e4","updated":"2019-09-06 15:22:28.000000000","message":"oops saw your message after pushing again with the import from eventlet.green\nI just tried with BufferedHTTPConnection, I need to override getresponse() which wants self._connected_time, but another issue is that our HTTPConnection.getresponse() does not seem to be able to pass the buffering keyword argument. I\u0027ll look more into it (at least with the regular lib, not passing this resulted in one recvfrom() syscall per char).","commit_id":"7a4bbfd2329554204adfa7211b66edc025373aa4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"056197beceb8f269d83cb3bd8d9420d45ab0d434","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Implements RPC: protobuf over a UNIX domain socket"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import socket"},{"line_number":19,"context_line":"from swift.common.bufferedhttp import httplib"},{"line_number":20,"context_line":"from swift.obj import fmgr_pb2 as pb"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6ac104e4","line":19,"in_reply_to":"7faddb67_8f17b2ee","updated":"2019-09-04 17:26:03.000000000","message":"Oh, that does feel weird... I\u0027d be inclined to import from six.moves if we really want stdlib -- but be aware that it can behave badly with UTF-8 in headers on py3. Maybe we want to subclass our BufferedHTTPConnection?","commit_id":"7a4bbfd2329554204adfa7211b66edc025373aa4"}]}