)]}'
{"id":"openstack%2Fswift~681875","triplet_id":"openstack%2Fswift~master~I73f84b96f164e6fc5d3cb890355871c26ed271a6","project":"openstack/swift","branch":"master","topic":"bug/1843816","hashtags":[],"change_id":"I73f84b96f164e6fc5d3cb890355871c26ed271a6","subject":"bufferedhttp: ensure query params are properly quoted","status":"MERGED","created":"2019-09-12 18:48:38.000000000","updated":"2019-09-21 05:57:10.000000000","submitted":"2019-09-21 05:54:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"681875-1569045274785-fe8b4c94","meta_rev_id":"9abeeef254ea86fd5b80eaf81bddd451e2bbd3dd","_number":681875,"virtual_id_number":681875,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-21 05:54:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-21 04:30:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":2,"date":"2019-09-13 20:10:30.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-21 04:30:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-13 20:10:30.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2019-09-21 05:54:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7e8f578358cdcfe8cf7c226e2a88b09111345b56","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-12 18:48:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7195778bde3aeddffab1a04ec28ac8614c45b9ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-13 04:01:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/44dbd4805e6e47b397f70225a7a77375 : SUCCESS in 6m 09s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/62d973c98e8248dc8eb01f971b851c7b : SUCCESS in 1h 03m 47s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/7025ed01914746af92df2f2667d6cf9a : SUCCESS in 52m 28s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/553ed950b1dd4b0e97c85ba3c49807d4 : SUCCESS in 8m 15s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/8a7b664a876c478c8d27f072eddea665 : SUCCESS in 14m 14s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/9061901e513b4d39ba2cbb2f92834158 : SUCCESS in 11m 45s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/6ef0ed79d6824fa7971fb31126648b33 : SUCCESS in 11m 56s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/4057f54cf2734f0c9045b32e4b780f2f : SUCCESS in 9m 11s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/8a2180cbd2fe4cce8151cb74399762e9 : SUCCESS in 10m 25s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/05490a99961849fb8d0009984b9a1c55 : SUCCESS in 10m 20s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/84a4089d4857474ba455adbe49537444 : SUCCESS in 16m 10s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/92aafdd9d9224671b8a3a3188599c039 : SUCCESS in 11m 59s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/21a2134dbb2947d0a8a1dbc2814a2fe1 : SUCCESS in 13m 58s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/3d824e5a70fc41bb869a75006bd88b06 : SUCCESS in 18m 10s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/87ddb843212345f1903827079cea82ae : SUCCESS in 15m 52s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/3cca4c2719304c8d98553bca35b594ad : SUCCESS in 10m 37s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/7649424548e149d2a5e4a2f075e9b75a : SUCCESS in 32m 48s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/492dbc8f759c42d0b85a24f636a283b1 : SUCCESS in 14m 29s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/d2e19fe649ca400893a005c038c0595a : SUCCESS in 33m 41s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/728404fb9f8d47daae92bbdbf1306134 : SUCCESS in 29m 29s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/127def5f043846568547d9da78b511f9 : SUCCESS in 28m 12s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/a7249bf8a6504f0cabd07baf8f1b4e12 : SUCCESS in 40m 19s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0bb13ec5e177466b839c189b069e4544 : SUCCESS in 12m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c276077aa03840519479e282d4fe84c2 : SUCCESS in 5m 51s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/03221db7607c4b9a9eec3b38026f682c : SUCCESS in 16m 49s","accounts_in_message":[],"_revision_number":1},{"id":"f3be71eac55a1b064f6d694c3bec10ed9af6e8a7","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-09-13 20:10:30.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1776041b76b95b2b89d32fb7c65c069b0e35a158","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-13 21:08:27.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1e133ebdc3f6c2eeb7463c8c5628b9cbee1b2c91","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-21 04:30:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nWe\u0027ve got confirmation that this (combined with a backport of https://review.opendev.org/#/c/642893/) will get us a working gate on stable again for pike: https://review.opendev.org/#/c/683284/\n\nI\u0027m gonna go ahead and approve this. I\u0027ve proposed patches for ocata through stein, only combining them when needed; will approve them as we see them working.","accounts_in_message":[],"_revision_number":1},{"id":"8c2cb22c82151930ff689c2239dd8d9e54f956e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 04:30:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5ed75428277c7006ce65e4b0c01357a418361846","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 05:54:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e0f71b8db6f042adb187cdc231cd3a33 : SUCCESS in 5m 18s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/979da1003a7b4c03b3d260a8abf1bcf0 : SUCCESS in 1h 02m 56s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/6478d88538934301bb321b5c7cd7a787 : SUCCESS in 55m 32s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/bf45cf6852454bd6b417bb39cc75d5d5 : SUCCESS in 9m 35s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/450160a3eb7a496c99d984f71def9001 : SUCCESS in 12m 23s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1ac8b351b05042298db4540534603585 : SUCCESS in 12m 47s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/77c81d735a4648a8aa00b1719b3e9abe : SUCCESS in 11m 40s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/1808914bf6bb48f8908acaad0b56c17a : SUCCESS in 9m 01s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/aa8a84e932be40498654b688299a5119 : SUCCESS in 9m 04s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/5c539a7c745341c59758e488c380429e : SUCCESS in 9m 19s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/7e6a636d9ca4430fb4ae2193f16eeda8 : SUCCESS in 10m 56s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/fac91eb293d34b9a9ee451b823a11c4b : SUCCESS in 14m 00s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/1be850f8bf9742868cbb067e6b33b85e : SUCCESS in 9m 13s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/4c74f715e9014c778d85c76bd440be22 : SUCCESS in 11m 41s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/8361299234f24dc6b149700aa27a94a9 : SUCCESS in 11m 10s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/5b3b7a06b6ae40c49c688e9edec774c6 : SUCCESS in 13m 58s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/10b41cc7925949eca6de2b310769ad01 : SUCCESS in 32m 12s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b5435dbffeb1406784ac06b9b353c3bd : SUCCESS in 30m 54s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/27fb077ff5a74277b798880726cc94d4 : SUCCESS in 33m 20s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/a7e1892f94b9440d93dc7af5e6099125 : SUCCESS in 32m 04s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8dc19a3d53384e8b81a8f47b3da445c9 : SUCCESS in 13m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7453cb5c7b0243b69930c6ec25799912 : SUCCESS in 5m 48s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5d02c457e2f744fc8e009b3c56ffe4f1 : SUCCESS in 1h 15m 34s","accounts_in_message":[],"_revision_number":1},{"id":"57d64ec07f8b0e5403504723ef923285b0374995","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 05:54:34.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ca2c80e10580394e3b5ba3217fe5d4ba6fe4336b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 05:57:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a3132ae6b1c48738e4a624440e66ad3 : SUCCESS in 1m 14s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/27c198d0279e4bbba92efdefc31cddb5 : SUCCESS in 41s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34","revisions":{"49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34":{"kind":"REWORK","_number":1,"created":"2019-09-12 18:48:38.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/75/681875/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/75/681875/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/75/681875/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/75/681875/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/75/681875/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/75/681875/1"}}},"commit":{"parents":[{"commit":"5cb53838a63791109697c91f742079b6dfb25263","subject":"Merge \"py3: (mostly) port probe tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5cb53838a63791109697c91f742079b6dfb25263"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 17:59:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 18:48:03.000000000","tz":-420},"subject":"bufferedhttp: ensure query params are properly quoted","message":"bufferedhttp: ensure query params are properly quoted\n\nRecent versions of py27 [1] have begun raising InvalidURL if you try to\ninclude non-ASCII characters in the request path. This was observed\nrecently in the periodic checks of stable/ocata and stable/pike. In\nparticular, we would spin up some in-process servers in\ntest.unit.proxy.test_server.TestSocketObjectVersions and do a container\nlisting with a prefix param that included raw (unquoted) UTF-8. This\nquery string would pass unmolested through the proxy, tripping the\nInvalidURL error when bufferedhttp called putrequest.\n\nMore recent versions of Swift would not exhibit this particular failure,\nas the listing_formats middleware would force a decoding/re-encoding of\nthe query string for account and container requests. However, object\nrequests with errant query strings would likely be able to trip the same\nerror.\n\nSwift on py3 should not exhibit this behavior, as we so\nthoroughly re-write the request line to avoid hitting\nhttps://bugs.python.org/issue33973.\n\nNow, always parse and re-encode the query string in bufferedhttp. This\nprevents any errors on object requests and cleans up any callers that\nmight use bufferedhttp directly.\n\n[1] Anything after https://github.com/python/cpython/commit/bb8071a;\n    see https://bugs.python.org/issue30458\n\nCloses-Bug: 1843816\nChange-Id: I73f84b96f164e6fc5d3cb890355871c26ed271a6\nRelated-Change: Id3ce37aa0402e2d8dd5784ce329d7cb4fbaf700d\nRelated-Change: Ie648f5c04d4415f3b620fb196fa567ce7575d522\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}