)]}'
{"id":"openstack%2Fswift~681879","triplet_id":"openstack%2Fswift~stable%2Fpike~I73f84b96f164e6fc5d3cb890355871c26ed271a6","project":"openstack/swift","branch":"stable/pike","topic":"bug/1843816","hashtags":[],"change_id":"I73f84b96f164e6fc5d3cb890355871c26ed271a6","subject":"bufferedhttp: ensure query params are properly quoted","status":"ABANDONED","created":"2019-09-12 19:04:52.000000000","updated":"2019-09-20 18:26:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2bded567b1f10dc30c5f191080f09686186ffeab","_number":681879,"virtual_id_number":681879,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-09-20 04:39:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-20 04:39:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c0aeaeaf97780463ed0fbb8b20596ac7e3755f82","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-12 19:04:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"15b06b2fd0a90cfbc3faa23fe15af1973ba5ddb5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-13 04:37:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/5101da9b33eb4835962dfab8018449cc : SUCCESS in 6m 48s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/8708ef8d8a704acb925947bf6483e251 : SUCCESS in 7m 53s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/762f7a8953724473b44ea42e2c982c4a : SUCCESS in 3m 33s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/7b595f8bd8fb4bcea6b8fff34119727c : FAILURE in 9m 36s\n- swift-tox-func-post-as-copy https://zuul.opendev.org/t/openstack/build/e44e588454034573963e3ffa2c0e2b4a : FAILURE in 7m 50s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/cd259ed842b542e78a61132e1fe1435d : FAILURE in 9m 13s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/a67addd252194f3286d0856c8d7ce76f : FAILURE in 8m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f7a99f0b543d44988b13440f91e8c73d : SUCCESS in 3m 59s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/2076892c308743c984f19dd30a910953 : FAILURE in 21m 22s\n- swift-dsvm-functional-identity-v2 https://zuul.opendev.org/t/openstack/build/f56bc7557a154031991b45e3918d6a4b : FAILURE in 22m 24s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/74f317c505d046cd99e51e5661f57d41 : SUCCESS in 1h 28m 54s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/e8bb0cccfd124e4b9fbec0756f708405 : SUCCESS in 59m 59s","accounts_in_message":[],"_revision_number":1},{"id":"8d645648bc0a596f0a6016a7bbb5534d13105efe","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-13 04:46:09.000000000","message":"Patch Set 1: Workflow-1\n\n...well... at least it fixed hte unit tests :-/","accounts_in_message":[],"_revision_number":1},{"id":"ca0fea4c27abf1152e25664d207a7d2d35bae369","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-19 17:00:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"84b63d46646af7057df6237fa94965950edf8c8e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 04:39:11.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/9afe5a2926414c0c98f658c5ba84cd21 : SUCCESS in 6m 34s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/d7976b7c782e495887ad3e0f7ad98b65 : FAILURE in 8m 24s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/95349132c6c046e7b9458130a724ad0a : SUCCESS in 3m 25s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/23949a2e8de84844bd648288f5139f5f : FAILURE in 6m 55s\n- swift-tox-func-post-as-copy https://zuul.opendev.org/t/openstack/build/207b5556cb2d45e68b2414510f2f274a : FAILURE in 7m 58s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/a481e3d62570462789959f0f901fb555 : FAILURE in 8m 18s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/fa6651585c424b9c8de5c6ed96bdb9aa : FAILURE in 9m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/befdd4207779400e8370610c0e340420 : SUCCESS in 4m 38s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/2cad3c38430241e9af7b2c76c6aa33fc : FAILURE in 22m 29s\n- swift-dsvm-functional-identity-v2 https://zuul.opendev.org/t/openstack/build/483a65abf09e456e8e4bdb66e87952cf : FAILURE in 18m 13s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/c7611d18eb4c490f8ae41e752d9cb557 : SUCCESS in 1h 34m 01s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/f700975a10a9414997c896a130ea6b6d : SUCCESS in 56m 02s","accounts_in_message":[],"_revision_number":2},{"id":"c806d0afdadda36537848c3bba84b84ff508b83a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-20 18:26:49.000000000","message":"Abandoned\n\nHave to land two fixes at once; dropping in favor of https://review.opendev.org/#/c/683284/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"818b8bbc95b856a2aec98f42b510cefea99f696e","revisions":{"6b4e3f645500358d41a040ad12ad19a7790b781a":{"kind":"REWORK","_number":1,"created":"2019-09-12 19:04:52.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/79/681879/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/79/681879/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/79/681879/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/79/681879/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/79/681879/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/79/681879/1"}}},"commit":{"parents":[{"commit":"fbfb89bebd9d30692293c71c5b9b0c55904320b7","subject":"Remove openSUSE 42.3 job","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fbfb89bebd9d30692293c71c5b9b0c55904320b7"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 17:59:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 19:03:44.000000000","tz":-420},"subject":"bufferedhttp: ensure query params are properly quoted","message":"bufferedhttp: ensure query params are properly quoted\n\nRecent versions of py27 [1] have begun raising InvalidURL if you try to\ninclude non-ASCII characters in the request path. This was observed\nrecently in the periodic checks of stable/ocata and stable/pike. In\nparticular, we would spin up some in-process servers in\ntest.unit.proxy.test_server.TestSocketObjectVersions and do a container\nlisting with a prefix param that included raw (unquoted) UTF-8. This\nquery string would pass unmolested through the proxy, tripping the\nInvalidURL error when bufferedhttp called putrequest.\n\nMore recent versions of Swift would not exhibit this particular failure,\nas the listing_formats middleware would force a decoding/re-encoding of\nthe query string for account and container requests. However, object\nrequests with errant query strings would likely be able to trip the same\nerror.\n\nSwift on py3 should not exhibit this behavior, as we so\nthoroughly re-write the request line to avoid hitting\nhttps://bugs.python.org/issue33973.\n\nNow, always parse and re-encode the query string in bufferedhttp. This\nprevents any errors on object requests and cleans up any callers that\nmight use bufferedhttp directly.\n\n[1] Anything after https://github.com/python/cpython/commit/bb8071a;\n    see https://bugs.python.org/issue30458\n\nCloses-Bug: 1843816\nChange-Id: I73f84b96f164e6fc5d3cb890355871c26ed271a6\nRelated-Change: Id3ce37aa0402e2d8dd5784ce329d7cb4fbaf700d\nRelated-Change: Ie648f5c04d4415f3b620fb196fa567ce7575d522\n(cherry picked from commit 49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34)\n(cherry picked from commit aa0b78a51de2d845183d0da0c21dcca81a5de965)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6b4e3f645500358d41a040ad12ad19a7790b781a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6b4e3f645500358d41a040ad12ad19a7790b781a"}]},"branch":"refs/heads/stable/pike"},"818b8bbc95b856a2aec98f42b510cefea99f696e":{"kind":"REWORK","_number":2,"created":"2019-09-19 17:00:03.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/79/681879/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/79/681879/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/79/681879/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/79/681879/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/79/681879/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/79/681879/2"}}},"commit":{"parents":[{"commit":"1703a8b9a3ce57e54289f3f315cae84fed88e687","subject":"py2/3: Stop using stdlib\u0027s putrequest(); it only does ASCII","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1703a8b9a3ce57e54289f3f315cae84fed88e687"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 17:59:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-19 16:59:47.000000000","tz":-420},"subject":"bufferedhttp: ensure query params are properly quoted","message":"bufferedhttp: ensure query params are properly quoted\n\nRecent versions of py27 [1] have begun raising InvalidURL if you try to\ninclude non-ASCII characters in the request path. This was observed\nrecently in the periodic checks of stable/ocata and stable/pike. In\nparticular, we would spin up some in-process servers in\ntest.unit.proxy.test_server.TestSocketObjectVersions and do a container\nlisting with a prefix param that included raw (unquoted) UTF-8. This\nquery string would pass unmolested through the proxy, tripping the\nInvalidURL error when bufferedhttp called putrequest.\n\nMore recent versions of Swift would not exhibit this particular failure,\nas the listing_formats middleware would force a decoding/re-encoding of\nthe query string for account and container requests. However, object\nrequests with errant query strings would likely be able to trip the same\nerror.\n\nSwift on py3 should not exhibit this behavior, as we so\nthoroughly re-write the request line to avoid hitting\nhttps://bugs.python.org/issue33973.\n\nNow, always parse and re-encode the query string in bufferedhttp. This\nprevents any errors on object requests and cleans up any callers that\nmight use bufferedhttp directly.\n\n[1] Anything after https://github.com/python/cpython/commit/bb8071a;\n    see https://bugs.python.org/issue30458\n\nCloses-Bug: 1843816\nChange-Id: I73f84b96f164e6fc5d3cb890355871c26ed271a6\nRelated-Change: Id3ce37aa0402e2d8dd5784ce329d7cb4fbaf700d\nRelated-Change: Ie648f5c04d4415f3b620fb196fa567ce7575d522\n(cherry picked from commit 49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34)\n(cherry picked from commit 107f1c9bd5b51a04c11e02275d1640f504741ce6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/818b8bbc95b856a2aec98f42b510cefea99f696e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/818b8bbc95b856a2aec98f42b510cefea99f696e"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}