)]}'
{"id":"openstack%2Fswift~682698","triplet_id":"openstack%2Fswift~master~I3d96022c01834c85e9795ea41d18b17624a33a19","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I3d96022c01834c85e9795ea41d18b17624a33a19","subject":"Close leaking opened requests","status":"MERGED","created":"2019-09-17 17:01:15.000000000","updated":"2019-09-19 00:40:49.000000000","submitted":"2019-09-19 00:36:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682698-1568853418675-f612c5ef","meta_rev_id":"012ba2a8860f0e2fc379ec942e2126116c850820","_number":682698,"virtual_id_number":682698,"owner":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2019-09-19 00:36:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2019-09-18 19:54:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-18 16:43:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2019-09-18 19:54:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-18 16:43:39.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-09-18 19:54:47.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-09-19 00:36:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0e5be139f765cb311b1e06830adfb4ea44f07a59","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-09-17 17:01:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95573ec89d66f68263dbf1966c4855ebc884eb05","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 00:45:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/35515ae724944ea2b56124df4821a89a : SUCCESS in 6m 01s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/b9a2494faaac49b488b8c75230067df0 : SUCCESS in 1h 13m 58s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/209c08685c2345e399185849f0d661b3 : SUCCESS in 55m 14s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/d04610dacfcd4869a8a09830db914f5f : SUCCESS in 9m 28s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/51d632f7b97b461ab7ee9ed7d7a33738 : SUCCESS in 12m 24s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/3ccb45d07bec4037a379500918907e58 : SUCCESS in 13m 00s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f35b1ba9cbd04059a6d3c27c16a652d4 : SUCCESS in 11m 58s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/148bf12281d84b14bd0c1aca93add702 : SUCCESS in 12m 39s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/3126dc52ecb249d0b693eb69fe447d0a : SUCCESS in 9m 02s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/4518d3921ab94b0fb5c605ee92930ef4 : SUCCESS in 11m 52s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/b403a271d38f4c1da7265677e5949cc7 : SUCCESS in 9m 56s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/e6c46c7f16d74dff886de7aa3af40cc1 : SUCCESS in 12m 07s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c713242f49b844c585150ccef6fb29d3 : SUCCESS in 10m 25s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/c682f5ea788b48d19a26b9c4049a360a : SUCCESS in 11m 34s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/43578403842345b29c65c034706985b3 : SUCCESS in 13m 06s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/d59caf03f8664c96888381caf6935323 : SUCCESS in 10m 57s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/cc92f586112e4bdcb932d06dbc6e35e9 : SUCCESS in 14m 56s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/d823c25350d647a28ff5a50265bb109d : SUCCESS in 11m 37s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/3919c27125a143e98a0a7cf92a033b8d : SUCCESS in 31m 11s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/7e000ca60bac42b8bb9cfb123e0e36f6 : SUCCESS in 25m 23s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/7e27192f711747a5b8f6f3ad1743921a : SUCCESS in 24m 44s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/2833a41dd1f74842af6b3c375474d0ab : SUCCESS in 30m 45s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0e29a42bd25b40c686a82e6082d311d1 : SUCCESS in 12m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5f8a3a2f0a964cc291e92c5693cb9dd9 : SUCCESS in 5m 49s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/4ae9d29073d74acb81d41a0fb594210f : SUCCESS in 18m 24s","accounts_in_message":[],"_revision_number":1},{"id":"2ec6e708407021d1a0d8e22263012600f9e69419","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-18 16:43:39.000000000","message":"Patch Set 1: Code-Review+2\n\nYeah, that looks like a good idea ;-)\n\nIf I remember right, I saw unit tests fail somewhere; something something LeakTrackingIter. I don\u0027t think it affects real systems, though -- since they\u0027re HEAD requests, we read the whole thing in reiterate() or something like it, which i *think* cleans up the connection?","accounts_in_message":[],"_revision_number":1},{"id":"9e77d78419c9a8f9cad98ef78ce3447cd5d452ed","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-09-18 19:54:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI don\u0027t see anything *wrong* with this change, but I\u0027m curious how you found it just cause it might point at other leaks we could be missing?","accounts_in_message":[],"_revision_number":1},{"id":"ad955662bb61a01834208d04536374ab4ae4a094","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 19:55:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7ace8b6ea9330263afeb9f9183793e23ed7461f0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 21:51:11.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"81105ca3a1eda4b09c66b8d24f280b74b3f2e59f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 00:36:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9526988012954e14933ea7692059d693 : SUCCESS in 6m 24s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/33936dc7fd034d80a59589c79e21cbf9 : SUCCESS in 58m 34s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/62c91ebcd9b84808944d1e9ebe9e9b9a : SUCCESS in 53m 59s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/bf8e469a199242268608e5d27debb8ad : SUCCESS in 11m 14s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/4a4ab96d10d54d1fa3b6a9714fae2100 : SUCCESS in 12m 06s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/79cf50080b064011b35b3ba3c0e350e6 : SUCCESS in 13m 02s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/bfc227f2b6e144788933347ed74195d9 : SUCCESS in 12m 43s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/b18461da42cf4fa98bc20a09df1c8b08 : SUCCESS in 9m 50s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/2034022b2f424afc88dcf013a45ba358 : SUCCESS in 9m 32s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/a2aa4e3c7b8d44b188f983213e8a6ce5 : SUCCESS in 10m 41s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/bc42cc968f6f4e20abcf344a0c11305b : SUCCESS in 11m 21s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/5f08ffe9d72c4d5cb91aaafc9589529e : SUCCESS in 15m 50s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/edd6f20abd8f4d59a4c82089b7f24797 : SUCCESS in 10m 04s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/44a23449bb5840438f865a0507bd433e : SUCCESS in 9m 55s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/82e34134e27f49dc84d34a9e5a762d1b : SUCCESS in 13m 24s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/7c7dcbb320ce4416b399d6032431f448 : SUCCESS in 14m 10s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/16bb8765521b47aaacc35d29df51bad4 : SUCCESS in 34m 24s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/2b2fd0e670de46ccabb2a9930bbf056d : SUCCESS in 29m 09s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/01e08fe5fe514e11a4bdbf58d2550182 : SUCCESS in 28m 15s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/762722a31dec4363b73a37226f9f03da : SUCCESS in 31m 09s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3185538a4a9c4e1ebc89ad7b6937f6f9 : SUCCESS in 12m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6022300c58ca4d32858a5ddc1715cdac : SUCCESS in 5m 48s","accounts_in_message":[],"_revision_number":1},{"id":"2138f98ca8e8f1c9f4b9cee0e70ebafa98cf26a5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 00:36:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"012ba2a8860f0e2fc379ec942e2126116c850820","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 00:40:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8bb6da0097af46b2987a33ae4ab7d2a9 : SUCCESS in 1m 26s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/5927106c4d2846f2b4e6bc8a56adc605 : SUCCESS in 57s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"20fc16e8daa184ebadab9f49e0f76e7687a8cebd","revisions":{"20fc16e8daa184ebadab9f49e0f76e7687a8cebd":{"kind":"REWORK","_number":1,"created":"2019-09-17 17:01:15.000000000","uploader":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"ref":"refs/changes/98/682698/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/98/682698/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/98/682698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/98/682698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/98/682698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/98/682698/1"}}},"commit":{"parents":[{"commit":"6339bd8f6c2755c0bfd5e1769d2a0fafee04c176","subject":"Merge \"Allow arbitrary UTF-8 strings as delimiters in listings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6339bd8f6c2755c0bfd5e1769d2a0fafee04c176"}]}],"author":{"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","date":"2019-09-17 16:57:35.000000000","tz":120},"committer":{"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","date":"2019-09-17 16:57:35.000000000","tz":120},"subject":"Close leaking opened requests","message":"Close leaking opened requests\n\nChange-Id: I3d96022c01834c85e9795ea41d18b17624a33a19\nCo-Authored-By: Tim Burke \u003ctim.burke@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/20fc16e8daa184ebadab9f49e0f76e7687a8cebd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/20fc16e8daa184ebadab9f49e0f76e7687a8cebd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}