)]}'
{"id":"openstack%2Fswift~683754","triplet_id":"openstack%2Fswift~stable%2Frocky~I73f84b96f164e6fc5d3cb890355871c26ed271a6","project":"openstack/swift","branch":"stable/rocky","topic":"bug/1843816","hashtags":[],"change_id":"I73f84b96f164e6fc5d3cb890355871c26ed271a6","subject":"bufferedhttp: ensure query params are properly quoted","status":"MERGED","created":"2019-09-21 04:09:59.000000000","updated":"2019-09-24 02:36:25.000000000","submitted":"2019-09-24 02:36:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683754-1569292585156-efb49f7a","meta_rev_id":"f78f4bf4ecb30f95e5bdb7f3d8e5bba77ec2e6a0","_number":683754,"virtual_id_number":683754,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-24 02:36:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-21 16:14:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-21 16:14:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-24 02:36:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d0488d5b8ccc93705a831eb9f594c0e9f35131a7","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-21 04:09:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dcb7e3f339fde6c9f5371989edc1e66561dfcc33","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 05:57:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/a1049c5dbee6450793af882015d605f3 : SUCCESS in 6m 10s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/0a282fb2cffb47149b4b941f7f328763 : SUCCESS in 10m 05s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/ab70c0793c9b4361a9d465529606483b : SUCCESS in 5m 34s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/8468206fba7e4edd9c62f9f122ef4619 : SUCCESS in 9m 45s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/71958b683b854450b26d274f0dca706b : SUCCESS in 9m 41s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/bbae8b7aeaec46358186cd1e989d2e4c : SUCCESS in 9m 11s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/28597a16ae884c84a6f6b52ff57ad3a6 : SUCCESS in 9m 51s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/185b2657164a4d159a35dc48b6e3633f : SUCCESS in 10m 46s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/de30775ded40486d8eae36aa86806978 : SUCCESS in 29m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ad8530b9fd44820aa0cde4923940923 : SUCCESS in 8m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf2a14984caa41339353468dd8fb7681 : SUCCESS in 6m 22s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/bb6575284abc4d6fae093b4363884bf1 : SUCCESS in 24m 38s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/5d2f631330f74195bbf5a1b9bf865a7f : SUCCESS in 1h 24m 28s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/045db54e5c8d42519ca6b20a57153649 : SUCCESS in 56m 38s","accounts_in_message":[],"_revision_number":1},{"id":"bbcf03d467dc90a4f74982c42d93298374e16caa","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-21 16:14:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2e8accd321c3cce699c527e94040c5e0cc1565ff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 16:14:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a6467d09aba960cb073af7808bd359858a5fdb1c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 17:42:24.000000000","message":"Patch Set 1: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"a53f8c38a886b1667e5617bd97cc5c2dcd5cb20b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-22 03:49:28.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e9a66ceba239f47d04dfc11521a2a503cd4ce215","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-22 05:23:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/aeb259651b89404db838355e6a97f9a3 : SUCCESS in 4m 49s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/49c75675854d4bc5bcea1e1589612918 : SUCCESS in 12m 18s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/6bd2fe13a25b4a34975422e67a3500f4 : SUCCESS in 4m 18s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/6ddd5041063b46de8d78cda01017b133 : SUCCESS in 7m 44s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/e9d8fbdbc8294ba2aac35b9122271503 : SUCCESS in 8m 35s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/e115f86a3b8e49a49c42dba925013f90 : SUCCESS in 8m 10s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/7c1c8545cc994eab920f06a4eeec677c : SUCCESS in 9m 10s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/78e52dfcda184cf592216276978199b0 : SUCCESS in 9m 12s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/8e24bf7579b142cd8d082c1eb22fbca2 : FAILURE in 26m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2929cd48cb454127a5c1b538ee2209c1 : SUCCESS in 10m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0ee82e28e81647219959329f941cec58 : SUCCESS in 4m 56s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/28306fc65edc42f582848ecd64cbce94 : SUCCESS in 27m 44s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/b3f36f8b78a24bdeb2db38880ae08c47 : SUCCESS in 1h 25m 28s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/f741e599c23b40699af4e5881f6f8d3a : SUCCESS in 57m 58s","accounts_in_message":[],"_revision_number":1},{"id":"ddba3ba10bf62547949b47440eda761e89bb351d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 15:07:34.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7116678b1d2f9ddbe779df6cd7b75907db8f234b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:17:33.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/e9f3b560b3d447b5a6a0a825bb97f8a8 : SUCCESS in 6m 38s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/8502840463f1412895acca7f776416a4 : SUCCESS in 13m 41s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/83f7b8228fc048d283d55dc00b40deb8 : SUCCESS in 5m 58s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/cdfea10fbe874bf2b4151941f69c686d : SUCCESS in 9m 27s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/a0c21cd300294d63a94d202f63420930 : SUCCESS in 10m 35s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/22c91dbf496f4bb085c644c772219620 : SUCCESS in 8m 32s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/a1a34ae167584e2d8d91d862e31aeaf2 : SUCCESS in 10m 59s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/4275a282fdee4132af5d4c6e51d6532a : FAILURE in 12m 32s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/b64ab840b7574b9099573b14113d2ec9 : FAILURE in 37m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/338a10cde21c4187b258d944eeb866ec : SUCCESS in 10m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/06009030096a4639b15404e6c3c2e64b : SUCCESS in 4m 54s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/27dfd81410084508867e536d887ffcfe : SUCCESS in 22m 22s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/43f183f2feeb49b2a414d50a0ceda2a6 : SUCCESS in 1h 31m 47s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/da306488f4354103b8b78c52af7b67ae : SUCCESS in 1h 05m 40s","accounts_in_message":[],"_revision_number":1},{"id":"1ce7ff172c5629a9b2c0ff58651ef36a5937585b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 20:18:32.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0b4bb383775bc2445b55a5de335b3df2a0c1bcd5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 22:16:28.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/4e60ca5c4a1d4ebda98362559ddc601f : SUCCESS in 6m 15s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/af380fcbc13e4efeaf6a96f48ffaaffd : SUCCESS in 9m 29s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/524a7c98918f4785bb5912580883eabe : SUCCESS in 5m 32s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/31b91040a423424a89931e651343f69f : SUCCESS in 8m 46s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/32b3235d0b69481fbeb929514e8c6af5 : SUCCESS in 10m 25s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/eb614beff5bf480ea03a4afdc5531405 : FAILURE in 10m 24s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/4d88bf3bf61043ce801ce6293d5ba911 : SUCCESS in 10m 30s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/14d713bf87044747a2dd5cabd815b522 : SUCCESS in 11m 55s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/2d300a827deb4662a5d1cdd2ec27c5b8 : FAILURE in 41m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/22a44f067fc141ee8b37bcbc19a2ea1d : SUCCESS in 7m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a8de93cb7347436fb4ba5de485b89fde : SUCCESS in 6m 00s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/58cc9fa30e4547dbb32949e163ea21ae : SUCCESS in 33m 14s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/0c4abcbef0bd44eb861888ae40f3034c : SUCCESS in 1h 25m 36s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/2a63081996b541af9e8ce25fa2fb64fb : SUCCESS in 1h 02m 56s","accounts_in_message":[],"_revision_number":1},{"id":"dc58c95dcf8a8679ddd5a73fabdf9ab41285cd4d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 22:30:38.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"be6f89f13c01c73ef1da64dcbeb70f2a3a3252f1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 00:14:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/32f6d6d9c619404aa26965c32c408a42 : SUCCESS in 6m 31s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/e6841f98f9d34fd595027468746dbecf : SUCCESS in 14m 37s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/5e0ffd56d3554d13af62279a252dffc8 : SUCCESS in 5m 51s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/9b4a4df4eaa9472b91e1be5a635b9740 : SUCCESS in 8m 39s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/bb73ca825e9745528f16e627fd5c357f : SUCCESS in 9m 22s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/d589d6b9ad61499c9e070824fa06b708 : SUCCESS in 7m 49s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/b24c28344ac142538de9050cf0e32db4 : SUCCESS in 10m 02s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/d83084eee0e845c9b59efa5b6388fdb0 : SUCCESS in 9m 24s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/e7234e2555824ddb90bcca98348c5db5 : SUCCESS in 40m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/eb0a18622dd14101bbfc362036a544ef : SUCCESS in 7m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd211a8412d245a28aed836407b3e251 : SUCCESS in 5m 05s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/5cc191a67835443181417980fedd5b65 : SUCCESS in 25m 03s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/7d1261540abc4ee5a3ca660bc1707fab : SUCCESS in 1h 38m 17s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/081ec980676e4332a539909c9179e35f : SUCCESS in 53m 43s","accounts_in_message":[],"_revision_number":1},{"id":"8a73b7ea9beffa0b0c45a17c40945a21134eb6fa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 00:15:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"18af6f09cb3e8b784a0c10ead9e56b6897641189","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 02:36:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/9cca59c0749c42a482299903206cf281 : SUCCESS in 6m 05s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/ba4b81e522f04cfb9428939e55629911 : SUCCESS in 9m 49s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/2df85728b4004aa0b5a189c3c5ce9e53 : SUCCESS in 5m 09s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/72fa80dd01fb4db8ba48939d7849f3d3 : SUCCESS in 9m 03s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/f16a3b8ebf214c8b837102215af5ca28 : SUCCESS in 9m 06s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/a2af8a5bad9e4d2b966626507ed52d6e : SUCCESS in 8m 23s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/e389cf8093a64d2498b360f12d72982f : SUCCESS in 9m 31s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/ec7fe2904fc84ba9bea3c1b9db5ec0b5 : SUCCESS in 10m 12s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/d039e2cbd858485190cc64904b4d274d : SUCCESS in 30m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4e91097ee419437b9daa374322cd5cd3 : SUCCESS in 7m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/181b4d5758d5439eb366ef5f2d365eac : SUCCESS in 4m 49s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b3ed8aeec19c43c28dd4622615c89c0b : SUCCESS in 31m 42s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/4d11479dee66420cbf8dabe655edd841 : SUCCESS in 1h 43m 01s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/95f7a61208544659a9f64e39b494aa6b : SUCCESS in 55m 09s","accounts_in_message":[],"_revision_number":1},{"id":"08119bfd2e11f405cdb639a0a0342556803c88d8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 02:36:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b164767dcb00ea804a26066f40c7ffd78857702e","revisions":{"b164767dcb00ea804a26066f40c7ffd78857702e":{"kind":"REWORK","_number":1,"created":"2019-09-21 04:09:59.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/54/683754/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/54/683754/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/54/683754/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/54/683754/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/54/683754/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/54/683754/1"}}},"commit":{"parents":[{"commit":"35e4628c6e06e80e6100bf906ab36e1df2d9e54a","subject":"py2/3: Stop using stdlib\u0027s putrequest(); it only does ASCII","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/35e4628c6e06e80e6100bf906ab36e1df2d9e54a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 17:59:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-21 04:05:03.000000000","tz":-420},"subject":"bufferedhttp: ensure query params are properly quoted","message":"bufferedhttp: ensure query params are properly quoted\n\nRecent versions of py27 [1] have begun raising InvalidURL if you try to\ninclude non-ASCII characters in the request path. This was observed\nrecently in the periodic checks of stable/ocata and stable/pike. In\nparticular, we would spin up some in-process servers in\ntest.unit.proxy.test_server.TestSocketObjectVersions and do a container\nlisting with a prefix param that included raw (unquoted) UTF-8. This\nquery string would pass unmolested through the proxy, tripping the\nInvalidURL error when bufferedhttp called putrequest.\n\nMore recent versions of Swift would not exhibit this particular failure,\nas the listing_formats middleware would force a decoding/re-encoding of\nthe query string for account and container requests. However, object\nrequests with errant query strings would likely be able to trip the same\nerror.\n\nSwift on py3 should not exhibit this behavior, as we so\nthoroughly re-write the request line to avoid hitting\nhttps://bugs.python.org/issue33973.\n\nNow, always parse and re-encode the query string in bufferedhttp. This\nprevents any errors on object requests and cleans up any callers that\nmight use bufferedhttp directly.\n\n[1] Anything after https://github.com/python/cpython/commit/bb8071a;\n    see https://bugs.python.org/issue30458\n\nCloses-Bug: 1843816\nChange-Id: I73f84b96f164e6fc5d3cb890355871c26ed271a6\nRelated-Change: Id3ce37aa0402e2d8dd5784ce329d7cb4fbaf700d\nRelated-Change: Ie648f5c04d4415f3b620fb196fa567ce7575d522\n(cherry picked from commit 49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b164767dcb00ea804a26066f40c7ffd78857702e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b164767dcb00ea804a26066f40c7ffd78857702e"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}