)]}'
{"id":"openstack%2Fswift~683756","triplet_id":"openstack%2Fswift~stable%2Fqueens~I73f84b96f164e6fc5d3cb890355871c26ed271a6","project":"openstack/swift","branch":"stable/queens","topic":"bug/1843816","hashtags":[],"change_id":"I73f84b96f164e6fc5d3cb890355871c26ed271a6","subject":"bufferedhttp: ensure query params are properly quoted","status":"MERGED","created":"2019-09-21 04:14:21.000000000","updated":"2019-09-24 23:40:58.000000000","submitted":"2019-09-24 23:40:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683756-1569368458588-d38e73ad","meta_rev_id":"640713537f34b4c4ae1f90b2922d7f4d4d21c678","_number":683756,"virtual_id_number":683756,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-24 23:40:58.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-22 03:53:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-22 03:53:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-24 23:40:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e806d9651c7dd7d54f926ac5e3be22490b4722ff","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-21 04:14:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"886ad5b4945ed6534ae3143e3256cfa61bce5213","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 05:45:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/4378062756964c30acfac91450eac81e : SUCCESS in 6m 52s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/f0ef2d1fb70443f7bd3b2d57d9cec633 : SUCCESS in 7m 20s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/48eabb59759942809905c7dd13a7b204 : SUCCESS in 3m 33s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/e3ea602e17704e0dbe0180b59593b71c : SUCCESS in 7m 01s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/ee48ba2db43442fbbcdb15ed67833c26 : SUCCESS in 9m 06s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/985d5f5b158044e590a88b1299588212 : SUCCESS in 7m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/40bab1f604ce4af8af5134ebcb41276c : SUCCESS in 4m 27s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/2d8d932bc6c84458adc64a3e9e741d4c : SUCCESS in 25m 43s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/16c5f31d713a4400bec08d4e1d2cc4e6 : SUCCESS in 1h 23m 26s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/985186ba645e43b9b122b43f215af22b : FAILURE in 58m 33s","accounts_in_message":[],"_revision_number":1},{"id":"a7a05b6a0fcb4ee452f1379f1613977350c11afa","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-21 16:17:06.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3c27cd66cb1d9aa3b10b40e8d40853089c8c10a2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 17:50:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/f28f18107a4241b782c53abf1d845927 : SUCCESS in 7m 09s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/feeb59160ad14885bec5f3fe4b269468 : SUCCESS in 6m 56s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/b32d3150097a4230bed336e2b4c1d4fa : SUCCESS in 3m 38s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/adf9c328463f413f8cf2c5191e52e083 : SUCCESS in 7m 57s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/526bf6e0b67043ba9081df20c40db4be : SUCCESS in 7m 51s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/41880891ebba4e6794b689cf6a661cec : SUCCESS in 7m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a84fa6a0706e4fbcac6f26b334df828b : SUCCESS in 4m 13s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/0f0514a039b54e4092fa0ae5d862d644 : SUCCESS in 25m 21s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/afb7fc45c00943ff8a9aaa9b4cd50b03 : SUCCESS in 1h 25m 31s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/0441b2c36edf4122bf4f1e638f82a605 : SUCCESS in 55m 18s","accounts_in_message":[],"_revision_number":1},{"id":"52de757faa7e530fbdc47da5d9c159007ea5f9e1","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-22 03:53:04.000000000","message":"Patch Set 1:\n\nStein\u0027s landed, rocky\u0027s making its way through the gate.","accounts_in_message":[],"_revision_number":1},{"id":"ff3f07bdf25d81eb781b1bd99b7e8e0e484eeb97","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-22 03:53:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8c98e1be8a22774bcf3626ba64469e34ac7e00e6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-22 03:54:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"da76024ed91463be56cf5edaf5292516f6f3c362","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-22 05:37:38.000000000","message":"Patch Set 1: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"a5bffd65ada70ce89a1dc21d1281fb958863a75c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 15:07:51.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"84174d0cb697c063051326534305097c1e1debab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:16:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/832e3276f1fa40babc2f37db67859dc9 : SUCCESS in 6m 11s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/eddc045113ab4758b7939afda1958b06 : SUCCESS in 7m 22s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/0b0c9f88308d4450a330d21cb1d09e27 : SUCCESS in 3m 39s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/341daa28c50b4db2a5a726a39d5b0dfe : SUCCESS in 7m 55s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/7a7a7ee8c14841e79e57f0699d3adf35 : SUCCESS in 13m 13s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/1bd3a4ad6a394b3b853e4067458b3477 : SUCCESS in 9m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04f399fb2e6b493a9afca4e10024067c : SUCCESS in 4m 48s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/064810d6da9a4379a79f5d6b7c33f0d4 : SUCCESS in 28m 35s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/e52e801df58c47a986a650db86bb1457 : SUCCESS in 1h 23m 02s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/5575a27d647344189df5ce899e650b7f : SUCCESS in 1h 09m 39s","accounts_in_message":[],"_revision_number":1},{"id":"1312af006ed254dd551ddce5730e83fea3b7f507","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:16:32.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ddb4e30c77345e345517c02a2e8f06c933598a0d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 23:57:23.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/cbb65f83143942f7bdb60fa12d7855e7 : SUCCESS in 6m 30s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/611a3d89c74d4b0bad5ce39daf304dce : SUCCESS in 8m 16s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/de3b98d5d0014cb0b6eaa9cf8adf63bc : SUCCESS in 4m 35s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/c7a3278682d549b0b5b3c2e9cf05fa92 : SUCCESS in 9m 24s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/99f55830ab394cd59a678b6ecf102492 : SUCCESS in 8m 50s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/eddb4650219043969b0fbc769b2aa54c : SUCCESS in 8m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b28670e88c154e2eb9d59e01d24789a4 : SUCCESS in 5m 50s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/6ce39da9c0284fea86eee6d21f460959 : SUCCESS in 24m 49s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/4ffe92320a3449eab12b6af6b3ea30d1 : FAILURE in 1h 17m 16s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/c7e75ee96e0545b9a407220ee3bd1c16 : SUCCESS in 59m 17s","accounts_in_message":[],"_revision_number":1},{"id":"a0881b35b058b5c1eae1eb99f85b09d7d1304057","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-24 15:04:40.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"b478c8494a3b61880d6e365d8deeac867cfd5da0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 20:41:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/57f09a9caba04668bca4a0553c2c34e1 : SUCCESS in 5m 56s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/e50fca2e0fd946cf84eebf743e8fee8f : SUCCESS in 15m 07s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/fe1dec387b46412db64a803399bb4b4c : SUCCESS in 4m 37s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/be237e362d764813bc4df9bc69a47954 : SUCCESS in 10m 11s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/78c8fb8806f048e8906945750a5486f7 : SUCCESS in 11m 29s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/db6c9c3d5388484d9dd9c0f2c6d070c0 : SUCCESS in 8m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a0c7dd55c264787be1842c4e84d8b54 : SUCCESS in 4m 26s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f3f42180cc31437fa0d7c70d0e92f2cf : SUCCESS in 32m 43s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/65c79395d8ab4c0eb158b94a6c5b669a : SUCCESS in 1h 39m 15s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/27550136afa04de5bacecbe245dc98cc : SUCCESS in 1h 09m 12s","accounts_in_message":[],"_revision_number":1},{"id":"61ceadd14f79b771a56e83155cc2f73bfa31f15d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 20:41:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ffec26c11de6f3534667c1615f3df0506b4911a8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 23:40:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/723c506b232945778fcc40e07eb8d93f : SUCCESS in 6m 40s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/22b2bdcea6f6477e8683b8a641e210b0 : SUCCESS in 8m 18s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/6948c112a49446f5aee14fd228c542ac : SUCCESS in 3m 54s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/b380c2da1f334a428d18e30e5846b385 : SUCCESS in 8m 26s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/7a113f807acc492186606550a52a34c5 : SUCCESS in 8m 02s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/0902abeee77f4569960731c6622b785d : SUCCESS in 10m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a5c388e0949148558742f311171a9663 : SUCCESS in 4m 27s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f6aee6871aa5437aa255a25be6a2ddf6 : SUCCESS in 26m 19s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/836f72aa12114039ba85c65d1b5f971d : SUCCESS in 1h 43m 31s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/b52329eaf1c6477db94a294d8457d631 : SUCCESS in 1h 07m 38s","accounts_in_message":[],"_revision_number":1},{"id":"9ac630a35ac7c537ab98ed62e4aafa553287e3bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 23:40:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a317d33dbcda3681a967ce1ed983020ff3512311","revisions":{"a317d33dbcda3681a967ce1ed983020ff3512311":{"kind":"REWORK","_number":1,"created":"2019-09-21 04:14:21.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/56/683756/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/56/683756/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/56/683756/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/56/683756/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/56/683756/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/56/683756/1"}}},"commit":{"parents":[{"commit":"7a40b4277b1efd5fa4468d14d795d69afe3f3da7","subject":"py2/3: Stop using stdlib\u0027s putrequest(); it only does ASCII","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7a40b4277b1efd5fa4468d14d795d69afe3f3da7"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-12 17:59:08.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-21 04:13:47.000000000","tz":-420},"subject":"bufferedhttp: ensure query params are properly quoted","message":"bufferedhttp: ensure query params are properly quoted\n\nRecent versions of py27 [1] have begun raising InvalidURL if you try to\ninclude non-ASCII characters in the request path. This was observed\nrecently in the periodic checks of stable/ocata and stable/pike. In\nparticular, we would spin up some in-process servers in\ntest.unit.proxy.test_server.TestSocketObjectVersions and do a container\nlisting with a prefix param that included raw (unquoted) UTF-8. This\nquery string would pass unmolested through the proxy, tripping the\nInvalidURL error when bufferedhttp called putrequest.\n\nMore recent versions of Swift would not exhibit this particular failure,\nas the listing_formats middleware would force a decoding/re-encoding of\nthe query string for account and container requests. However, object\nrequests with errant query strings would likely be able to trip the same\nerror.\n\nSwift on py3 should not exhibit this behavior, as we so\nthoroughly re-write the request line to avoid hitting\nhttps://bugs.python.org/issue33973.\n\nNow, always parse and re-encode the query string in bufferedhttp. This\nprevents any errors on object requests and cleans up any callers that\nmight use bufferedhttp directly.\n\n[1] Anything after https://github.com/python/cpython/commit/bb8071a;\n    see https://bugs.python.org/issue30458\n\nCloses-Bug: 1843816\nChange-Id: I73f84b96f164e6fc5d3cb890355871c26ed271a6\nRelated-Change: Id3ce37aa0402e2d8dd5784ce329d7cb4fbaf700d\nRelated-Change: Ie648f5c04d4415f3b620fb196fa567ce7575d522\n(cherry picked from commit 49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a317d33dbcda3681a967ce1ed983020ff3512311"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a317d33dbcda3681a967ce1ed983020ff3512311"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}