)]}'
{"id":"openstack%2Fswift~683757","triplet_id":"openstack%2Fswift~stable%2Focata~I4eafc5f057df8a3c15560ace255d05602db56ef6","project":"openstack/swift","branch":"stable/ocata","topic":"bug/1843816","hashtags":[],"change_id":"I4eafc5f057df8a3c15560ace255d05602db56ef6","subject":"Fix stable gate","status":"MERGED","created":"2019-09-21 04:19:17.000000000","updated":"2019-09-25 04:17:21.000000000","submitted":"2019-09-25 04:17:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683757-1569385041893-01c14357","meta_rev_id":"348ff920b64fef2a0036cca15873384234c88cdb","_number":683757,"virtual_id_number":683757,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-25 04:17:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-25 02:49:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-25 02:49:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-25 04:17:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3bbb1bc12e1a04edab7784a9bad6bec6af6126fd","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-21 04:19:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"955d50d4e85f6201f93790fbf0ac0a524a2affe4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-21 04:53:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/983dff5dd7ec4b9a839dfd1c3073f0c9 : SUCCESS in 6m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7cac7fee909a449584ef41b5d691a291 : SUCCESS in 3m 50s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/07971b914c624fe29c861536db175986 : SUCCESS in 32m 46s\n- swift-dsvm-functional-identity-v3-only https://zuul.opendev.org/t/openstack/build/8b718511972a4737a0661bd5c53581d5 : SUCCESS in 29m 02s (non-voting)\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/f59472d120b24906b7d1b13e342f7baa : FAILURE in 28m 50s","accounts_in_message":[],"_revision_number":1},{"id":"63b893cf4cda8552b7432309e2998a6048d5944a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 15:14:48.000000000","message":"Patch Set 1:\n\nrecheck\n\nAlso, I need to look at where our usual unit and func tests went -- I guess we need to backport https://opendev.org/openstack/swift/commit/dc1c55c9a07c03fe85f4bcc52419a42d75ae30fa","accounts_in_message":[],"_revision_number":1},{"id":"c92efc564b426d5bf0b894857e3935b97592830e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:13:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/4de0a2d8fbb84336bc97bbbea4443206 : SUCCESS in 5m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22069393b5f14303bca018b18a0a90fb : SUCCESS in 4m 33s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/72593ae50bc44683a458ef2b9e631117 : SUCCESS in 28m 04s\n- swift-dsvm-functional-identity-v3-only https://zuul.opendev.org/t/openstack/build/c2ac160d4aed4622ae3f5b9332e3bf1a : SUCCESS in 29m 55s (non-voting)\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/ada428c5fe5440f891a9a99612da131a : SUCCESS in 1h 23m 20s","accounts_in_message":[],"_revision_number":1},{"id":"c168ebcc1f6949c11b5412428bea6c598b6bde67","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-25 02:49:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6602aaafa1f001829d6b70c961aae77f14a5fd71","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 02:49:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9c3aeb7b3a2ddf523dfd9e7abd64a6e322caa62f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 04:17:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/abb51f669617454cbd56ab92087b3877 : SUCCESS in 8m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/06a82872196240c0b76ab76b10c41f4e : SUCCESS in 5m 10s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/db4388c17b7f4e2384c6f9edd9d385fa : SUCCESS in 21m 07s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/8d5c8954a7f74371bd2b7f32d71d8c65 : SUCCESS in 1h 24m 16s","accounts_in_message":[],"_revision_number":1},{"id":"66fdc983c0e6ab684ce54686a93476fb1def1af0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 04:17:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"53a6386791e3237e2a95db3a1a86a046b11e0664","revisions":{"53a6386791e3237e2a95db3a1a86a046b11e0664":{"kind":"REWORK","_number":1,"created":"2019-09-21 04:19:17.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/57/683757/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/57/683757/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/57/683757/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/57/683757/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/57/683757/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/57/683757/1"}}},"commit":{"parents":[{"commit":"23ab47e023af7350aa37c5701b62b4d61f3d07ec","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/23ab47e023af7350aa37c5701b62b4d61f3d07ec"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-03-12 20:36:21.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-21 04:14:40.000000000","tz":-420},"subject":"Fix stable gate","message":"Fix stable gate\n\nThis is a combination of 2 commits.\n\n---\n\npy2/3: Stop using stdlib\u0027s putrequest(); it only does ASCII\n\nNote that this only affects the functest client.\n\nSee also: https://bugs.python.org/issue36274 and\nhttps://bugs.python.org/issue38216\n\nThis was previously done just for py3 compatibility, but following\nhttps://github.com/python/cpython/commit/bb8071a our stable gates are\nall broken -- apparently, they\u0027re running a 2.7 pre-release?\n\n(cherry picked from commit c0ae48ba9aafb0b91869ea3bae8da07a32088777)\n(cherry picked from commit 2b4d58952cae8b174fb60529d5284c1d328e9287)\n\n---\n\nbufferedhttp: ensure query params are properly quoted\n\nRecent versions of py27 [1] have begun raising InvalidURL if you try to\ninclude non-ASCII characters in the request path. This was observed\nrecently in the periodic checks of stable/ocata and stable/pike. In\nparticular, we would spin up some in-process servers in\ntest.unit.proxy.test_server.TestSocketObjectVersions and do a container\nlisting with a prefix param that included raw (unquoted) UTF-8. This\nquery string would pass unmolested through the proxy, tripping the\nInvalidURL error when bufferedhttp called putrequest.\n\nMore recent versions of Swift would not exhibit this particular failure,\nas the listing_formats middleware would force a decoding/re-encoding of\nthe query string for account and container requests. However, object\nrequests with errant query strings would likely be able to trip the same\nerror.\n\nSwift on py3 should not exhibit this behavior, as we so\nthoroughly re-write the request line to avoid hitting\nhttps://bugs.python.org/issue33973.\n\nNow, always parse and re-encode the query string in bufferedhttp. This\nprevents any errors on object requests and cleans up any callers that\nmight use bufferedhttp directly.\n\n[1] Anything after https://github.com/python/cpython/commit/bb8071a;\n    see https://bugs.python.org/issue30458\n\nCloses-Bug: 1843816\nRelated-Change: Id3ce37aa0402e2d8dd5784ce329d7cb4fbaf700d\nRelated-Change: Ie648f5c04d4415f3b620fb196fa567ce7575d522\n(cherry picked from commit 49f62f6ab7fd1b833e9b5bfbcaafa4b45b592d34)\n(cherry picked from commit 9cc6d4138946034516fdf579ac084cb954ea6b06)\n\n---\n\nChange-Id: I4eafc5f057df8a3c15560ace255d05602db56ef6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/53a6386791e3237e2a95db3a1a86a046b11e0664"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/53a6386791e3237e2a95db3a1a86a046b11e0664"}]},"branch":"refs/heads/stable/ocata"}},"requirements":[],"submit_records":[],"submit_requirements":[]}