)]}'
{"id":"openstack%2Fswift~684041","triplet_id":"openstack%2Fswift~master~I70c125df70b2a703de44662adc66f740cc79c7a9","project":"openstack/swift","branch":"master","topic":"bug/1840507","hashtags":[],"change_id":"I70c125df70b2a703de44662adc66f740cc79c7a9","subject":"Fix some request-smuggling vectors on py3","status":"MERGED","created":"2019-09-23 17:48:33.000000000","updated":"2019-10-02 23:10:58.000000000","submitted":"2019-10-02 23:09:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"684041-1570057788756-4cdd5882","meta_rev_id":"fadc0f1df3b78ba78c73d6ffa926fcba7a1a21e2","_number":684041,"virtual_id_number":684041,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-02 23:09:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-02 19:22:38.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":2,"date":"2019-10-02 15:47:14.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2019-10-02 18:29:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2019-10-02 18:29:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-02 06:32:40.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2019-10-02 15:47:14.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2019-10-02 18:29:26.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-10-02 23:09:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d615c0e8df6c47b3d0c212515dcf842bb484f1c5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 17:48:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6dffb5925ec3a0baaa81fb4c208fba7b3a1d8a9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:50:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/770229b17d1b4d0591a777c83f547f96 : SUCCESS in 5m 42s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/05d069f4318746bfad502a28a595f685 : SUCCESS in 1h 13m 56s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/595937dd7d74416bbee0830e403673da : SUCCESS in 54m 02s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/91078532a9fe488a87ff6b77cc13a9ff : SUCCESS in 7m 34s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/23078e233f98460d9057b0c7834f08f3 : SUCCESS in 11m 27s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/94e69610850348d4b5354c3d0013c8e5 : SUCCESS in 24m 03s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/2d748f8a84d54b60b49e28d9ec856911 : SUCCESS in 12m 44s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/802a9e15c5434da4bd5fe20a0192685e : SUCCESS in 11m 02s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/cf5cf3bb64354fc5a3a30bfc0099ecd9 : SUCCESS in 9m 17s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/2b1169ac99854cb993499b787c3c3779 : SUCCESS in 10m 00s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/2cb104ddbfc1499abb827a9dcaa3debe : SUCCESS in 11m 22s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/b0e09dc7eacb4b9a849482fefceb63fe : SUCCESS in 12m 52s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/fcffeaf71d714766ba71f8e9c50c8e8a : SUCCESS in 9m 00s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/59ffe3b1355440a3bf3973d2aa13c373 : SUCCESS in 10m 16s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/0df90134dffd4631b2d476b6f0aaef25 : SUCCESS in 9m 04s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/8751fbf78e424ed7b6320a468eaad494 : SUCCESS in 11m 38s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/40483b2731db41068cde43ac810b4088 : SUCCESS in 13m 00s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/e5ce1bbfd6ac40928f8b74afc48775d9 : SUCCESS in 13m 33s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/4e960e07a5b94623ac40a5d1f5152b3c : SUCCESS in 30m 09s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9e517bf0088f46b3a6d1a4e67acd3219 : SUCCESS in 47m 16s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/c207fd6a83cc4bd09bd9ddadd28f8e5d : SUCCESS in 30m 03s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/5518ce60e01042d2b955e7793a114f20 : SUCCESS in 29m 21s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c4c413d62488446ab6b8b08ace65b8a8 : SUCCESS in 13m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad9d74bd8b884b9e87a8b75fd531f457 : SUCCESS in 5m 47s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/9fe56198269f4c12903a30f6c4f01191 : FAILURE in 33m 51s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8113e8fe6e2c4f7b9978afa4cdfb8919 : SUCCESS in 1h 18m 00s","accounts_in_message":[],"_revision_number":1},{"id":"0b610c103efff388e9ef54b502b1c760d204f7c5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-23 21:30:41.000000000","message":"Patch Set 1:\n\nrecheck\n\nLooks like a container-update timout.","accounts_in_message":[],"_revision_number":1},{"id":"25eeeaa9411563a47f3cffa463eacd14c70710c8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 22:47:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a82ce641116d45c1b8e10f2bab8aa8f1 : SUCCESS in 5m 44s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/405b596adda54384b7dd22043a21c1a1 : SUCCESS in 1h 09m 17s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/dfc71f7503b744d881e5fcd380c66be6 : SUCCESS in 57m 52s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/4bd692b42daa4dc28420a71b404d3a8e : SUCCESS in 9m 32s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/42e64311a8804eaa9e0de88134bcf2bc : SUCCESS in 15m 35s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/9180dd64374a4f5ea1265d2b248b84ca : SUCCESS in 14m 21s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/be485c137ed6411cafd5146c8ac5857e : SUCCESS in 16m 20s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/c49aa88127264d6a9dad637858023f7e : SUCCESS in 9m 55s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/a4cbfc594a4841f6b511bf58e9b83489 : SUCCESS in 10m 01s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/b77005d0004d41649c38cca1b6b8bb1e : SUCCESS in 10m 11s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/166f53e510ea4fb6b0f40a710bc310b6 : SUCCESS in 10m 23s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/0720e8b79d4d45e6b8ddb7fc7a58c971 : SUCCESS in 13m 16s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/eee2b40514e140a3b0572a280b5b4228 : SUCCESS in 10m 23s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/72d66aaa24854874a0095998f2ec9d8d : SUCCESS in 10m 25s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/19c99a03f2934bffa2aa424b479e043b : SUCCESS in 10m 35s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/d6ce3b1f64d746f38ca6fbfd771da25d : SUCCESS in 11m 13s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/499eecb221794b0ca72e9551beecd29a : SUCCESS in 13m 30s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/4b714965b93f42fea3c1290a3b37fe98 : SUCCESS in 13m 07s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/208d7f3691d14081aecf3f8e298f5849 : SUCCESS in 36m 09s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/572a2ed2c3a14667b002a413b2864267 : SUCCESS in 32m 40s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/d49b27a1651847dc92b62a86c61cc55b : SUCCESS in 33m 12s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/dd5c41d5c416452c9dc05654f12c16cc : SUCCESS in 32m 59s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/284f645079674a7f9b1cc319c592a1bd : SUCCESS in 14m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1f850855c47f4979947967c0f4dc2d39 : SUCCESS in 6m 01s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/605ac92934444a0eadc168393a0e9551 : SUCCESS in 16m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ce56b29aa9e34a0c92589067b1df6761 : SUCCESS in 1h 10m 36s","accounts_in_message":[],"_revision_number":1},{"id":"e98546440d03e146c776833e14dc4f0d9c7d7426","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-09-26 01:51:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"38700ac824f3b9340c314a99eb083328793c3e0f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-26 16:13:04.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1d3ad8a49e7ec5af3432f242fea59ea75ff4046a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-26 16:27:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"19dd978bd8729e0293abf0e5f2de73668db59b0d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 19:18:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/da1340553fa348b78730e34d06892665 : SUCCESS in 5m 14s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/27758cbe83034957afd510a580678ef0 : SUCCESS in 1h 21m 15s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/a0c133fdcbcd4062bac51b1cac5b4409 : SUCCESS in 1h 16m 56s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b81d0eb8724c482fb140969d96f10146 : SUCCESS in 13m 17s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/9a026e3be9c44eb7b0dcb2d2cc2711a6 : SUCCESS in 35m 17s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/100864658dda442482d07b040e367123 : SUCCESS in 10m 52s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/886add2bb19345de8d8b8a178dd2ce62 : SUCCESS in 16m 13s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/38a091911f614ab287120bd3bb7b83a4 : SUCCESS in 29m 42s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/e7a073e272714c86b180324e2c9252db : SUCCESS in 21m 03s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/587e2e0026bf4eccaefc1127c4f323c6 : SUCCESS in 8m 58s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/eddaf76e741846c58fcfa8b8c6463664 : SUCCESS in 10m 08s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/95149146c4d94458a287b0e596e6105d : SUCCESS in 13m 23s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/df56c44fec804231b6d00a67daa8d72f : SUCCESS in 22m 39s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/3b5d0769966c4d2793e4c69ce181c7ba : SUCCESS in 12m 54s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/4c4bebabf5a24a28897c6ce75a97003c : SUCCESS in 10m 31s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/0a5336f05656416ea1380967b94ffaf2 : SUCCESS in 12m 22s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/605c2ab9b36e4b7e924fa2bc602c9c8e : SUCCESS in 13m 56s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/261e6703cff44495a75f0b624e7c8ea0 : SUCCESS in 17m 12s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/92ea89703e774e8faf04d1e8f172ddd9 : SUCCESS in 30m 24s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/80bae5862b7444a4b84b695bd88869ff : SUCCESS in 26m 44s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/15544337f7dd407da6dbf06d2f1ce6fb : SUCCESS in 27m 09s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/048b177cd59b470ca114d8619d4d5ee3 : SUCCESS in 33m 41s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/793eb6b489b7413e9d53e90a6b3b25c0 : SUCCESS in 13m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/edd416fcfdfe48ee9e3d72a40c535e98 : SUCCESS in 7m 56s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/338375520c1d447ca908517a283ceb4c : SUCCESS in 16m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/cb70945634a8487bb3ac7f50eb2a8817 : SUCCESS in 1h 21m 10s","accounts_in_message":[],"_revision_number":2},{"id":"faab3f7e3662579c5ac08749af85e46913123bc5","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-09-26 21:56:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2f3791efbc302ca0771664cf3fc08cb8a5f22798","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-09-27 03:57:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9078c9f9ba78847dde80996d2b65415134b68a37","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-09-27 04:37:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6555de239fdce5b1884146d595a05ccb27b7f5a8","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2019-10-02 06:32:40.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI might have failed at looking, but I didn\u0027t see a test for the removal of the context-length header when the request is chunked in the proxy server. Or at least an assert that it\u0027s missing from the request.","accounts_in_message":[],"_revision_number":2},{"id":"f0772114093931581c2f6ccc218141e7d8808049","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-02 15:20:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1c06abd4f0ea443fd687503b1da947719eb66eb2","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-02 15:21:22.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7342fb3caee79f41d00a78ce85979cac381f901a","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-10-02 15:47:14.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"dbea4468142c6d2071a9c3f281b63fa75827a26c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 18:28:04.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/89b84481588a491ca00478c925336e10 : SUCCESS in 5m 00s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/26071883e1e0486fa013c553b0fcc2d7 : SUCCESS in 1h 15m 01s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/63e132c7a0ed4a8b86b2b1f857b9c3ce : SUCCESS in 54m 46s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/8f026faf6e3b466bb112c6f858f433d5 : SUCCESS in 8m 40s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/ccdc9bfbaeb94c64b7fcc4d7920c6d74 : SUCCESS in 12m 31s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/ceb1bcbd19b04cfd9f1af301b8d02a01 : SUCCESS in 12m 16s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/817229b8a26e488db372334e079a0374 : SUCCESS in 11m 37s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/18462b8fd3b84f3580e873c9bf69ea82 : SUCCESS in 9m 57s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/37a4fdc7dd52447da1eaa9185e5f2c82 : SUCCESS in 16m 57s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/8777353c02e14d93b8984953d14cdcb2 : SUCCESS in 18m 04s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/dfc547242ad549c0ad6185343d6acccf : SUCCESS in 16m 28s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/8ae905edc3bd49be91888fcc114d8d11 : SUCCESS in 17m 26s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/21375a438f2d4f01a96226208f0860e7 : SUCCESS in 15m 23s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/cf6f2596b73c40a095a6661521e2b199 : SUCCESS in 9m 44s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/8985a7e5e0be4e01951b984aa1addb44 : SUCCESS in 18m 35s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/7d7bed8358a84c0cab00081dcbb19b50 : SUCCESS in 9m 58s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/54e0ee8d2dbd4ed786d35f5889bd6cb8 : SUCCESS in 22m 37s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/3bcad94cee5c4ae394b8e3bf6f4f9e9e : SUCCESS in 22m 16s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/7864c19f560d4544818df56f5b3d23b0 : FAILURE in 39m 18s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a0e53c44ba324f3cab9b748869e121fe : SUCCESS in 49m 46s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/8b022fc6ff9b485abc2e16e3cfc7a6ec : SUCCESS in 29m 36s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/9767233418ec406f89b08facd5952004 : SUCCESS in 32m 03s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9415deafc26d4a48bff462fdc73eec5f : SUCCESS in 12m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6d30a844564642dbbeac6603bde15334 : SUCCESS in 5m 28s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/727da4b0d01f4d5cb631d70be7e34272 : FAILURE in 26m 03s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/297cbad06bd046438cfe289ab5e5003b : SUCCESS in 1h 10m 04s","accounts_in_message":[],"_revision_number":3},{"id":"b994eb7b6f5161e76e15706c3d2b83b5daaa7c37","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-10-02 18:29:26.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(5 comments)\n\nsorry it took me so long to approve this, I get a little side tracked once I start grokking some of the hoops we had to jump through for py3","accounts_in_message":[],"_revision_number":3},{"id":"281a39d51ca5aebf327633fcbb24e18c75e82133","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-02 19:22:38.000000000","message":"Patch Set 3:\n\n(3 comments)\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"66d12fa50526f0ac605a9a2a1b3d8aca75d8fa95","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 20:29:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d5bb20ff8eb411bb53c434071cdd2bd : SUCCESS in 5m 55s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/ff19a0993fb9493c9ee39f86cf0df14e : SUCCESS in 59m 52s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/b295e703e7ea4a04a8dac7e99ff55c3b : SUCCESS in 53m 09s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/7d0d74245758469abce2f94a0f297a26 : SUCCESS in 8m 20s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/7921966913bb491ca85c09374f09aca3 : SUCCESS in 12m 29s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/6ef78469c38442ba9d0fc846341eb06f : SUCCESS in 12m 36s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/0e1ea92093c5478198cc821295b2d165 : SUCCESS in 12m 00s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/ec1d1f7be68f4c2b9e249b67240a6931 : SUCCESS in 11m 14s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/7378be50da94436aad1cc95717fecd78 : SUCCESS in 22m 31s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/81620d2445b2450b8aae44fe5f7a5bd4 : SUCCESS in 13m 38s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/7b842cb09aeb4494bd02123288006eb0 : SUCCESS in 20m 34s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/24a6bd26102b4ef18f9b446fcbcafad8 : SUCCESS in 21m 13s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/8197c876f4084b5b9452a8c98c999fb6 : SUCCESS in 10m 44s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/0f26ca6b8579466eb41c48fedc10a994 : SUCCESS in 12m 19s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/ece6ce303f674843ab4f4a091e98c9de : SUCCESS in 12m 10s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/2805f37e610349448ca5e71777577d2b : SUCCESS in 11m 37s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/3f468f9b2bcd43ee8ee5ec500fd98602 : SUCCESS in 26m 23s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/5ab37901af0641cfba5e32170b26eb1c : SUCCESS in 28m 50s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/8a1b30cb3e734fc8b399647de50b6837 : SUCCESS in 37m 02s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b042dcc4d96f42ccb3b93419b3017b0a : SUCCESS in 37m 39s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/3c32496ee1d34c4e88dac179e8407786 : SUCCESS in 49m 10s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/4a85fae2ca4d4ce6a55fe4a5c1dccf2a : SUCCESS in 32m 24s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a985ae214769470e8a83cf8731b14550 : SUCCESS in 12m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/94d5d836eea1437986479de7bce739fd : SUCCESS in 5m 14s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/d1929462b9614acc8f39b383d3395dca : SUCCESS in 18m 16s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dff32a7094a440a88f7d6f209b438c6e : SUCCESS in 1h 19m 08s","accounts_in_message":[],"_revision_number":3},{"id":"57633f2aeb8b7a38b006ade48142b3b317199e0a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 20:29:21.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"b670a790fc1209ff21d334f2a59fa4a0e5364cf7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 23:09:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"cade092df665c65ae526d5f9e5ea7ffc59df5326","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 23:09:48.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1e2bda73279943edb8a33e7c1b546b01 : SUCCESS in 7m 12s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/53585933d1a040be87bcf506fb2e7297 : SUCCESS in 1h 03m 28s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/00e9500084244b5b8b6ec4ab25efbd55 : SUCCESS in 1h 05m 25s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/60634fad0a00468bbd2ac9ff0a5608d7 : SUCCESS in 10m 28s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/3e6271bd4a0a40c58c888241df8db940 : SUCCESS in 13m 11s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/75a7e30ff08b47f59080d36d8c3891a0 : SUCCESS in 14m 37s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/ee62732e398e4868a2d68ca000c1d147 : SUCCESS in 11m 32s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/a5672b44b7484be7aba1d5e166477245 : SUCCESS in 12m 06s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/096c74ad43ed4cf6b6acaa9754282529 : SUCCESS in 10m 44s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/d5ad1f6a6ce6456c99a5d2a82fdd3caf : SUCCESS in 14m 01s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/a982af7103b541c6bece1a390163f80c : SUCCESS in 9m 44s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/5435c8816bdf4890904dab66580d6a6b : SUCCESS in 14m 00s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/36006499541a47c493e7d3c13f2da03a : SUCCESS in 19m 59s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/fadecb9569d848a8bf15449f9bb159fd : SUCCESS in 9m 15s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/328c783d13434a53badb48831d9d6eee : SUCCESS in 12m 37s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/99a36328a433471da53b90fead65c8a7 : SUCCESS in 12m 37s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/c6c889d892bb4ce4aaf225c2de6cba27 : SUCCESS in 32m 34s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/28d9fbf52cfd42ecb53981e5d6db894c : SUCCESS in 30m 46s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/3e980f3426b144fea9a96d9ed1d12aae : SUCCESS in 31m 19s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/56c18871114e4b0687899f3759cfd22d : SUCCESS in 33m 27s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/41dc347d073d48bc8b9e27dea60c4ad3 : SUCCESS in 13m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/61eb4396f02441ed83ce8ab4a4384a56 : SUCCESS in 5m 46s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4ead2dd5e94442cd84990bf9946627bb : SUCCESS in 1h 05m 59s","accounts_in_message":[],"_revision_number":3},{"id":"a2599709143a3ae2d0b8c8fe80f87be80816300b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 23:10:58.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6cd91381b8a54271910c9ec69139dc59 : SUCCESS in 51s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/b58c8c54f42b4baaa8cb360710206a2c : SUCCESS in 46s (non-voting)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"bf9346d88de2aeb06da3b2cde62ffa6200936367","revisions":{"61a49bec1ff69c60d14a5d94da3da4e849f28a31":{"kind":"REWORK","_number":1,"created":"2019-09-23 17:48:33.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/41/684041/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/41/684041/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/41/684041/1"}}},"commit":{"parents":[{"commit":"2abdd2d70d6ab946e35bd5f32e387d5cfd59da3c","subject":"Merge \"bufferedhttp: ensure query params are properly quoted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2abdd2d70d6ab946e35bd5f32e387d5cfd59da3c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-08-15 21:33:06.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-23 17:46:38.000000000","tz":-420},"subject":"Fix some request-smuggling vectors on py3","message":"Fix some request-smuggling vectors on py3\n\nA Python 3 bug causes us to abort header parsing in some cases. We\nmostly worked around that in the related change, but that was *after*\neventlet used the parsed headers to determine things like message\nframing. As a result, a client sending a malformed request (for example,\nsending both Content-Length *and* Transfer-Encoding: chunked headers)\nmight have that request parsed properly and authorized by a proxy-server\nrunning Python 2, but the proxy-to-backend request could get misparsed\nif the backend is running Python 3. As a result, the single client\nrequest could be interpretted as multiple requests by an object server,\nonly the first of which was properly authorized at the proxy.\n\nNow, after we find and parse additional headers that weren\u0027t parsed by\nPython, fix up eventlet\u0027s wsgi.input to reflect the message framing we\nexpect given the complete set of headers. As an added precaution, if the\nclient included Transfer-Encoding: chunked *and* a Content-Length,\nensure that the Content-Length is not forwarded to the backend.\n\nChange-Id: I70c125df70b2a703de44662adc66f740cc79c7a9\nRelated-Change: I0f03c211f35a9a49e047a5718a9907b515ca88d7\nCloses-Bug: 1840507\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/61a49bec1ff69c60d14a5d94da3da4e849f28a31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/61a49bec1ff69c60d14a5d94da3da4e849f28a31"}]},"branch":"refs/heads/master"},"ee405685c1ad6b50bd75df18064385fa77281953":{"kind":"REWORK","_number":2,"created":"2019-09-26 16:27:59.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/41/684041/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/41/684041/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/41/684041/2"}}},"commit":{"parents":[{"commit":"2abdd2d70d6ab946e35bd5f32e387d5cfd59da3c","subject":"Merge \"bufferedhttp: ensure query params are properly quoted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2abdd2d70d6ab946e35bd5f32e387d5cfd59da3c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-08-15 21:33:06.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-09-26 16:26:28.000000000","tz":-420},"subject":"Fix some request-smuggling vectors on py3","message":"Fix some request-smuggling vectors on py3\n\nA Python 3 bug causes us to abort header parsing in some cases. We\nmostly worked around that in the related change, but that was *after*\neventlet used the parsed headers to determine things like message\nframing. As a result, a client sending a malformed request (for example,\nsending both Content-Length *and* Transfer-Encoding: chunked headers)\nmight have that request parsed properly and authorized by a proxy-server\nrunning Python 2, but the proxy-to-backend request could get misparsed\nif the backend is running Python 3. As a result, the single client\nrequest could be interpretted as multiple requests by an object server,\nonly the first of which was properly authorized at the proxy.\n\nNow, after we find and parse additional headers that weren\u0027t parsed by\nPython, fix up eventlet\u0027s wsgi.input to reflect the message framing we\nexpect given the complete set of headers. As an added precaution, if the\nclient included Transfer-Encoding: chunked *and* a Content-Length,\nensure that the Content-Length is not forwarded to the backend.\n\nChange-Id: I70c125df70b2a703de44662adc66f740cc79c7a9\nRelated-Change: I0f03c211f35a9a49e047a5718a9907b515ca88d7\nCloses-Bug: 1840507\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ee405685c1ad6b50bd75df18064385fa77281953"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ee405685c1ad6b50bd75df18064385fa77281953"}]},"branch":"refs/heads/master"},"bf9346d88de2aeb06da3b2cde62ffa6200936367":{"kind":"REWORK","_number":3,"created":"2019-10-02 15:20:36.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/41/684041/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/41/684041/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/41/684041/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/41/684041/3"}}},"commit":{"parents":[{"commit":"2abdd2d70d6ab946e35bd5f32e387d5cfd59da3c","subject":"Merge \"bufferedhttp: ensure query params are properly quoted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2abdd2d70d6ab946e35bd5f32e387d5cfd59da3c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-08-15 21:33:06.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-10-02 15:20:20.000000000","tz":-420},"subject":"Fix some request-smuggling vectors on py3","message":"Fix some request-smuggling vectors on py3\n\nA Python 3 bug causes us to abort header parsing in some cases. We\nmostly worked around that in the related change, but that was *after*\neventlet used the parsed headers to determine things like message\nframing. As a result, a client sending a malformed request (for example,\nsending both Content-Length *and* Transfer-Encoding: chunked headers)\nmight have that request parsed properly and authorized by a proxy-server\nrunning Python 2, but the proxy-to-backend request could get misparsed\nif the backend is running Python 3. As a result, the single client\nrequest could be interpretted as multiple requests by an object server,\nonly the first of which was properly authorized at the proxy.\n\nNow, after we find and parse additional headers that weren\u0027t parsed by\nPython, fix up eventlet\u0027s wsgi.input to reflect the message framing we\nexpect given the complete set of headers. As an added precaution, if the\nclient included Transfer-Encoding: chunked *and* a Content-Length,\nensure that the Content-Length is not forwarded to the backend.\n\nChange-Id: I70c125df70b2a703de44662adc66f740cc79c7a9\nRelated-Change: I0f03c211f35a9a49e047a5718a9907b515ca88d7\nCloses-Bug: 1840507\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/bf9346d88de2aeb06da3b2cde62ffa6200936367"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/bf9346d88de2aeb06da3b2cde62ffa6200936367"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
