)]}'
{"swift/common/middleware/crypto/keymaster.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"42a9df171a928a5293dd45894c34ab937f96a730","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            raise UnknownSecretIdError(secret_id)"},{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            if not isinstance(key, bytes):"},{"line_number":296,"context_line":"                key \u003d key.encode()"},{"line_number":297,"context_line":"            return hmac.new(key, wsgi_to_bytes(path),"},{"line_number":298,"context_line":"                            digestmod\u003dhashlib.sha256).digest()"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f3daf3e6","line":296,"updated":"2019-10-11 13:27:16.000000000","message":"It\u0027s fine for what it is, plugging a hole, but is it how the code is supposed to work? There is comment below that specifies _root_secrets to contain bytes.","commit_id":"d1f0c674c0429eca2aa15a569a129830a3399b34"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"fcff5f45bfedc94f03fe71e24a14a4feec1fed6a","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            raise UnknownSecretIdError(secret_id)"},{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            if not isinstance(key, bytes):"},{"line_number":296,"context_line":"                key \u003d key.encode()"},{"line_number":297,"context_line":"            return hmac.new(key, wsgi_to_bytes(path),"},{"line_number":298,"context_line":"                            digestmod\u003dhashlib.sha256).digest()"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_eabd15b7","line":296,"in_reply_to":"3fa7e38b_f3daf3e6","updated":"2019-10-11 16:35:11.000000000","message":"It probably says that, though that\u0027s not what I experienced, see the linked bug report. If you have a better fix, please do propose it.","commit_id":"d1f0c674c0429eca2aa15a569a129830a3399b34"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"42a9df171a928a5293dd45894c34ab937f96a730","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :return: a dict mapping secret ids to encryption root secret binary"},{"line_number":329,"context_line":"            bytes"},{"line_number":330,"context_line":"        :rtype: dict"},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":"        root_secrets \u003d {}"},{"line_number":333,"context_line":"        for opt, secret_id, value in self._load_multikey_opts("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9367ff4d","line":330,"updated":"2019-10-11 13:27:16.000000000","message":"See, it says bytes.","commit_id":"d1f0c674c0429eca2aa15a569a129830a3399b34"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"fcff5f45bfedc94f03fe71e24a14a4feec1fed6a","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :return: a dict mapping secret ids to encryption root secret binary"},{"line_number":329,"context_line":"            bytes"},{"line_number":330,"context_line":"        :rtype: dict"},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":"        root_secrets \u003d {}"},{"line_number":333,"context_line":"        for opt, secret_id, value in self._load_multikey_opts("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_aab39de8","line":330,"in_reply_to":"3fa7e38b_9367ff4d","updated":"2019-10-11 16:35:11.000000000","message":"See above.","commit_id":"d1f0c674c0429eca2aa15a569a129830a3399b34"}]}