)]}'
{"id":"openstack%2Fswift~689583","triplet_id":"openstack%2Fswift~stable%2Fstein~Ide5af2ae68fae0e5d6eb5c233a24388bb9942144","project":"openstack/swift","branch":"stable/stein","hashtags":[],"change_id":"Ide5af2ae68fae0e5d6eb5c233a24388bb9942144","subject":"Fix invalid assert states","status":"MERGED","created":"2019-10-18 20:46:29.000000000","updated":"2019-10-18 23:01:58.000000000","submitted":"2019-10-18 23:00:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"689583-1571439618513-e873c77d","meta_rev_id":"678c527921e904951cd05e277ab25d6325c31fad","_number":689583,"virtual_id_number":689583,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-18 23:00:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":2,"date":"2019-10-18 21:26:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-18 20:46:29.000000000","_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":1,"date":"2019-10-18 21:26:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-18 20:46:29.000000000","updated_by":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"reviewer":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"state":"REVIEWER"},{"updated":"2019-10-18 23:00:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8968efd02b090cfda384e5c26ae4f0be980cdbb7","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-18 20:46:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3cf133e8729d2a74cef5612507b36a4fb7ee276b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 21:23:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a28a867112f240d9a9403a68c27d7aff : SUCCESS in 4m 29s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/186e3fec30ff45278e9e5ec6daab52a8 : SUCCESS in 11m 30s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/9dd1c02e32024defb0f7298368fa683e : SUCCESS in 7m 19s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/2786331393884c8dbed49a941611bb5f : SUCCESS in 8m 15s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/879e2eb7cd7b4c1f826d21e43171d597 : SUCCESS in 8m 03s (non-voting)\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/5799fbc218514ecd9acd5ba643a33932 : SUCCESS in 10m 01s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/1ff6fb567aef41778f441e8fae3607ec : SUCCESS in 9m 51s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/1f741b4a13eb43ce81401f0465820505 : SUCCESS in 8m 55s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/e9d439d313c2441ab315bc6a066326f7 : SUCCESS in 9m 21s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/739a900ef26047a29be234aebad63cd9 : SUCCESS in 10m 52s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/376d8dd0b5ba497db8db2a8c59fbe959 : SUCCESS in 29m 18s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/ec2f4fe099c5462e811419ecb655ae7b : SUCCESS in 31m 21s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/86388077bb7d4316ab620494e52d2433 : SUCCESS in 10m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0c37302e815641089d459b9ed50f8d73 : SUCCESS in 5m 32s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/2b587f49f87b436f9a74c9cfcd2e64bd : FAILURE in 16m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4713bce4c5b60f0725ecebcc2d4e8ede90acecb5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-18 21:26:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nTest-only, clean backport, and those were demonstrably-wrong assertions. Ship it!","accounts_in_message":[],"_revision_number":1},{"id":"aeb95ae3ad11ebbf194749a3a99313c74895624e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 21:27:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"038bb35711f16324719263a8a6f273d25a9dc1cd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 23:00:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bab0f730c846413f9a92406b9538192c : SUCCESS in 4m 51s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/284362a67f7a43aeb43e3a55c9490067 : SUCCESS in 10m 20s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/105087aeb98946a1a3c63a29078f1a26 : SUCCESS in 8m 00s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/fbafd1353c2c48bfa313d40abdd36f98 : SUCCESS in 12m 00s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/87c12298b1c5405c8c77e0ef23db4a01 : SUCCESS in 10m 09s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/02bb424b280b4cfcaba5cb06d05e4933 : SUCCESS in 10m 25s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/c6f149577aad47a8b958ef292f42fc50 : SUCCESS in 12m 59s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/39335697a6604ae0b756a1a0997847ef : SUCCESS in 14m 22s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/540b7b5fe84843c8a444a41667f0d395 : SUCCESS in 27m 43s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/cb148bae7eca40c5b57a91ec0a2f9b9d : SUCCESS in 28m 21s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/30d32d9a7a9642cb911c35776ccf26cb : SUCCESS in 9m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c100adacbbd74aefb991dc2a8fbd4dfe : SUCCESS in 5m 55s","accounts_in_message":[],"_revision_number":1},{"id":"63fa4e7303b51b22eceb0f75318de7d2f14ea9ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 23:00:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"678c527921e904951cd05e277ab25d6325c31fad","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 23:01:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0cef223de9444213aac4f75e52055fb3 : SUCCESS in 1m 21s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"60bcf8f548de308a27b57a3cc6619ef5f6af78ae","revisions":{"60bcf8f548de308a27b57a3cc6619ef5f6af78ae":{"kind":"REWORK","_number":1,"created":"2019-10-18 20:46:29.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/83/689583/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/83/689583/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/689583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/689583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/689583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/83/689583/1"}}},"commit":{"parents":[{"commit":"3d5f7aa41db7dd06e0965bd7494f2b23e7caf3f3","subject":"Merge \"doc: Fix the swift middleware doc needs more info  to set s3 api\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/3d5f7aa41db7dd06e0965bd7494f2b23e7caf3f3"}]}],"author":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2019-07-03 08:41:38.000000000","tz":480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-10-18 20:46:16.000000000","tz":-420},"subject":"Fix invalid assert states","message":"Fix invalid assert states\n\nThis is to fix invalid assert states like:\n    self.assertTrue(\u0027sync_point2: 5\u0027, lines.pop().strip())\n    self.assertTrue(\u0027sync_point1: 5\u0027, lines.pop().strip())\n    self.assertTrue(\u0027bytes: 1100\u0027, lines.pop().strip())\n    self.assertTrue(\u0027deletes: 2\u0027, lines.pop().strip())\n    self.assertTrue(\u0027puts: 3\u0027, lines.pop().strip())\n    self.assertTrue(\u00271\u0027, jobs_to_delete[0][\u0027partition\u0027])\nin which assertEqual should be used.\n\nChange-Id: Ide5af2ae68fae0e5d6eb5c233a24388bb9942144\n(cherry picked from commit 0fec28ab155276d099d1d4c9fd377f3da539077b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/60bcf8f548de308a27b57a3cc6619ef5f6af78ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/60bcf8f548de308a27b57a3cc6619ef5f6af78ae"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}