)]}'
{"id":"openstack%2Fswift~690619","triplet_id":"openstack%2Fswift~stable%2Frocky~I023b8a46c06e9a2755b5aa890a7992ef9633cba9","project":"openstack/swift","branch":"stable/rocky","topic":"690618","hashtags":[],"change_id":"I023b8a46c06e9a2755b5aa890a7992ef9633cba9","subject":"sharding: better handle get_shard_ranges failures","status":"MERGED","created":"2019-10-23 15:59:46.000000000","updated":"2019-10-25 10:28:36.000000000","submitted":"2019-10-25 10:28:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690619-1571999316146-cd6aae0a","meta_rev_id":"bb564425e02ac4300100cf24f14dc611a7ba6d0f","_number":690619,"virtual_id_number":690619,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-25 10:28:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-23 17:28:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-23 17:28:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-25 10:28:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"934f51efdc9189ab4b0ac5f4ad5bfd52190faf03","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 15:59:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"29cdaeba031ffa90e5e657023a700353ac2f2c92","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 17:27:17.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"4a7936a496d40fdd0d77a36133de227682cbe0d1","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 17:28:11.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nClean backport; maybe should\u0027ve squashed it in with the parent patch, as it makes such failures more likely to occur in practice.","accounts_in_message":[],"_revision_number":2},{"id":"2dacb4b4b3387d1fb290c4164b6d9d5a2b71ccdd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 20:15:27.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/5566fbceb43a401699c6d85aee2ad6c0 : SUCCESS in 4m 58s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/68c4a24e06af4c1aa9dda299e1fccc3a : SUCCESS in 16m 09s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/7044f59c6bc3474b9fdf42b28c3f68e7 : SUCCESS in 7m 40s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/db3c633d0218495ba930799a9198d152 : SUCCESS in 11m 11s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/bc01fd6323764972b299588f2ff5f1fe : FAILURE in 10m 20s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/6c37a444fe174107938bc65b02b47e05 : SUCCESS in 8m 21s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/b9ce4d0cf55141e6a64657474b921bb1 : SUCCESS in 10m 32s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/61060076a393493097366fa2393b8bed : SUCCESS in 9m 02s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a401a563c9ed459a87a844724a265b93 : SUCCESS in 35m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/92749e89b69e4473974994f06c27aec4 : SUCCESS in 7m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee1553c2a10e44dd840b90d8a4ec4a6f : SUCCESS in 7m 14s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/dd27d5cc62ee4b9cbd099ea74b3de913 : SUCCESS in 26m 28s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/d7def17c207b4f96863aee2ba8b5a643 : SUCCESS in 1h 25m 41s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/6380d63e87c8400fbf3fcfda3dc9a872 : SUCCESS in 56m 54s","accounts_in_message":[],"_revision_number":2},{"id":"1bc8935992ad975149b410c05fccd334ee08f6ce","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-24 21:29:59.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"30b3ba64cf8ed71494c6487117bf20738bff0391","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 23:04:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/9349e9b5495c4487a20d6e1bcc3dce4c : SUCCESS in 4m 47s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/4ffac54238e54ec7890764742a697c00 : SUCCESS in 20m 57s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/f80e50c594a444e39984d1e1e990ba86 : SUCCESS in 4m 42s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/bc514f7eb83744768a397c58b9cb9b99 : SUCCESS in 20m 20s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/03484f900d2b4ce09b7f24595a8a6505 : SUCCESS in 19m 53s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/5cbe91459d67473b98d527e29b4c1b54 : SUCCESS in 12m 39s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/964f4b36299d4d5b94353b3149cf2bd2 : SUCCESS in 21m 13s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/9e6022a4d2614586aa270d3975f7aa70 : SUCCESS in 22m 43s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/303f2c64c5aa404082adc50f158a201a : SUCCESS in 35m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/531105de70164b4296143e51ecf51bc4 : SUCCESS in 10m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7030d14c6fbb4ab9881007fd83b10e06 : SUCCESS in 6m 05s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/caeee7b8d84747328b27c4311a6fea78 : SUCCESS in 32m 55s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/fa6dade6b7e24d999656b516c0d86932 : SUCCESS in 1h 14m 16s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/2875a63a69084e0999dee52109f4ee5b : SUCCESS in 46m 44s","accounts_in_message":[],"_revision_number":2},{"id":"39f9ff65be65b9e3c9a62e36fb74d4c2de2347bf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 23:57:48.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c4d599e41ddde2a030e07660aecc445a9ee1a32d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 10:28:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/f94320f78dde40789f346590349c625f : SUCCESS in 6m 16s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a73d17e820ec41d6ab4a8fd4cfb04f2b : SUCCESS in 10m 44s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/8073e06b48004d1495e33d1d178656c7 : SUCCESS in 7m 02s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/321481f1e8ce4594828a98d5e1f3449e : SUCCESS in 10m 40s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/804cf08b6ba846e99ed4fe0b7787b80c : SUCCESS in 11m 17s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/c97ea19622f54c3292019b4c1399d74f : SUCCESS in 11m 08s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/b095a2536e6d4615b99f213eddd51190 : SUCCESS in 11m 35s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/106024bda70b4cdd90bc10a56b425236 : SUCCESS in 13m 28s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/554c391faefe448cb8ad71e3275c9ba9 : SUCCESS in 34m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ec1cb07ba522480f91ae3a97c0f9b199 : SUCCESS in 10m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04f252f89597410d83bf63e82ab520fa : SUCCESS in 7m 21s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a5d2428025624a9bac43d1857765861c : SUCCESS in 34m 09s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/4ea19f158e6f4e80b12e35d0c70ae217 : SUCCESS in 1h 51m 45s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/fbfa3ff43fad4d3ea8c3df5f125e2032 : SUCCESS in 1h 10m 58s","accounts_in_message":[],"_revision_number":2},{"id":"1573298e766b3a1bae3c724370d4d5209ff9125c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 10:28:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"41890e558321b5aecc0cc74b477cce0cb7249d2d","revisions":{"a2ddc1aba325989d125beb1800827beca3a15707":{"kind":"REWORK","_number":1,"created":"2019-10-23 15:59:46.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/19/690619/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/19/690619/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/19/690619/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/19/690619/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/19/690619/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/19/690619/1"}}},"commit":{"parents":[{"commit":"79c56dc3393cbaba450c5421d72239d9b2e95d4b","subject":"container-replicator: Add a timeout for get_shard_ranges","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/79c56dc3393cbaba450c5421d72239d9b2e95d4b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-04-25 19:57:16.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-10-23 15:58:18.000000000","tz":-420},"subject":"sharding: better handle get_shard_ranges failures","message":"sharding: better handle get_shard_ranges failures\n\nThe contract for ReplConnection.replicate() is that if we can get a\nresponse, we return it, and if we can\u0027t (because of a timeout, or a\nsocket error, or some other http_client error like BadStatusLine), we\nreturn None to indicate the error.\n\nPreviously, _fetch_and_merge_shard_ranges() always assumed the\nresponse would have a `status` attribute and raise an AttributeError\nwhen response was None. Now it will treat that case like other\nget_shard_range failures.\n\nChange-Id: I023b8a46c06e9a2755b5aa890a7992ef9633cba9\n(cherry picked from commit bc5f4c061122aee5965cfb055beb3cb079073536)\n(cherry picked from commit 657ee1092d8caeb0b9be8a011741cfcdfba6dc99)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a2ddc1aba325989d125beb1800827beca3a15707"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a2ddc1aba325989d125beb1800827beca3a15707"}]},"branch":"refs/heads/stable/rocky"},"41890e558321b5aecc0cc74b477cce0cb7249d2d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-10-23 17:27:17.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/19/690619/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/19/690619/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/19/690619/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/19/690619/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/19/690619/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/19/690619/2"}}},"commit":{"parents":[{"commit":"7d90c5bde20e320c92a7d0ade4137d21890b3f13","subject":"container-replicator: Add a timeout for get_shard_ranges","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7d90c5bde20e320c92a7d0ade4137d21890b3f13"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-04-25 19:57:16.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-10-23 17:26:14.000000000","tz":-420},"subject":"sharding: better handle get_shard_ranges failures","message":"sharding: better handle get_shard_ranges failures\n\nThe contract for ReplConnection.replicate() is that if we can get a\nresponse, we return it, and if we can\u0027t (because of a timeout, or a\nsocket error, or some other http_client error like BadStatusLine), we\nreturn None to indicate the error.\n\nPreviously, _fetch_and_merge_shard_ranges() always assumed the\nresponse would have a `status` attribute and raise an AttributeError\nwhen response was None. Now it will treat that case like other\nget_shard_range failures.\n\nChange-Id: I023b8a46c06e9a2755b5aa890a7992ef9633cba9\n(cherry picked from commit bc5f4c061122aee5965cfb055beb3cb079073536)\n(cherry picked from commit 657ee1092d8caeb0b9be8a011741cfcdfba6dc99)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/41890e558321b5aecc0cc74b477cce0cb7249d2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/41890e558321b5aecc0cc74b477cce0cb7249d2d"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}