)]}'
{"id":"openstack%2Fswift~690629","triplet_id":"openstack%2Fswift~stable%2Frocky~Ide9d44cc18575306363126a93d91f662c6ee23e0","project":"openstack/swift","branch":"stable/rocky","topic":"bug/1813725","hashtags":[],"change_id":"Ide9d44cc18575306363126a93d91f662c6ee23e0","subject":"encryption: Stop being cutesy with os.path.join()","status":"MERGED","created":"2019-10-23 16:14:20.000000000","updated":"2019-10-24 02:53:40.000000000","submitted":"2019-10-24 02:53:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690629-1571885620150-fee2ba80","meta_rev_id":"9838725367d6ba0cba6f207993c83b8057580716","_number":690629,"virtual_id_number":690629,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-24 02:53:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-23 17:47:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-23 17:47:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-24 02:53:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8910a95170a7f39303b896d055f09f51a34a30b0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 16:14:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cee4cb2f3e6726232df76694a81c4c55cefbadf3","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 17:47:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nFairly clean backport (complicated by the multiple-keymaster feature), but needed to fix a nasty bug seen in the wild. Tests catch the regression.","accounts_in_message":[],"_revision_number":1},{"id":"b3ba2fb508056d76a07ab2cd8a9ca347f7aca4a7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 19:13:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/3ccdadc2d3cc4b118d570fdeeac69fda : SUCCESS in 5m 39s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/987251b3626e460e8526c9b9bf47b6a6 : SUCCESS in 10m 58s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/23a5705a2ee94cac93f5020aed740dc2 : SUCCESS in 8m 10s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/2071ca01222844fcb6cff8c365659193 : SUCCESS in 12m 29s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/a02be3c0c5ad4d1cbae84e637e2f9155 : SUCCESS in 8m 33s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/89b4c2a59ba8494abbd85069baf0304e : SUCCESS in 9m 00s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/80696ace3b6e422eb284ab33d1ad67f0 : SUCCESS in 9m 18s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/4a3d3f6c97cb4484875a9f53c826dcc8 : SUCCESS in 9m 45s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/90521cb4dcc5416cbf78a2ab35b022d7 : SUCCESS in 29m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cdc8ce791fbd48fdb92999c48ef7d6c4 : SUCCESS in 10m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ddbcb4e8fbf7432fb5065a05fe68f3e2 : SUCCESS in 4m 36s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/3436598341f04e70adba9055b09a2aa3 : SUCCESS in 27m 27s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/10da00d02a2c48058465d59dacaa2f17 : SUCCESS in 1h 19m 22s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/520ef57e909048d08416f061d14da152 : SUCCESS in 1h 01m 24s","accounts_in_message":[],"_revision_number":1},{"id":"86af87fa775207de3c104bbfaf9a370d30246820","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 19:13:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f02c04d08a6579f37a8e3e86e23040d77c501057","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 22:15:14.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/d524c745e8774171a7bb400ba73ad939 : SUCCESS in 8m 28s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/eb3d1fa2f060427aa0b281f43d5dbe78 : SUCCESS in 9m 59s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/9bae8216ef684091ab9aac5b2baa671c : SUCCESS in 5m 49s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/06dbb6d5a7354c66be3fff9d6e721793 : SUCCESS in 10m 37s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/eb7820f1be39456f8fae19de533538e8 : SUCCESS in 14m 06s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/48560763ab38464bb16c6597637e9b0b : SUCCESS in 9m 46s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/0b14033cd9f547b88cbfe4894373f0a4 : FAILURE in 12m 04s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/705c6e54664e49f59e17451338745f01 : SUCCESS in 11m 08s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a6dad31c966c475c87819ce7aceeebff : SUCCESS in 31m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7b7e4e41e3004d7da5fc620eb55f21ac : SUCCESS in 8m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0f13cc6239e64610b3ea7dbc6bf09073 : SUCCESS in 7m 50s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9339f30038944f0bbc54e54fa58601ec : SUCCESS in 26m 57s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/28b06509c63941aea2d94553f31e8752 : SUCCESS in 1h 33m 12s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/16859dd692c444138203f335060650d5 : SUCCESS in 59m 18s","accounts_in_message":[],"_revision_number":1},{"id":"ce143b5fd414b4eb76322b345fd1f541155cc019","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 22:30:03.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e80945d7adf805c22c34b5d3b9eed96835d9d308","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 00:28:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/99df1f7b1f7c4e6699f6b55aa493a9b0 : SUCCESS in 5m 28s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/564fa2d9be434c3caa16cc22e4198eb2 : SUCCESS in 10m 55s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/cb041a502efa41fdaac6069cc6c9aee6 : SUCCESS in 5m 10s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/596a29c5e1a242db934330475b74c232 : SUCCESS in 9m 19s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/b72eb04c8c764c2681c57d11c74fd40c : SUCCESS in 9m 06s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/69dd8396098a411496575d3d16547cbf : SUCCESS in 8m 52s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/ade70c6c954645b9b7d5ae38d1bebb85 : SUCCESS in 10m 48s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/b053620a0cde42f3a7ab8a2a26fb793b : SUCCESS in 14m 26s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/039bb62c802a4319b97d8108c8a396f6 : SUCCESS in 30m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/92595d976ce04a2e957ebb71523afbed : SUCCESS in 9m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee1403dd5ac243a0bdfc89bdc7f6449e : SUCCESS in 5m 19s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1a6cd59b811c40f3bbb94fe655a114d4 : SUCCESS in 24m 22s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/0ca95c1c79774ec7a98e78e49bca3cd2 : SUCCESS in 1h 16m 45s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/c321e6985a324f95a23906e603de5b6a : SUCCESS in 1h 03m 16s","accounts_in_message":[],"_revision_number":1},{"id":"41d3ea8d3c61f4ec74f2e621be914e3cfc5fd12a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 00:28:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5ac49842a3b43a0e83ca2f9b53be7e69406a12a2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 02:53:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/02c0f7f8be6e4409a09f1cc7659b4206 : SUCCESS in 5m 53s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/12ad4050aa304231a7a7f7b4fcc4682d : SUCCESS in 9m 40s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/942d233723ed45a1882013301681da2d : SUCCESS in 5m 50s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/1260d9ed0c0c4d8ab325a3be729a6e77 : SUCCESS in 10m 03s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/fd5c56b017284a768c1fcc8ef6579c67 : SUCCESS in 10m 28s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/29d31f6110d64dbca6b19ed3ee4fa8dc : SUCCESS in 10m 06s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/6995e39801e34238a3998a29a1a7d8e4 : SUCCESS in 10m 00s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/8339580c45eb4365a8d5fcc51b5714e9 : SUCCESS in 9m 40s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/72dac33e7c8546afb40a9bdd25b673da : SUCCESS in 29m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1c7823e64af14071a362274a6ddd4f8a : SUCCESS in 9m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9783ca3cf87a43deb929188c8ff3d24d : SUCCESS in 5m 51s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/e75916068ab14e6e88fb40437792bc39 : SUCCESS in 28m 12s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/70b696f999c642328b3d4ec7bfe87612 : SUCCESS in 1h 30m 56s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/22ce67d7b71a441ebabb001119b34c8c : SUCCESS in 1h 02m 07s","accounts_in_message":[],"_revision_number":1},{"id":"5e19b25dcacf060f5b374aba504a8c001e920a03","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 02:53:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8fc622b28a4fc7ed23ba79ee1db2103a541866b7","revisions":{"8fc622b28a4fc7ed23ba79ee1db2103a541866b7":{"kind":"REWORK","_number":1,"created":"2019-10-23 16:14:20.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/29/690629/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/29/690629/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/29/690629/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/29/690629/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/29/690629/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/29/690629/1"}}},"commit":{"parents":[{"commit":"c08da08e08570ab80ea827138a276abe5e89c033","subject":"Merge \"s3api: Delete multipart uploads via multi-delete\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c08da08e08570ab80ea827138a276abe5e89c033"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-02-07 00:48:17.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-10-23 16:05:13.000000000","tz":-420},"subject":"encryption: Stop being cutesy with os.path.join()","message":"encryption: Stop being cutesy with os.path.join()\n\nTurns out, we *care* about the path, and object paths *don\u0027t follow\nfilesystem semantics*!\n\nBe explicit: /\u003caccount\u003e/\u003ccontainer\u003e/\u003cobject\u003e\n\nBump the key version number so we know whether we can trust the full path\nor not.\n\nChange-Id: Ide9d44cc18575306363126a93d91f662c6ee23e0\nRelated-Bug: 1813725\n(cherry picked from commit 43103319d0aa27f24e6520c0962bd19e55568ad4)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8fc622b28a4fc7ed23ba79ee1db2103a541866b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8fc622b28a4fc7ed23ba79ee1db2103a541866b7"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}