)]}'
{"id":"openstack%2Fswift~690644","triplet_id":"openstack%2Fswift~stable%2Frocky~Iab1e07706193ddc86832fd2cff0d7c2cb6d79ad9","project":"openstack/swift","branch":"stable/rocky","topic":"bug/1568650","hashtags":[],"change_id":"Iab1e07706193ddc86832fd2cff0d7c2cb6d79ad9","subject":"Fix socket leak on object-server death","status":"MERGED","created":"2019-10-23 17:08:19.000000000","updated":"2019-10-24 01:28:29.000000000","submitted":"2019-10-24 01:28:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690644-1571880509291-5cb63f8a","meta_rev_id":"ee40ebf23a74caea4f402bbbf71e854eb7c3592e","_number":690644,"virtual_id_number":690644,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-24 01:28:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":2,"date":"2019-10-23 17:59:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-23 17:08:19.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":1,"date":"2019-10-23 17:59:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-23 17:08:19.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2019-10-24 01:28:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0bd07789e2941d9a677e3bcf15639c359bacda6d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 17:08:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e7e3efe8b33ed1e53580e3ddd3e26237a27e79fc","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-23 17:59:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport, closes bug, tests catch regression (though they maybe should have a timeout...)","accounts_in_message":[],"_revision_number":1},{"id":"b41ec957f2a5b5344e32be1d3afd4326654d4fd0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 20:25:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/c4ff97a5d4ae438d801c1f57df3f3a0f : SUCCESS in 4m 38s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b5d629393aa949fba1abd07ef8374271 : SUCCESS in 10m 05s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/c4636f67aa674cc7af0cf943f6edc5c8 : SUCCESS in 4m 18s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/4e82fdc7db2546aa93b2daf87e7af519 : SUCCESS in 12m 12s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/a83f5fdda3c44f13b492588501eddaae : SUCCESS in 9m 19s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/12e7872b387143ecb6f142b14e48961f : SUCCESS in 9m 25s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/8e8fa6e219614f70a7ad8cec61f2e2f2 : SUCCESS in 11m 24s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/1e278fd64f58483ab2a896402ff79cd6 : SUCCESS in 9m 44s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/92a914fe6294412d9a7920cdf6934efd : SUCCESS in 32m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c7bef15bcf5d4533a4470b6ab0e60bd9 : SUCCESS in 7m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/828806dd142e4eaaacf6c595e30be350 : SUCCESS in 5m 55s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/66fd38f8b8754affb49defbb3fd926ba : SUCCESS in 28m 26s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/16c5c093412946c1b6abda81dc4c899a : SUCCESS in 1h 50m 54s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/962962c301ba4f16807a53d9cdf30934 : SUCCESS in 58m 11s","accounts_in_message":[],"_revision_number":1},{"id":"307f782cc2590360d19ac38090563ef610de2408","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 20:25:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0e3ebbd03fcd4d1b58129d9cb4da1be7cd0966c3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 01:28:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/dc8a8f14f312488a8a37d7acbe3253ad : SUCCESS in 4m 51s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/d67c8683f853491f94c1fab12a92906d : SUCCESS in 12m 14s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/583cab1f7e4b42849ea9111bf8673534 : SUCCESS in 5m 01s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/c24417d0880545328b086831aa2900c7 : SUCCESS in 8m 56s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/50e748659c8c43f3b0a52083dd3279ff : SUCCESS in 9m 29s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/dc04c659d2ca4546a0c9036e04a557d3 : SUCCESS in 12m 05s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/caf5970849874131bf3095d4b23c116b : SUCCESS in 10m 50s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/01f7af1626ba420e8e25b197c1de50e4 : SUCCESS in 10m 38s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/bca57e0d934d4920bfcf0b9cf0c318c9 : SUCCESS in 31m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8056e8c2b8b5464a8b54fde67538f5c7 : SUCCESS in 8m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/56d85ec5425b48108b4274b9fe8add75 : SUCCESS in 6m 01s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a1ce7acb4d584092a53f074fc96f40a2 : SUCCESS in 29m 19s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/25cd644660cb466995e5926535fe453d : SUCCESS in 1h 42m 22s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/15e6363c3f934428b0a8e674c9898175 : SUCCESS in 1h 08m 38s","accounts_in_message":[],"_revision_number":1},{"id":"8396603c150c16fba56c57834b31fd7778052104","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 01:28:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e3739920c4db97f255ab973cf125f0091bb15428","revisions":{"e3739920c4db97f255ab973cf125f0091bb15428":{"kind":"REWORK","_number":1,"created":"2019-10-23 17:08:19.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/44/690644/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/44/690644/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/44/690644/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/44/690644/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/44/690644/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/44/690644/1"}}},"commit":{"parents":[{"commit":"c08da08e08570ab80ea827138a276abe5e89c033","subject":"Merge \"s3api: Delete multipart uploads via multi-delete\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c08da08e08570ab80ea827138a276abe5e89c033"}]}],"author":{"name":"Samuel Merritt","email":"sam@swiftstack.com","date":"2018-06-13 21:28:28.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-10-23 17:04:32.000000000","tz":-420},"subject":"Fix socket leak on object-server death","message":"Fix socket leak on object-server death\n\nConsider a client that\u0027s downloading a large replicated object of size\nN bytes. If the object server process dies (e.g. with a segfault)\npartway through the download, the proxy will have read fewer than N\nbytes, and then read(sockfd) will start returning 0 bytes. At this\npoint, the proxy believes the object download is complete, and so the\nWSGI server waits for a new request to come in. Meanwhile, the client\nis waiting for the rest of their bytes. Until the client times out,\nthat socket will be held open.\n\nThe fix is to look at the Content-Length and Content-Range headers in\nthe response from the object server, then retry with another object\nserver in case the original GET is truncated. This way, the client\ngets all the bytes they should.\n\nNote that ResumingGetter already had retry logic for when an\nobject-server is slow to send bytes -- this extends it to also cover\nunexpected disconnects.\n\nChange-Id: Iab1e07706193ddc86832fd2cff0d7c2cb6d79ad9\nRelated-Change: I74d8c13eba2a4917b5a116875b51a781b33a7abf\nCloses-Bug: 1568650\n(cherry picked from commit 0e81ffd1e1481a73146fce17f61f2ab9e01eb684)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e3739920c4db97f255ab973cf125f0091bb15428"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e3739920c4db97f255ab973cf125f0091bb15428"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}