)]}'
{"id":"openstack%2Fswift~691423","triplet_id":"openstack%2Fswift~master~I3e5229d2fb04be67e53533ff65b0870038accbb7","project":"openstack/swift","branch":"master","topic":"seamless-reload","hashtags":[],"change_id":"I3e5229d2fb04be67e53533ff65b0870038accbb7","subject":"Seamlessly reload servers with SIGUSR1","status":"MERGED","created":"2019-10-25 19:49:52.000000000","updated":"2019-11-14 20:37:05.000000000","submitted":"2019-11-14 20:34:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"691423-1573763688616-bdb6f180","meta_rev_id":"346c8916544ac73374fc930c6794d2d9c8ce46b4","_number":691423,"virtual_id_number":691423,"owner":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-11-11 17:21:47.000000000","_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-14 20:34:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"value":2,"date":"2019-11-11 13:51:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":2,"date":"2019-11-14 19:02:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":1,"date":"2019-11-14 19:02:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-25 19:57:41.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-11-06 08:39:13.000000000","updated_by":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"reviewer":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"state":"REVIEWER"},{"updated":"2019-11-11 13:51:26.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2019-11-14 19:02:31.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2019-11-14 20:34:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e09e85c2f760853087a4c23f291147daae91d939","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-10-25 19:49:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6e6a1f11e56a296d86edebb3ecfb93f538171455","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-10-25 19:57:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e3d33cb4ee91012806e77081a27b6a6e3b039538","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-10-25 20:11:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4fb07755b6228d6163f2e44e829c958523696f51","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 21:26:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a0c4cc427e044bb293a359463f931b65 : SUCCESS in 7m 25s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/3a304f3998b1478d8f429cdd6285ca64 : SUCCESS in 59m 49s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/aee1d6e0a8d94a7fa209ba7b72d9a4c1 : SUCCESS in 50m 47s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/7543c64689e54abf9aacf3fce5856ae7 : SUCCESS in 8m 55s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/08234b3a707945edb319387ba2b678e5 : SUCCESS in 9m 14s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a6b3c160a0034004adf4d87c8df6a942 : FAILURE in 10m 30s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/97363dcf495847f0a0b8290a38aebd2e : FAILURE in 13m 36s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/87f851d16d74402dae0aae127ba0c639 : FAILURE in 16m 09s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/810d1162c911462aa0a15a4beaf0bbac : SUCCESS in 8m 46s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/2b3f3d969c444f9e9d5996f2c212cd11 : SUCCESS in 10m 56s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/2ea2d0a3cf4d45a89d518cdb342df530 : SUCCESS in 9m 01s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/67d041cae1614bd9a83b056d4ce6c495 : SUCCESS in 10m 40s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/97c826f3415d4c30a8dbd17626120eec : SUCCESS in 13m 36s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/253ce9e3cdbb4f2aa4b01bd80a4a3cf5 : SUCCESS in 11m 17s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/bbe83156aae14b4bbc6f873e128ba558 : SUCCESS in 10m 04s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/659734b78a4a45349560440613942e2b : SUCCESS in 11m 15s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/bf9ac8b2c73e41e8af459c420dda12a5 : SUCCESS in 10m 26s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/eb7ee2a0aa0a40298266bfc366305e3d : SUCCESS in 12m 47s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/66396273740f4806bd0df3b76dacc68f : SUCCESS in 14m 07s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/618fce6169654c76a927b48fbdb55abb : SUCCESS in 31m 03s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/83c067013e454040ac99a4c34bcca49b : SUCCESS in 29m 45s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/ce4081fac7d04b1a9bafbfb619f72aa9 : SUCCESS in 28m 47s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/f75a46e9dcb8440f9ec8fcecfc16edcb : SUCCESS in 29m 37s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/921d35e56a2a4845a0bf38cb6c3524fd : FAILURE in 12m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7bb5537454db4a768e4b2739016bd6ed : SUCCESS in 5m 29s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/60821960a3f1420ea0d2bd88873a5d21 : SUCCESS in 16m 45s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c362b33bcdbd445d9b83e22f5502cf2b : SUCCESS in 1h 10m 09s","accounts_in_message":[],"_revision_number":2},{"id":"27b2b8118a66e336e16a391e58121100e81a65d6","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-01 00:19:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"57eacdd0e678ea833c9ad746e06bbda396a7cb27","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 05:31:07.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/286eaa219b1f4a649471b313671e7f71 : SUCCESS in 9m 24s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/64ba1801cd2a426ca398d4c1a3425017 : SUCCESS in 1h 10m 56s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/4ca09507f49e4f4b9f619757438a3b11 : SUCCESS in 53m 49s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/513fdea4cef040e18d447119cd9e9885 : SUCCESS in 8m 59s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/90b28ac9561146fb9ea773f68f25fa5d : SUCCESS in 8m 25s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b934beb44a7a4f6caab6d531020c64aa : FAILURE in 17m 36s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/a4de8948b0da4263b611adc95e6ceb27 : FAILURE in 15m 10s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/da2ffa9695754c98aa753401d623b6ae : FAILURE in 16m 17s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/6b6daa582e6241e3afb28aa59abd473f : SUCCESS in 13m 55s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/2e0c48b72d9043f3a68482b3a1e427d0 : SUCCESS in 12m 29s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/e588d579dcad4d6d873728f83e8b8a5e : SUCCESS in 11m 50s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/1b2c86a27f2e4482abf007b75735d35e : SUCCESS in 13m 34s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/d0d5a4055ec54a59a9a2877cb05539ab : SUCCESS in 14m 56s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/1deb7c94e1df4616b7ea4c77021fda41 : SUCCESS in 14m 22s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/32cc1920a2a14927a347f3bb42c878e2 : SUCCESS in 12m 08s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/08e2f576225f472e92245256d8dc9f5b : SUCCESS in 14m 58s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/b809b9bcd97645fc8b65d6ab2cb2fdd8 : SUCCESS in 16m 01s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/765a1adf036443cfb6425ed3198a8274 : SUCCESS in 16m 22s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/19b5f2ed153d406ca2f6ff5e95093d43 : SUCCESS in 20m 12s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/0fde12a4548b4b498ebf7d7ae4025858 : SUCCESS in 39m 38s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9f72a33a4a5f40819d81316ecb391d61 : SUCCESS in 28m 48s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/a53acbcb1b8744f68b47451896f5d907 : SUCCESS in 47m 49s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/ad2516dd8da2448f83889d982ec535cb : SUCCESS in 28m 34s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31b758f69b0640baafc7f8711ee84349 : FAILURE in 3m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/86cf76dfb5ea49539efb252a549cd2bf : SUCCESS in 6m 01s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/4c455569a85b4ee4816b25ec18e271ee : SUCCESS in 25m 00s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/46f5d663b2164b13b55408f664a275c0 : SUCCESS in 1h 03m 00s","accounts_in_message":[],"_revision_number":3},{"id":"9c33398e5104dfb7675b46168e354a45b986215a","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-01 07:25:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5942eed53f58600bad2bdb5bf74da237b3923c3c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 10:34:41.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f83637de34444d8db6837f02b647f7f6 : SUCCESS in 8m 13s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/ffddf9e90c03432db1121453645c1bcc : SUCCESS in 1h 05m 19s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/c958e53ace23476aa363dfa77054b727 : SUCCESS in 54m 20s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/5a37384e4ef149399e1b82e78b0ba8ba : SUCCESS in 10m 42s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/7cc6005338d848a39a402b9dd56ef3e1 : SUCCESS in 10m 50s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/93313ff20343478cb78ed72b1010b06f : FAILURE in 13m 18s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/b2807284594540e59e95dbdec37c1988 : FAILURE in 13m 25s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/0f106dce1c854f2f9a79ca47f4d5c2ab : FAILURE in 15m 00s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/ac0c7857632741da881e1835628707ac : SUCCESS in 14m 13s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/c390d482b87040b2922c72c639bb33b8 : SUCCESS in 12m 19s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/f0d915dce8ac43c894f411c18c804b99 : SUCCESS in 14m 23s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/b734c955ac9d4275a5fb860a81bb1180 : SUCCESS in 13m 10s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/c8473a6319b7446a99e9f7d364f0d9c3 : SUCCESS in 15m 59s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/60fd9cae83114a4aaf0df8369c976d9f : SUCCESS in 14m 32s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/202589fbb2984957a7574ee27632346a : SUCCESS in 14m 38s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/25094452f29f402a89ba3dc2a82a8dcf : SUCCESS in 16m 18s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/85b070b6f89e4734b3d7d3dd4ae30e53 : SUCCESS in 17m 06s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/c9c1e39ec3604ecbb618b9a36dfc0c0c : SUCCESS in 17m 37s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/dc662e241a1745b39298dff9ec180fd2 : SUCCESS in 19m 41s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/69d9282d0d3a4b9192cbc5c3e66644b2 : SUCCESS in 41m 48s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9664c33feadc47bea037a3a60c52d861 : SUCCESS in 36m 35s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/510b0ce2a6f44467a36780d24e5213b6 : SUCCESS in 28m 04s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/532f566ada234bf7b35555c3e186b79a : SUCCESS in 30m 36s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/331b32a968be460590cb8bc2a59fbe38 : FAILURE in 5m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/befc40bb4d414351ae53ac4b1f47b163 : FAILURE in 6m 19s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/3d133ece10244a14aef5f7c58fcc68bb : SUCCESS in 28m 41s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8ecf6982812d4a9faf68324d0b50de8c : SUCCESS in 54m 46s","accounts_in_message":[],"_revision_number":4},{"id":"2d060318918e9ed0896e19b3b1e2f5b0a397e250","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-01 15:28:42.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fdfb060e3d26f2e590899c6ba904dddff11c5b54","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 16:42:38.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dac254cb983f4bd5baf11fcee5499df1 : SUCCESS in 11m 31s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/df43042849184ffab9b41214b155a32d : SUCCESS in 1h 10m 50s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/fe9ec86382c74bd08732e792dc6f2e8e : SUCCESS in 1h 05m 21s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/5002b0c84c9f4f719336b035a89f14bc : SUCCESS in 10m 50s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/056d094b95c34f1dba40a6ca430cae22 : SUCCESS in 10m 22s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/c81b2da7def6420e860677f702befef3 : FAILURE in 16m 45s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/e3b18f9179a5413f94da9851297e26d7 : FAILURE in 17m 22s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/c28f51e79fd740e2872a89b5c83aa578 : FAILURE in 12m 07s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/5a33f5d523c84fefadd416add6ff47c7 : SUCCESS in 13m 33s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/299914ec57924940b38a81229b307fba : SUCCESS in 12m 30s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/b25facb9d31b478a8bb58749f6baa270 : SUCCESS in 13m 05s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/99eb394ad72f47a4a1fd302d1823ab3b : SUCCESS in 14m 38s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/99f2eb901dec4662bed23e5e2db8eb8f : SUCCESS in 17m 03s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/dddd31112d1a4fe681a66fa1b343ed30 : SUCCESS in 11m 25s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/525da49f244f4c19b0bf215ec007cfa2 : SUCCESS in 11m 08s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/50f4acd678f94b749ded99a430124106 : SUCCESS in 11m 27s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/9c0e5d5697334798a50495c752b69517 : SUCCESS in 12m 48s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/0580b9361269496ab4f3eceb10562441 : SUCCESS in 15m 08s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/2b713b691c1449e282d25c5b373843d1 : SUCCESS in 16m 33s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/c50efb2c420d47049641835e8df1853d : SUCCESS in 32m 16s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/d400e5e4dc4a4273acf5ea386d7aa714 : SUCCESS in 30m 01s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/b871b6f4b91a48d5b50370bc2ea7c846 : SUCCESS in 27m 37s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/e601f8aed20d4395bb695e56db705390 : SUCCESS in 27m 22s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/417922e0d4444d7db0175994148677fb : FAILURE in 4m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b677bfbdd3e45478bb9e5ea5fddec6e : FAILURE in 5m 51s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/c1cc7cc35bbb456290036a251b83b6dd : SUCCESS in 21m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8eabd1f903e347cba71c97a4a6c4d823 : SUCCESS in 1h 02m 17s","accounts_in_message":[],"_revision_number":5},{"id":"2c93e52cdbcbd32885e90a441ca0c40af47563cf","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-01 19:20:27.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"0fb78722c94aa49feb6979bfd4a96f65041ae953","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 20:32:20.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c2bfca51b8864536819e5b032e156dc3 : SUCCESS in 8m 31s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/9b49da5b280c4175b627c89780b22b77 : SUCCESS in 1h 02m 39s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/359b0633524846a3ac4216feba7d3caa : SUCCESS in 57m 28s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/e04562374d2b4885a2548c219f3cda61 : SUCCESS in 7m 37s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/875782683c1640a99e863e3b46e9a559 : SUCCESS in 8m 51s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/1c85a948cef345aa877e55f5d20c0c8e : FAILURE in 12m 47s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/ddddb8b24dc54671ba73b0d4c5b6e82f : FAILURE in 13m 14s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/5f32116215d8424d882a8401c5f56f73 : FAILURE in 15m 05s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/4d74ca1cdbca4a2ba4682568cac38730 : SUCCESS in 9m 04s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/12d6337ef3d5464897d0aa77eda9413f : SUCCESS in 12m 12s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/ade6309e6774464991401f40bc61dec7 : SUCCESS in 9m 15s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/e1c59abc9a94438d9c370966a5bd2c29 : SUCCESS in 13m 07s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/d1bdbf7c570c4bcbb6716ff6690b62ad : SUCCESS in 14m 44s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/b8cc46f3592c421899cd7a9a21c6186f : SUCCESS in 9m 29s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/c5e44fe756d34dbca85a79df8cab0de6 : SUCCESS in 13m 55s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/df61958e628447dbb906244fa58a670d : SUCCESS in 11m 23s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/bdbae9ddaf9b4fefa639c482e679c23b : SUCCESS in 12m 23s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/a4aa4e5250fb4a88b1f3821845c8f665 : SUCCESS in 12m 16s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/82a35c0cb1594343bfb73723aedf09ad : SUCCESS in 11m 30s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/52830ac0d5324624ba6362b63364e95c : SUCCESS in 32m 48s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/71d00bb533cf4204b77d9aae7a0088bf : SUCCESS in 29m 06s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/6d05a5698de640c0b78efa3eaca1772e : SUCCESS in 26m 11s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/b0b2b99086d241f6b08243d3c532091b : SUCCESS in 27m 45s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/77f71739f1df4e6b9361062ec725c451 : FAILURE in 2m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/72f5eb1309bb45c997c6f3ad46f5f3e4 : SUCCESS in 6m 21s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/1d039436be4d417b86655816815a2ff8 : SUCCESS in 20m 03s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7bda869553014bcba6425067db9b5031 : SUCCESS in 1h 05m 50s","accounts_in_message":[],"_revision_number":6},{"id":"e78d08b6fdd44d9f0ad37fdd1165c15c79cd8ac6","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-01 22:27:49.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f3510a3415aeba33f06844a5d8b0aa6c8d5ff80a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-01 23:35:31.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/08933d367818449a9aa42481b0384a12 : SUCCESS in 4m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/274cde04844645d6b95d1a56c2d9193a : SUCCESS in 9m 03s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/16600b69d30442f89164045769bc832e : SUCCESS in 7m 09s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0828cbf50bae4d06b1d659c996c7d734 : SUCCESS in 50m 16s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/cfcc9c0ddc55433f9da4a5810f99730b : SUCCESS in 55m 56s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/7a18ed28b8364dfbabc66a2368ca7c67 : SUCCESS in 20m 36s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/36ac2db88d7a4859822d5b6a754b7c01 : SUCCESS in 10m 28s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/66809a8fe41e4eda882c9015f06df8b9 : FAILURE in 16m 50s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/b4fd10d9d10e4ca68705ed2c9ed0b75f : FAILURE in 16m 57s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/805c865efcdd4d369e08e61487c3fdda : FAILURE in 18m 57s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/4ce2bd3c6e2943f5a230432d679727ce : SUCCESS in 16m 51s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/940dd28c7ca94726bd6213a8b23610fe : SUCCESS in 12m 17s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/140b30ab383a49b096a32fa23778bb07 : SUCCESS in 15m 44s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/e08dd834033d4a8ebc572ea5f9c65528 : SUCCESS in 14m 42s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/93b39b67b7744263adfa992cc56b407d : SUCCESS in 23m 26s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/25485c245b604cd89144ef98f3378b03 : SUCCESS in 12m 58s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/efe24440f561435a9319018f6f686bdd : SUCCESS in 16m 23s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/d3857fcef8134eb7985968c44e149fe5 : SUCCESS in 17m 53s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/641a8805b4754a84ab4cbcad07982266 : SUCCESS in 11m 29s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/d252dd7f43dd4308959c6ca193bd3eb2 : SUCCESS in 17m 59s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/03112e8ca495475aa3ba01bd38c12c03 : SUCCESS in 21m 40s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/3b139a7987154c4c82d7d28bf0d9790e : FAILURE in 35m 38s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/89fa6173ab85408785834f4daa76c33c : SUCCESS in 38m 34s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/9c23298a045f4c0cb4c7b05295903a27 : SUCCESS in 33m 10s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/fcecda73669046e29a6973c1ae0cf7cf : SUCCESS in 42m 49s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b1836c22655f4393815385fd198ec48f : FAILURE in 12m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/042d3b92bcb343bf9cdeb82172e2c659 : SUCCESS in 6m 29s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/39f9a2c70160444d854ffe0df2ce7c39 : SUCCESS in 23m 37s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a089c8b062f34d539b34af9084971e36 : SUCCESS in 56m 09s","accounts_in_message":[],"_revision_number":7},{"id":"c69ad3e74995e6e01c193583b151ffcca79cc20b","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-01 23:35:53.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"f229be1359a28698d65156f442c748fc33dcc6ee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-02 00:35:31.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/3eec0b74f4d94b5a939cccf388a37916 : SUCCESS in 2m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91611f3eda4243549f8994281e50bde0 : SUCCESS in 7m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/654417f551674887b9da854bdee1286a : SUCCESS in 7m 03s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/f1d15b66094646a38352334fcee98c2c : SUCCESS in 51m 45s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/36a6c9624153409aac7c91741e71e74e : SUCCESS in 51m 29s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/69a919680f004dc9944347cd90cfbdb1 : SUCCESS in 7m 41s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/eb561e786c8341959069a4b84f32843e : SUCCESS in 8m 56s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/9cc10145acaa4f198ca288f7ada2bae3 : SUCCESS in 16m 10s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/cac145c0af71453c8bf6830e109b6de1 : SUCCESS in 10m 52s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/10421569623745e9a1f7c1f453af3ec5 : SUCCESS in 16m 29s\n- swift-tox-func https://zuul.opendev.org/t/openstack/build/d6f532698eb44b0e9c347d0643ffc611 : SUCCESS in 14m 00s\n- swift-tox-func-encryption https://zuul.opendev.org/t/openstack/build/3a9da70c5a60443f9b659c73fe9180f8 : SUCCESS in 26m 50s\n- swift-tox-func-domain-remap-staticweb https://zuul.opendev.org/t/openstack/build/8a8f37a2db2b48a8824149879d3c75d3 : SUCCESS in 8m 41s\n- swift-tox-func-ec https://zuul.opendev.org/t/openstack/build/fa81881c41f342a9a1728bb537dbbb36 : SUCCESS in 9m 20s\n- swift-tox-func-s3api https://zuul.opendev.org/t/openstack/build/d12ac07289854da498654814b0cd091d : SUCCESS in 30m 03s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/86be7e63597d4fdca60046877c54dee4 : SUCCESS in 9m 25s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/bae76885a38e4038a2ed819dc82f53c1 : SUCCESS in 12m 45s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/d4fbd2400d0341ad9c9204fbe38f7b0a : SUCCESS in 11m 45s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/170f5ee9705c44a796692bfef04c33ea : SUCCESS in 10m 20s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/9d3d289865894cd09073a75e71bf74b9 : SUCCESS in 12m 25s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/66e88336dfb643d8b3387426505230ea : SUCCESS in 11m 51s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/02555e47b4b941ebac22182435ad180e : SUCCESS in 32m 23s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/eaaf56cf51e348e7a37cd8cea477bfd2 : SUCCESS in 28m 13s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/5d9f5c9cb96c4f188c8c99c5c5ae4b6c : SUCCESS in 32m 01s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/63e4025f2b654bdf9dc75b61032b605a : SUCCESS in 31m 41s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/15468546b8974d449c2e8addc3648cb4 : SUCCESS in 12m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77b3ada5d2e24e63b0a0a6b3d5c52c0e : SUCCESS in 5m 02s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/3829ee112e044312a28dc558ca71101b : SUCCESS in 15m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a905d3b6b1b844e58acb6181d23ec778 : SUCCESS in 58m 19s","accounts_in_message":[],"_revision_number":8},{"id":"a1538f3c3e504cea022b27173a2904d6bf9b8662","author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"date":"2019-11-06 08:39:13.000000000","message":"Patch Set 8: Code-Review-1\n\n(3 comments)\n\nThis is really a nice idea to implement no-downtime reload, but it miss some security checks to be trusted.","accounts_in_message":[],"_revision_number":8},{"id":"800acb225a294047776e085fa7fc744c901a3f1b","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-06 16:20:32.000000000","message":"Patch Set 8:\n\n(3 comments)\n\nThanks for the great idea of closing the sockets ourselves in the parent, post-fork, instead of waiting on exec() to close them for us!\n\nI don\u0027t think the other two comments are problems, though.","accounts_in_message":[],"_revision_number":8},{"id":"547b955138d82c54769a2adc93ef3ea80ed9cfc0","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-11-06 16:29:35.000000000","message":"Patch Set 8:\n\n(1 comment)\n\nswift-init has a --graceful flag, shoud a seamless also be added?\nI was looking for some admin documentation but I couldn\u0027t find much that talks about service restarts. Would it be possible to add some documentation detailing the difference in behavior between a graceful and seamless reload?","accounts_in_message":[],"_revision_number":8},{"id":"cd7f71c6f25e9c974dbad476b19c35e4c13e0a47","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-11-06 16:57:36.000000000","message":"Patch Set 8: Code-Review-1\n\n@darrell,\nHere are some pointers to where docs could be added:\nhttps://github.com/openstack/swift/blob/master/doc/source/admin_guide.rst#managing-services\n\nIf supported added to swift-init, should also update man pages: \nhttps://github.com/openstack/swift/blob/master/doc/manpages/swift-init.1#L108","accounts_in_message":[],"_revision_number":8},{"id":"61d828495071b5603ea560e08a787ea5bf0ac3ca","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-06 17:35:33.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"481c8d40255eff4aba758bc16e92310f7c865a25","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-07 02:07:35.000000000","message":"Patch Set 8:\n\nActually, I did some experiments with closing the listen socket in the parent post-fork (note that you have to _only_ close the sockets, you cannot do the `greenio.shutdown_safe()` call!) instead of using close-on-exec flag.\n\nIt was worse in that I observed around 1 connection getting severed between getting into the socket\u0027s listen queue but not having been accept()\u0027ed yet.  With the close-on-exec approach that never happened.\n\nMy test script hit the /healthcheck URL in a tight loop.\n\nThere\u0027s also no correctness problem in the close-on-exec approach, as the parent, post-fork, is not calling accept() on the listen socket, so it doesn\u0027t matter that it\u0027s briefly duplicated in that process.  And based on my experiments, the kernel somehow does something better when close-on-exec cleans up one of the pair of listen sockets.\n\nSo I\u0027m going to leave the close-on-exec behavior as originally written, as it\u0027s demonstrably better.","accounts_in_message":[],"_revision_number":8},{"id":"b54b32df0442b83110ac61d96b1d281fa11d9eba","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-07 18:16:30.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"b94fe5f6ceccb3f308bdf85967c30fa28217412a","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-07 18:21:10.000000000","message":"Patch Set 8:\n\n(5 comments)\n\nI added some documentation and I believe all of Romain\u0027s concerns have been addressed in replies.","accounts_in_message":[],"_revision_number":8},{"id":"40401606ed0695dd70dddc28c6d312a0749eaf64","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-07 19:18:03.000000000","message":"Patch Set 9: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/440d0ea7a58c4a9eb4bf0ccb40846717 : SUCCESS in 3m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/db7edcdfe7004c378dfae8db4f608e32 : SUCCESS in 7m 46s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a757ba2fb24840939cf80616b49e583f : SUCCESS in 7m 12s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/3a93111f8fa148499d1abf05b62c3a0e : SUCCESS in 58m 36s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/a829cd36ff114ad1bfd9c070aaa27c0d : SUCCESS in 51m 42s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/75367d3344bb4c0abbe7f44e905d4aed : SUCCESS in 8m 25s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/7e28f2c83fb743e8926362af2a63222b : SUCCESS in 9m 04s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a2fa9e61e8484013bd405c264ae195d4 : SUCCESS in 13m 12s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/cf3810dda8814ec3bb298bbfd10b3683 : SUCCESS in 11m 03s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/993a9702722d4a6a8f6a70b160c79492 : SUCCESS in 14m 16s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/85dcea63e98742d582a06f38086103ba : SUCCESS in 10m 40s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/7b4012bfe6f546a8bc4b10b4b51cf133 : SUCCESS in 10m 56s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/fce8360e82474fba92bdcc7a9cd5161b : SUCCESS in 12m 12s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/3e931143f9974ee8a0eea62fefd46efe : SUCCESS in 10m 51s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/47a458a9a2ae4da498b2f0ea4fa86b35 : SUCCESS in 12m 34s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/d4a5a804127743a888dccbef1fd9d78c : SUCCESS in 12m 11s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/193a418d58df4e69a27f22a9d47fca06 : SUCCESS in 11m 29s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/4cc2bf200c7740d3b2e4d49d9a8db283 : SUCCESS in 11m 18s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/f8e8ea5e06cb45478c2cd2363aac0b25 : SUCCESS in 11m 07s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/868f848d475448e9b03d64957e3a2a21 : SUCCESS in 19m 12s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/c4eb9a94e49845b4aabb89f6d62c3e4c : SUCCESS in 13m 40s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/54e14653d8b742f88f48f454ccdfc830 : FAILURE in 44m 59s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/05a4fd53574f466c92817fd4518c1133 : SUCCESS in 26m 09s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/9e5dd86c4b2b4e369dceed5721becbe0 : SUCCESS in 31m 03s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/4d7440a9ea7344aab77da42b3d83bc07 : SUCCESS in 33m 39s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ae5896994934ccd850feb15ea573d90 : SUCCESS in 12m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/71428fa6b2694b04a32381baddca4fc6 : SUCCESS in 5m 25s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/35cae4e8996346d2a282295bbf89c51a : SUCCESS in 18m 34s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f52477e4e2494cb6b02f9dda5b52b985 : SUCCESS in 52m 43s","accounts_in_message":[],"_revision_number":9},{"id":"e6b3ae884d7cbfea3256bb8eb9270cebb7d4da94","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-07 19:45:00.000000000","message":"Patch Set 8:\n\nrecheck","accounts_in_message":[],"_revision_number":8},{"id":"8600eafb16128777a17e86cfb86f3d2c040d16e1","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-11-08 15:31:55.000000000","message":"Patch Set 9:\n\nrecheck","accounts_in_message":[],"_revision_number":9},{"id":"deff8a8be2e99c6ac68617dd784b46e84a2634b2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-08 16:47:58.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/08cb3b92e84e4491a8fa974df38919c8 : SUCCESS in 3m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/36209bc2f68b41029595e80b18715fdb : SUCCESS in 6m 52s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0dd13f67b4c340a8b7a6764cd10f77d4 : SUCCESS in 8m 12s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/dc2628aada204acd808c27ef08a9f10f : SUCCESS in 1h 06m 59s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/3e2bef2dcbb142048750ae7419126e85 : SUCCESS in 55m 17s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/97660b532d3a4184ad31a45382db234a : SUCCESS in 8m 35s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/6aadbf33e28640bc9eea9e59e6553610 : SUCCESS in 9m 31s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/1f2f39682d1e442393aec1bc9037e7dc : SUCCESS in 11m 17s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/444ea320d544445388a79a0abca0df88 : SUCCESS in 11m 10s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/91c64abd1b674ca88db7f08755ad6774 : SUCCESS in 16m 20s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/bb491d3fc00547d9b03390ca72db400a : SUCCESS in 9m 45s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/37ada97f8f36438dbb9d77a46b479ac8 : SUCCESS in 9m 38s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/041382af024e4256ac7fb36c6c2cd095 : SUCCESS in 11m 04s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/fa8229d1ffad468db07513939de35983 : SUCCESS in 16m 27s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/54c6081308054510872531e7e9367891 : SUCCESS in 22m 59s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/fc7fcbc6bea84b8298d5c306077eac43 : SUCCESS in 10m 22s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/e081c87535464da2a7904002226eaa69 : SUCCESS in 15m 54s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/e12ac48e886d46d0841f15997cc36f82 : SUCCESS in 9m 05s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/fafbbca633684e88888f4bc62a885b9b : SUCCESS in 18m 00s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/e8e345d5d1bd430680e544b68627acdb : SUCCESS in 12m 45s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/2434d63d10634736a46601960ac7a9ac : SUCCESS in 16m 41s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/4eb716e7ccfa4e75beda209e1d8bc62b : SUCCESS in 33m 10s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1676b6fc8e764dbb90deffe0061e0817 : SUCCESS in 40m 03s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/abf965d8337b40a98d91ae4207834b15 : SUCCESS in 33m 42s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/b3a7870716d84ce5af64229e2e2882af : SUCCESS in 29m 17s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fd102973bad34487b9b5ddbfd5c6c29b : SUCCESS in 18m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/618b4a670b2a4d97b8ddbb392159ab9a : SUCCESS in 6m 09s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/fa800c01b55847629091e8a7249337d9 : SUCCESS in 20m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3f7801aa0d0a49f8bdbae4dc0f668c0b : SUCCESS in 1h 14m 25s","accounts_in_message":[],"_revision_number":9},{"id":"1871317271f5fb6aec11a7e8ec092a78fff838ca","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2019-11-11 13:51:26.000000000","message":"Patch Set 9: Code-Review+2\n\nLGTM, but I\u0027m wondering if it would make sense to just change the SIGHUP behavior itself? This looks like a much better behavior that operators would want to use. It\u0027s not clear to me when they would prefer to keep using the SIGHUP over SIGUSR1, so why not just change SIGHUP?","accounts_in_message":[],"_revision_number":9},{"id":"fc21521b389311bfb4b6eb9db47541d5f838f59c","author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"date":"2019-11-11 17:21:47.000000000","message":"Patch Set 9:\n\n\u003e It\u0027s not clear to me when they would\n \u003e prefer to keep using the SIGHUP over SIGUSR1, so why not just\n \u003e change SIGHUP?\n\nIn my mind, it\u0027s akin to not changing the semantics/behavior of an existing config option deployers may be using and instead adding a new option with the new semantics.\n\nHaving something break because Swift upgraded, and nothing else changed, is something we try to avoid.  The behavior _is_ different, with the parent PID remaining the same.\n\nI\u0027m happy to adjust the patch to just change how SIGHUP works, but I think this way is a bit safer \u0026 nicer.\n\nUltimately, we need the new feature whether it\u0027s SIGHUP changing or the new SIGUSR1.  So whatever it takes to get the patch acceptable and merged.  Just let me know :)","accounts_in_message":[],"_revision_number":9},{"id":"fe8fd9054ecaf9cdd102da3d570f32eb86830cc8","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2019-11-14 19:02:31.000000000","message":"Patch Set 9: Code-Review+2 Workflow+1\n\nthis is definitely restarting the workers pids and causing new code to be picked up - and it\u0027s also definitely eliminating the big gaps of \"connection refused\"\n\npretty sure that\u0027s what it set out to do, and everything else seems to be order code/test wise - so I\u0027m pretty sure if there\u0027s more work todo somewhere I missed - we\u0027re better off on master iterating from here","accounts_in_message":[],"_revision_number":9},{"id":"357608d7983e67427f7aff2a8bc9cc10670e3211","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 19:03:45.000000000","message":"Patch Set 9: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":9},{"id":"dae7badbfbf86a6d40c3c783930249c1c3235310","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 20:34:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":9},{"id":"cebb5e6bb73b5c70cd1bf1dd6e1def0b41019ed3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 20:34:48.000000000","message":"Patch Set 9: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/87251ed7956c4005966892438a1e507c : SUCCESS in 5m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/08333fbb46e84021854831c7842c99bb : SUCCESS in 7m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c047de9f4ce04bec8ef0836c9da33f39 : SUCCESS in 8m 32s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0525c6e092cf4022a74648de3e8a8794 : SUCCESS in 1h 02m 03s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/fb7539e1a7d34efbb8e23a544785d092 : SUCCESS in 58m 30s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/a10ea54afd8948dcbd44118915e2eb24 : SUCCESS in 9m 03s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/1c70c0e611cd4286a8c5e5d9e04ddfe5 : SUCCESS in 10m 47s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/62dc39a839d94576887b40edf1a72656 : SUCCESS in 13m 04s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/d273b2a3f99c436ca23e331a71e1e315 : SUCCESS in 11m 27s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/3f3d970046f54db89b20c01ca895bfa0 : SUCCESS in 13m 28s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/dc020a96899b45be9f15eb02cf63da38 : SUCCESS in 12m 04s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/1c8016cb817746f49408a01ab4cf8f4c : SUCCESS in 11m 59s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/5b0b6f13d48f488f989fa4f0ac1c3fa8 : SUCCESS in 11m 57s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/755fcb734fe04faaa2604cfd43a2200a : SUCCESS in 12m 13s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/1f818d45c3ef4784bbc292b95bdba880 : SUCCESS in 15m 11s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/54547d3c4f3c4f2db65a22d1fe1c7b77 : SUCCESS in 11m 28s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/22192490e81346d590644d265e6588e2 : SUCCESS in 12m 58s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/af75f48980334a8ca41f57aff65ce879 : SUCCESS in 11m 14s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/97eadb17207342c598fb5c5b3cc90711 : SUCCESS in 13m 21s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a7f594da24e743a68d38012f16f52b48 : SUCCESS in 33m 37s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/0a600ab643c946fab176c2a7b34adc5b : SUCCESS in 37m 50s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/502a1bb72500490ea0c7d6ef7bfec789 : SUCCESS in 37m 20s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/8738613d18c142109da1881430479754 : SUCCESS in 34m 19s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/79a51c99520143b4906e114850382c85 : SUCCESS in 13m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc49374b144a40d6b49277515e41acce : SUCCESS in 7m 05s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9a84a7d4d76742ce88fe45f3521ce088 : SUCCESS in 1h 02m 06s","accounts_in_message":[],"_revision_number":9},{"id":"48b74946f0a825ee1146430d05e4654b23d8b5ce","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 20:37:05.000000000","message":"Patch Set 9:\n\nBuild succeeded (promote pipeline).\n\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/4a4d6ae37f864daa9dca0b4ba19cab4d : SUCCESS in 1m 25s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/520ea944dc274046b9cc09f158c22c75 : SUCCESS in 1m 16s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c76fbefb7cd84b33af2f6a34e92c7f3d : SUCCESS in 1m 38s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/85ff18f1ac0c464f88a9854ea9dcd3db : SUCCESS in 42s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/7c4df8acc28e4b5589d84bfed0c6bb01 : SUCCESS in 38s (non-voting)","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"1107f24179c0c6fdcb58771f3a6e6c025352b5d3","revisions":{"b8a5b2d0cd9cf51ec578a0de9f766290c6a19cf1":{"kind":"REWORK","_number":1,"created":"2019-10-25 19:49:52.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/1"}}},"commit":{"parents":[{"commit":"739c3704107bd991493472c18bfe7ac5f933077c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/739c3704107bd991493472c18bfe7ac5f933077c"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"subject":"WIP: prep for seamless WSGI server reload via SIGUSR1","message":"WIP: prep for seamless WSGI server reload via SIGUSR1\n\nThis is just some preparatory changes that I want to run through Zuul\nearly.  I think all tests should pass at this point.\n\nTODO: make SIGUSR1 do a seamless daemon reload and figure out how to\ntest that (functests? probetests?)\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b8a5b2d0cd9cf51ec578a0de9f766290c6a19cf1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b8a5b2d0cd9cf51ec578a0de9f766290c6a19cf1"}]},"branch":"refs/heads/master"},"c15042eee37b7834418bc2df8dba286c8f0b4583":{"kind":"REWORK","_number":2,"created":"2019-10-25 20:11:24.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/2"}}},"commit":{"parents":[{"commit":"739c3704107bd991493472c18bfe7ac5f933077c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/739c3704107bd991493472c18bfe7ac5f933077c"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 20:11:14.000000000","tz":-420},"subject":"WIP: prep for seamless WSGI server reload via SIGUSR1","message":"WIP: prep for seamless WSGI server reload via SIGUSR1\n\nThis is just some preparatory changes that I want to run through Zuul\nearly.  I think all tests should pass at this point.\n\nTODO: make SIGUSR1 do a seamless daemon reload and figure out how to\ntest that (functests? probetests?)\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c15042eee37b7834418bc2df8dba286c8f0b4583"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c15042eee37b7834418bc2df8dba286c8f0b4583"}]},"branch":"refs/heads/master"},"b61b00cb205fadd68c4d13019f63763ce2a13581":{"kind":"REWORK","_number":3,"created":"2019-11-01 00:19:44.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/3"}}},"commit":{"parents":[{"commit":"739c3704107bd991493472c18bfe7ac5f933077c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/739c3704107bd991493472c18bfe7ac5f933077c"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-01 00:13:20.000000000","tz":-420},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becomign a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b61b00cb205fadd68c4d13019f63763ce2a13581"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b61b00cb205fadd68c4d13019f63763ce2a13581"}]},"branch":"refs/heads/master"},"170a5d328742ab3435a09717861dbed2ea947187":{"kind":"REWORK","_number":4,"created":"2019-11-01 07:25:39.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/4"}}},"commit":{"parents":[{"commit":"739c3704107bd991493472c18bfe7ac5f933077c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/739c3704107bd991493472c18bfe7ac5f933077c"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-01 07:25:26.000000000","tz":-420},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becomign a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/170a5d328742ab3435a09717861dbed2ea947187"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/170a5d328742ab3435a09717861dbed2ea947187"}]},"branch":"refs/heads/master"},"e4a01e7a0df7b7d7a4b1d5166b022678b7e9991b":{"kind":"REWORK","_number":5,"created":"2019-11-01 15:28:42.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/5"}}},"commit":{"parents":[{"commit":"739c3704107bd991493472c18bfe7ac5f933077c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/739c3704107bd991493472c18bfe7ac5f933077c"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-01 15:28:33.000000000","tz":-420},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becomign a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e4a01e7a0df7b7d7a4b1d5166b022678b7e9991b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e4a01e7a0df7b7d7a4b1d5166b022678b7e9991b"}]},"branch":"refs/heads/master"},"600a88e3bc08a08892f6fbd380eee529e9ee9b8e":{"kind":"REWORK","_number":6,"created":"2019-11-01 19:20:27.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/6"}}},"commit":{"parents":[{"commit":"739c3704107bd991493472c18bfe7ac5f933077c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/739c3704107bd991493472c18bfe7ac5f933077c"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-01 19:20:16.000000000","tz":-420},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becomign a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/600a88e3bc08a08892f6fbd380eee529e9ee9b8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/600a88e3bc08a08892f6fbd380eee529e9ee9b8e"}]},"branch":"refs/heads/master"},"df72cc9f61392bc831a2601eca4cbf52be19bfbd":{"kind":"REWORK","_number":7,"created":"2019-11-01 22:27:49.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/7"}}},"commit":{"parents":[{"commit":"281ffab2a52f348aa3f8ad39e800a43c6047e1cf","subject":"pin lower-constraints to run against python 2.7","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/281ffab2a52f348aa3f8ad39e800a43c6047e1cf"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-01 22:27:43.000000000","tz":-420},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becomign a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/df72cc9f61392bc831a2601eca4cbf52be19bfbd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/df72cc9f61392bc831a2601eca4cbf52be19bfbd"}]},"branch":"refs/heads/master"},"c7253361900d2b9ea51a293c7bbd70f5d16dd9a3":{"kind":"REWORK","_number":8,"created":"2019-11-01 23:35:53.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/8"}}},"commit":{"parents":[{"commit":"281ffab2a52f348aa3f8ad39e800a43c6047e1cf","subject":"pin lower-constraints to run against python 2.7","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/281ffab2a52f348aa3f8ad39e800a43c6047e1cf"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-01 23:35:45.000000000","tz":-420},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becomign a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c7253361900d2b9ea51a293c7bbd70f5d16dd9a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c7253361900d2b9ea51a293c7bbd70f5d16dd9a3"}]},"branch":"refs/heads/master"},"1107f24179c0c6fdcb58771f3a6e6c025352b5d3":{"kind":"REWORK","_number":9,"created":"2019-11-07 18:16:30.000000000","uploader":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"ref":"refs/changes/23/691423/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/23/691423/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/23/691423/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/23/691423/9"}}},"commit":{"parents":[{"commit":"281ffab2a52f348aa3f8ad39e800a43c6047e1cf","subject":"pin lower-constraints to run against python 2.7","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/281ffab2a52f348aa3f8ad39e800a43c6047e1cf"}]}],"author":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-10-25 19:48:36.000000000","tz":-420},"committer":{"name":"Darrell Bishop","email":"darrell@swiftstack.com","date":"2019-11-07 18:15:26.000000000","tz":-480},"subject":"Seamlessly reload servers with SIGUSR1","message":"Seamlessly reload servers with SIGUSR1\n\nSwift servers can now be seamlessly reloaded by sending them a SIGUSR1\n(instead of a SIGHUP).  The server forks off a synchronized child to\nwait to close the old listen socket(s) until the new server has started\nup and bound its listen socket(s).  The new server is exec\u0027ed from the\nold one so its PID doesn\u0027t change.  This makes Systemd happier, so a\nReloadExec\u003d stanza can now be used.\n\nThe seamless part means that incoming connections will alwyas get\naccepted either by the old server or the new one.  This eliminates\nclient-perceived \"downtime\" during server reloads, while allowing the\nserver to fully reload, re-reading configuration, becoming a fresh\nPython interpreter instance, etc.  The SO_REUSEPORT socket option has\nalready been getting used, so nothing had to change there.\n\nThis patch also includes a non-invasive fix for a current eventlet bug;\nsee https://github.com/eventlet/eventlet/pull/590\nThat bug prevents a SIGHUP \"reload\" from properly servicing existing\nrequests before old worker processes close sockets and exit.  The\nexisting probtests missed this, but the new ones, in this patch, caught\nit.\n\nNew probe tests cover both old SIGHUP \"reload\" behavior as well as the\nnew SIGUSR1 seamless reload behavior.\n\nChange-Id: I3e5229d2fb04be67e53533ff65b0870038accbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1107f24179c0c6fdcb58771f3a6e6c025352b5d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1107f24179c0c6fdcb58771f3a6e6c025352b5d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}