)]}'
{"swift/common/middleware/acl.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"eb97fac9a0a4cd4552c58f4c6641161ef1b2ea41","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    data \u003d req.headers.get(\u0027X-Account-Access-Control\u0027)"},{"line_number":303,"context_line":"    if data is None:"},{"line_number":304,"context_line":"        return None"},{"line_number":305,"context_line":"    acl_dict \u003d parse_acl(version\u003d2, data\u003ddata)"},{"line_number":306,"context_line":"    if not (acl_dict or data in (\u0027\u0027, \u0027{}\u0027)):"},{"line_number":307,"context_line":"        # parse_acl returned nothing but data wasn\u0027t empty -- json error"},{"line_number":308,"context_line":"        raise ValueError(\u0027Syntax error in ACL (%r)\u0027 % data)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BeLU%3D","line":305,"updated":"2014-02-21 01:59:02.000000000","message":"I could swear we had a patch just recently that verified that it was actually a dict.","commit_id":"45feab5dd64af81054315678a7eae36d73300b41"},{"author":{"_account_id":8262,"name":"Jon Snitow","email":"otherjon@swiftstack.com","username":"otherjon"},"change_message_id":"d58c52519851fbb6ce301d15bdce2619900c67e3","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    data \u003d req.headers.get(\u0027X-Account-Access-Control\u0027)"},{"line_number":303,"context_line":"    if data is None:"},{"line_number":304,"context_line":"        return None"},{"line_number":305,"context_line":"    acl_dict \u003d parse_acl(version\u003d2, data\u003ddata)"},{"line_number":306,"context_line":"    if not (acl_dict or data in (\u0027\u0027, \u0027{}\u0027)):"},{"line_number":307,"context_line":"        # parse_acl returned nothing but data wasn\u0027t empty -- json error"},{"line_number":308,"context_line":"        raise ValueError(\u0027Syntax error in ACL (%r)\u0027 % data)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAU3%2F%2FwcE%3D","line":305,"in_reply_to":"AAAAUX%2F%2BeLU%3D","updated":"2014-02-24 23:01:34.000000000","message":"You would be swearing the truth.  This patch was written first, that patch landed first.  Updating and rebasing this patch now.\n\nThanks for having a look at this one.","commit_id":"45feab5dd64af81054315678a7eae36d73300b41"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2d598608c0528cd335e1bdcb3e905ef2272cd727","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    return allow"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def acls_from_account_info(info):"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    Extract the account ACLs from the given account_info, and return the ACLs."},{"line_number":278,"context_line":"    Account ACLs are assumed to be in TempAuth-style format."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVX%2F%2FxDc%3D","line":275,"updated":"2014-02-28 12:43:07.000000000","message":"very nit picking, but might the function name reflect that it is tempauth specific in same manner that dict_to_tempauth_acl does?","commit_id":"e32ca6740ba64d92464493a1e899872a130b5927"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2d598608c0528cd335e1bdcb3e905ef2272cd727","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    return dict_to_tempauth_acl(acl_dict)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"def acls_from_request_headers(req):"},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    Extract the account ACLs from the request\u0027s headers, and return the ACLs."},{"line_number":297,"context_line":"    Account ACLs are assumed to be in TempAuth-style format."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVX%2F%2FxDQ%3D","line":294,"updated":"2014-02-28 12:43:07.000000000","message":"ditto re tempauth specific function name","commit_id":"e32ca6740ba64d92464493a1e899872a130b5927"}],"test/functional/test_account.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2d598608c0528cd335e1bdcb3e905ef2272cd727","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            return check_response(conn)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # needs to be an acceptable header size"},{"line_number":80,"context_line":"        acl \u003d {\u0027admin\u0027: [chr(c) * 1024 for c in range(97, 97 + 8)]}"},{"line_number":81,"context_line":"        headers \u003d {\u0027x-account-access-control\u0027: format_acl("},{"line_number":82,"context_line":"            version\u003d2, acl_dict\u003dacl)}"},{"line_number":83,"context_line":"        resp \u003d retry(post, headers\u003dheaders, use_account\u003d1)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2FZPY%3D","line":80,"updated":"2014-02-28 12:43:07.000000000","message":"I think this is testing a generic header size constraint rather than a size limit specifically imposed on account acls? MAX_HEADER_SIZE is configurable in swift.conf so this test fails against a cluster if it is set \u003e8192. Not saying that\u0027s likely, but it is allowed.\n\nBut then I have other functional tests fail if I deviate from default constraints, so not sure if this is a valid concern or not.","commit_id":"e32ca6740ba64d92464493a1e899872a130b5927"}]}