)]}'
{"test/probe/common.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"79c4f1e4dcfdeedbe36c006a3e6531debd5efdea","unresolved":false,"context_lines":[{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def make_internal_client(self, **opts):"},{"line_number":478,"context_line":"        config_opts \u003d {"},{"line_number":479,"context_line":"            \u0027allow_account_management\u0027: False"},{"line_number":480,"context_line":"        }"},{"line_number":481,"context_line":"        config_opts.update(**opts)"},{"line_number":482,"context_line":"        tempdir \u003d mkdtemp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8cfc2f0d","line":479,"updated":"2019-11-11 19:36:49.000000000","message":"yeah, so the defaults here aren\u0027t very DRY with the defaults in proxy.server","commit_id":"5e031fb4319d17c6dd35db49590275f1258ec58f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"14afc4f08bd93acea20757e5131fe787899ac55b","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"            [app:proxy-server]"},{"line_number":493,"context_line":"            use \u003d egg:swift#proxy"},{"line_number":494,"context_line":"            allow_account_management \u003d %(allow_account_management)s"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"            [filter:copy]"},{"line_number":497,"context_line":"            use \u003d egg:swift#copy"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3498f173","line":494,"updated":"2019-11-08 15:53:35.000000000","message":"Should this just always be true? (Right here, in this test, I mean.) I can\u0027t think of an obvious reason that it shouldn\u0027t be true.","commit_id":"5e031fb4319d17c6dd35db49590275f1258ec58f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"79c4f1e4dcfdeedbe36c006a3e6531debd5efdea","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"            [app:proxy-server]"},{"line_number":493,"context_line":"            use \u003d egg:swift#proxy"},{"line_number":494,"context_line":"            allow_account_management \u003d %(allow_account_management)s"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"            [filter:copy]"},{"line_number":497,"context_line":"            use \u003d egg:swift#copy"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2c0bbb22","line":494,"in_reply_to":"3fa7e38b_3498f173","updated":"2019-11-11 19:36:49.000000000","message":"yeah, the one and only test setup that uses this new interface to pass a config_opt to make_internal_client sets this value to True\n\n... but any other tests using the interface have no behavior change, and presumably this interface would allow that to continue to be the case even after other new options are added to this template.","commit_id":"5e031fb4319d17c6dd35db49590275f1258ec58f"}],"test/probe/test_account_reaper.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"14afc4f08bd93acea20757e5131fe787899ac55b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         len(ENABLED_POLICIES) * len(body))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        swift \u003d self.make_internal_client(allow_account_management\u003dTrue)"},{"line_number":56,"context_line":"        swift.delete_account(self.account)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _verify_account_reaped(self):"},{"line_number":59,"context_line":"        for policy, container, obj in self.all_objects:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d49ddd6c","line":56,"updated":"2019-11-08 15:53:35.000000000","message":"Is there value in knowing that we hit all three primaries? This wouldn\u0027t raise an exception as long as 2/3 got marked as deleted, right? And replication\u0027s not going to square it, currently...\n\nDo we know off hand what we expect proxy-server clients to see when some but not all replicas are marked for deletion?","commit_id":"5e031fb4319d17c6dd35db49590275f1258ec58f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"79c4f1e4dcfdeedbe36c006a3e6531debd5efdea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         len(ENABLED_POLICIES) * len(body))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        swift \u003d self.make_internal_client(allow_account_management\u003dTrue)"},{"line_number":56,"context_line":"        swift.delete_account(self.account)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _verify_account_reaped(self):"},{"line_number":59,"context_line":"        for policy, container, obj in self.all_objects:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e615c14a","line":56,"in_reply_to":"3fa7e38b_d49ddd6c","updated":"2019-11-11 19:36:49.000000000","message":"there must be other places in probe tests were we use a proxy to talk to all three primaries... but I honestly hadn\u0027t considered the difference in behavior in the failure case.\n\nFrom my reading if the first primary fails to be marked DELETED the rest of the tests will fail.\n\nIt looks like these tests mostly do direct requests - so the proxy behavior might not matter much.  I think generally it\u0027d be fairly lax with inconsistent results.","commit_id":"5e031fb4319d17c6dd35db49590275f1258ec58f"}]}