)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"2bcb960e4cd8db93566052077694b21361875d90","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        This call bypasses auth. Success does not imply that the request has"},{"line_number":302,"context_line":"        authorization to the object."},{"line_number":303,"context_line":"    \"\"\""},{"line_number":304,"context_line":"    (version, account, container, obj) \u003d \\"},{"line_number":305,"context_line":"        split_path(path or env[\u0027PATH_INFO\u0027], 4, 4, True)"},{"line_number":306,"context_line":"    info \u003d _get_object_info(app, env, account, container, obj,"},{"line_number":307,"context_line":"                            swift_source\u003dswift_source)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8476340b","line":304,"range":{"start_line":304,"start_character":5,"end_line":304,"end_character":12},"updated":"2020-01-16 21:24:00.000000000","message":"would it make sense to add a check here too?","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b314f756bec17deef915a841ac675e5e34293d76","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        This call bypasses auth. Success does not imply that the request has"},{"line_number":302,"context_line":"        authorization to the object."},{"line_number":303,"context_line":"    \"\"\""},{"line_number":304,"context_line":"    (version, account, container, obj) \u003d \\"},{"line_number":305,"context_line":"        split_path(path or env[\u0027PATH_INFO\u0027], 4, 4, True)"},{"line_number":306,"context_line":"    info \u003d _get_object_info(app, env, account, container, obj,"},{"line_number":307,"context_line":"                            swift_source\u003dswift_source)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_47afde7b","line":304,"range":{"start_line":304,"start_character":5,"end_line":304,"end_character":12},"in_reply_to":"3fa7e38b_8476340b","updated":"2020-01-16 22:25:29.000000000","message":"Sure, I can add it. I\u0027m not sure who\u0027s ever actually *used* this interface, though...","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"2bcb960e4cd8db93566052077694b21361875d90","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    if not constraints.valid_api_version(version):"},{"line_number":336,"context_line":"        # Not a valid Swift request; return 0 like we do"},{"line_number":337,"context_line":"        # if there\u0027s an account failure"},{"line_number":338,"context_line":"        return headers_to_container_info({}, 0)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    account \u003d wsgi_to_str(wsgi_account)"},{"line_number":341,"context_line":"    container \u003d wsgi_to_str(wsgi_container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_64ea1878","line":338,"range":{"start_line":338,"start_character":45,"end_line":338,"end_character":46},"updated":"2020-01-16 21:24:00.000000000","message":"wondering if 503[1] or even 400 would make more sense?\n\n[1] - similar to lines 381 and 454","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b314f756bec17deef915a841ac675e5e34293d76","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    if not constraints.valid_api_version(version):"},{"line_number":336,"context_line":"        # Not a valid Swift request; return 0 like we do"},{"line_number":337,"context_line":"        # if there\u0027s an account failure"},{"line_number":338,"context_line":"        return headers_to_container_info({}, 0)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    account \u003d wsgi_to_str(wsgi_account)"},{"line_number":341,"context_line":"    container \u003d wsgi_to_str(wsgi_container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c73d0e2a","line":338,"range":{"start_line":338,"start_character":45,"end_line":338,"end_character":46},"in_reply_to":"3fa7e38b_64ea1878","updated":"2020-01-16 22:25:29.000000000","message":"*shrug*\n\nIIRC my reasoning was that\n\n* 503 should be for when we attempt some backend requests but then we hit some sort of failure such that we have no info (likely failure to meet quorum), while\n* 0 should be for when there\u0027s some sort of problem the means we won\u0027t even make backend requests\n\nbut I could probably be persuaded in some other direction.","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"af415ea0ae88822459f06b4bc7d1a6afa486f173","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    if not constraints.valid_api_version(version):"},{"line_number":336,"context_line":"        # Not a valid Swift request; return 0 like we do"},{"line_number":337,"context_line":"        # if there\u0027s an account failure"},{"line_number":338,"context_line":"        return headers_to_container_info({}, 0)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    account \u003d wsgi_to_str(wsgi_account)"},{"line_number":341,"context_line":"    container \u003d wsgi_to_str(wsgi_container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c7750ecb","line":338,"range":{"start_line":338,"start_character":45,"end_line":338,"end_character":46},"in_reply_to":"3fa7e38b_c73d0e2a","updated":"2020-01-16 23:01:26.000000000","message":"Yeah 0 WFM\n\n    \u003e\u003e\u003e from swift.common.http import is_success\n    \u003e\u003e\u003e is_success(0)\n    False","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"}],"test/unit/proxy/controllers/test_base.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"af415ea0ae88822459f06b4bc7d1a6afa486f173","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        fake_cache \u003d FakeCache({})"},{"line_number":544,"context_line":"        req \u003d Request.blank(\"/non-swift/AUTH_account\","},{"line_number":545,"context_line":"                            environ\u003d{\u0027swift.cache\u0027: fake_cache})"},{"line_number":546,"context_line":"        info \u003d get_account_info(req.environ, FakeApp(statuses\u003d[400]))"},{"line_number":547,"context_line":"        self.assertEqual(info[\u0027status\u0027], 0)"},{"line_number":548,"context_line":"        # *not* cached"},{"line_number":549,"context_line":"        key \u003d get_cache_key(\"AUTH_account\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_47f03efd","line":546,"updated":"2020-01-16 23:01:26.000000000","message":"Yeah I mean the status doesn\u0027t make much difference to this test since the request is never made..","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"af415ea0ae88822459f06b4bc7d1a6afa486f173","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        req \u003d Request.blank(\"/non-swift/AUTH_account\","},{"line_number":545,"context_line":"                            environ\u003d{\u0027swift.cache\u0027: fake_cache})"},{"line_number":546,"context_line":"        info \u003d get_account_info(req.environ, FakeApp(statuses\u003d[400]))"},{"line_number":547,"context_line":"        self.assertEqual(info[\u0027status\u0027], 0)"},{"line_number":548,"context_line":"        # *not* cached"},{"line_number":549,"context_line":"        key \u003d get_cache_key(\"AUTH_account\")"},{"line_number":550,"context_line":"        self.assertNotIn(key, fake_cache.store)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_27c6629e","line":547,"updated":"2020-01-16 23:01:26.000000000","message":"really this is the part that fails if you revert the change","commit_id":"b65d8b10c5ea1c897bcb02c97943af82fd27d578"}]}