)]}'
{"test/probe/test_signals.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a2afa979028c15118844bc2a6d37a15660362465","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        self.swift_conf_path \u003d \u0027/etc/swift/swift.conf\u0027"},{"line_number":279,"context_line":"        self.new_swift_conf_path \u003d self.swift_conf_path + \u0027.new\u0027"},{"line_number":280,"context_line":"        self.saved_swift_conf_path \u003d self.swift_conf_path + \u0027.orig\u0027"},{"line_number":281,"context_line":"        shutil.copy(self.swift_conf_path, self.saved_swift_conf_path)"},{"line_number":282,"context_line":"        with open(self.swift_conf_path, \u0027r\u0027) as rfh:"},{"line_number":283,"context_line":"            config \u003d rfh.read()"},{"line_number":284,"context_line":"            section_header \u003d \u0027\\n[swift-constraints]\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b2c8fc20","line":281,"updated":"2020-01-04 15:40:55.000000000","message":"Wait a moment, are we seriously having a test that tries to modify something in the system /etc/swift/? How does it even have a permission? On my laptop /etc/swift is where my SAIO lives and I run tests as zaitcev.","commit_id":"8fc83015bbfa5cae633b9f4f19572718d893fe3b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e4e4fc14e4d2bf22b36caccf94a111b0fc0636bb","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        self.swift_conf_path \u003d \u0027/etc/swift/swift.conf\u0027"},{"line_number":279,"context_line":"        self.new_swift_conf_path \u003d self.swift_conf_path + \u0027.new\u0027"},{"line_number":280,"context_line":"        self.saved_swift_conf_path \u003d self.swift_conf_path + \u0027.orig\u0027"},{"line_number":281,"context_line":"        shutil.copy(self.swift_conf_path, self.saved_swift_conf_path)"},{"line_number":282,"context_line":"        with open(self.swift_conf_path, \u0027r\u0027) as rfh:"},{"line_number":283,"context_line":"            config \u003d rfh.read()"},{"line_number":284,"context_line":"            section_header \u003d \u0027\\n[swift-constraints]\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0dcc5588","line":281,"in_reply_to":"3fa7e38b_b2c8fc20","updated":"2020-01-05 05:36:02.000000000","message":"Yeah, this makes me a bit squeamish, too -- but IDK that we\u0027ve ever really focused on making sure probe tests run with a non-standard SWIFT_CONF_FILE. As long as /etc/swift has \"appropriate\" permisions, this should be fine, I guess?\n\nAt any rate, seems like what I\u0027m doing is no worse than it already is on master.\n\nThis reminds me, we never did get around to https://review.opendev.org/#/c/393952/ ...","commit_id":"8fc83015bbfa5cae633b9f4f19572718d893fe3b"}]}