)]}'
{"swift/common/utils.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"53e10d2a5e2055dbf139fa8b72546991275a97c3","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"            try:"},{"line_number":1356,"context_line":"                other \u003d Timestamp(other)"},{"line_number":1357,"context_line":"            except ValueError:"},{"line_number":1358,"context_line":"                return False"},{"line_number":1359,"context_line":"        return self.internal \u003d\u003d other.internal"},{"line_number":1360,"context_line":""},{"line_number":1361,"context_line":"    def __ne__(self, other):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8d53b73a","line":1358,"updated":"2020-01-17 02:54:37.000000000","message":"OK. self should be in the range and when the other got ValueError, it must not equal to self.","commit_id":"c4565834f9d9be9bba9bc182bab949bdc4cc7664"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"604e9268f8106619fcfd68f0b61faffeebf1fc3e","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"            try:"},{"line_number":1356,"context_line":"                other \u003d Timestamp(other)"},{"line_number":1357,"context_line":"            except ValueError:"},{"line_number":1358,"context_line":"                return False"},{"line_number":1359,"context_line":"        return self.internal \u003d\u003d other.internal"},{"line_number":1360,"context_line":""},{"line_number":1361,"context_line":"    def __ne__(self, other):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ef59f85b","line":1358,"in_reply_to":"3fa7e38b_8d53b73a","updated":"2020-01-17 18:48:19.000000000","message":"With my other changes, I\u0027m not sure this is strictly necessary... but I think I\u0027ll keep it.","commit_id":"c4565834f9d9be9bba9bc182bab949bdc4cc7664"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"53e10d2a5e2055dbf139fa8b72546991275a97c3","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"            if other \u003c 0:"},{"line_number":1370,"context_line":"                return False"},{"line_number":1371,"context_line":"            if other \u003e\u003d 10000000000:"},{"line_number":1372,"context_line":"                return True"},{"line_number":1373,"context_line":"        if not isinstance(other, Timestamp):"},{"line_number":1374,"context_line":"            other \u003d Timestamp(other)"},{"line_number":1375,"context_line":"        return self.internal \u003c other.internal"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0d3587f6","line":1372,"updated":"2020-01-17 02:54:37.000000000","message":"Do we have to care str object like \"100000000000\"?\nI don\u0027t check whole Swift code yet but if it\u0027s smaller (or greater) than caps, sort of `Timestamp().now() \u003d\u003c \"100\"` works.\n\nBut even with current code, I got:\n\n\u003e\u003e\u003e Timestamp.now() \u003c \"100000000000000\"\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"swift/common/utils.py\", line 1375, in __lt__\n    other \u003d Timestamp(other)\n  File \"swift/common/utils.py\", line 1281, in __init__\n    raise ValueError(\u0027timestamp too large\u0027)\nValueError: timestamp too large","commit_id":"c4565834f9d9be9bba9bc182bab949bdc4cc7664"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"604e9268f8106619fcfd68f0b61faffeebf1fc3e","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"            if other \u003c 0:"},{"line_number":1370,"context_line":"                return False"},{"line_number":1371,"context_line":"            if other \u003e\u003d 10000000000:"},{"line_number":1372,"context_line":"                return True"},{"line_number":1373,"context_line":"        if not isinstance(other, Timestamp):"},{"line_number":1374,"context_line":"            other \u003d Timestamp(other)"},{"line_number":1375,"context_line":"        return self.internal \u003c other.internal"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6f5d0853","line":1372,"in_reply_to":"3fa7e38b_0d3587f6","updated":"2020-01-17 18:48:19.000000000","message":"Done","commit_id":"c4565834f9d9be9bba9bc182bab949bdc4cc7664"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"902b415908404900eb1d4ff2b35a8b666454474f","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"            try:"},{"line_number":1357,"context_line":"                other \u003d Timestamp(other, check_bounds\u003dFalse)"},{"line_number":1358,"context_line":"            except ValueError:"},{"line_number":1359,"context_line":"                return False"},{"line_number":1360,"context_line":"        return self.internal \u003d\u003d other.internal"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    def __ne__(self, other):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1ce6ad4b","line":1359,"updated":"2020-01-24 16:08:58.000000000","message":"I don\u0027t know about this whole, check_bounds\u003dFalse thing... seems like the main win is catching the ValueError and returning False","commit_id":"57ca3570e911bd290ce0e44bdebaa4b5b4ceca13"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"902b415908404900eb1d4ff2b35a8b666454474f","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"        if other is None:"},{"line_number":1367,"context_line":"            return False"},{"line_number":1368,"context_line":"        if not isinstance(other, Timestamp):"},{"line_number":1369,"context_line":"            other \u003d Timestamp(other, check_bounds\u003dFalse)"},{"line_number":1370,"context_line":"        if other.timestamp \u003c 0:"},{"line_number":1371,"context_line":"            return False"},{"line_number":1372,"context_line":"        if other.timestamp \u003e\u003d 10000000000:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dceb350e","line":1369,"updated":"2020-01-24 16:08:58.000000000","message":"I guess this was what was blowing up in the related bug?\n\nvagrant@saio:~$ swift stat 7b681a706bd24857873512d6df9b905a x_delete_at_in_the_far_future\n               Account: AUTH_test\n             Container: 7b681a706bd24857873512d6df9b905a\n                Object: x_delete_at_in_the_far_future\n          Content Type: application/octet-stream\n        Content Length: 0\n         Last Modified: Fri, 24 Jan 2020 15:25:39 GMT\n                  ETag: d41d8cd98f00b204e9800998ecf8427e\n           X-Delete-At: 1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111\n         Accept-Ranges: bytes\n           X-Timestamp: 1579879538.67292\n            X-Trans-Id: tx85fb062321154a119d32b-005e2b0d14\nX-Openstack-Request-Id: tx85fb062321154a119d32b-005e2b0d14","commit_id":"57ca3570e911bd290ce0e44bdebaa4b5b4ceca13"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"53e10d2a5e2055dbf139fa8b72546991275a97c3","unresolved":false,"context_lines":[{"line_number":875,"context_line":"        self.assertTrue(now \u003e\u003d -0.1)"},{"line_number":876,"context_line":"        self.assertTrue(now \u003e -0.1)"},{"line_number":877,"context_line":"        self.assertTrue(-0.1 \u003c now)"},{"line_number":878,"context_line":"        self.assertTrue(-0.1 \u003c\u003d now)"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"class TestTimestampEncoding(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4db85f77","line":878,"updated":"2020-01-17 02:54:37.000000000","message":"Should we add `\u003d\u003d` comparison tests too? those should be False.","commit_id":"c4565834f9d9be9bba9bc182bab949bdc4cc7664"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"604e9268f8106619fcfd68f0b61faffeebf1fc3e","unresolved":false,"context_lines":[{"line_number":875,"context_line":"        self.assertTrue(now \u003e\u003d -0.1)"},{"line_number":876,"context_line":"        self.assertTrue(now \u003e -0.1)"},{"line_number":877,"context_line":"        self.assertTrue(-0.1 \u003c now)"},{"line_number":878,"context_line":"        self.assertTrue(-0.1 \u003c\u003d now)"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"class TestTimestampEncoding(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_af53003a","line":878,"in_reply_to":"3fa7e38b_4db85f77","updated":"2020-01-17 18:48:19.000000000","message":"Done","commit_id":"c4565834f9d9be9bba9bc182bab949bdc4cc7664"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"902b415908404900eb1d4ff2b35a8b666454474f","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        check_is_earlier(-0.1)"},{"line_number":888,"context_line":"        check_is_earlier(\u0027-9999999\u0027)"},{"line_number":889,"context_line":"        check_is_earlier(b\u0027-9999.999\u0027)"},{"line_number":890,"context_line":"        check_is_earlier(u\u0027-1234_5678\u0027)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"class TestTimestampEncoding(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dc06d574","line":890,"updated":"2020-01-24 16:08:58.000000000","message":"solid!","commit_id":"57ca3570e911bd290ce0e44bdebaa4b5b4ceca13"}]}