)]}'
{"bin/swift":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"01d906480348d30be9c1453fdc1d1b98abbe63bb","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    \"\"\""},{"line_number":181,"context_line":"    Return a connection building it from the options."},{"line_number":182,"context_line":"    \"\"\""},{"line_number":183,"context_line":"    auth_version \u003d options.auth_version2 and 2 or 1"},{"line_number":184,"context_line":"    return Connection(options.auth, options.user, options.key,"},{"line_number":185,"context_line":"                      snet\u003doptions.snet, auth_version\u003dauth_version)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BTc%3D","line":183,"updated":"2011-09-28 15:30:27.000000000","message":"I\u0027d prefer an if block here. It would be more clear.","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"81b56b5bbb107a01fd70e77bcc239f98dd5902d0","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    \"\"\""},{"line_number":181,"context_line":"    Return a connection building it from the options."},{"line_number":182,"context_line":"    \"\"\""},{"line_number":183,"context_line":"    auth_version \u003d options.auth_version2 and 2 or 1"},{"line_number":184,"context_line":"    return Connection(options.auth, options.user, options.key,"},{"line_number":185,"context_line":"                      snet\u003doptions.snet, auth_version\u003dauth_version)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BR0%3D","line":183,"in_reply_to":"AAAACX%2F%2F%2BTc%3D","updated":"2011-09-28 15:57:24.000000000","message":"Done","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"01d906480348d30be9c1453fdc1d1b98abbe63bb","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                pass"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            body \u003d None"},{"line_number":226,"context_line":"        if resp.status in (400, 401, 403, 404, 408, 413, 500, 501):"},{"line_number":227,"context_line":"            raise ClientException(\u0027Auth GET failed\u0027, http_scheme\u003dparsed.scheme,"},{"line_number":228,"context_line":"                                  http_host\u003dconn.host,"},{"line_number":229,"context_line":"                                  http_port\u003dconn.port,"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BTk%3D","line":226,"updated":"2011-09-28 15:30:27.000000000","message":"shouldn\u0027t this check any non-200 response?","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"81b56b5bbb107a01fd70e77bcc239f98dd5902d0","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                pass"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            body \u003d None"},{"line_number":226,"context_line":"        if resp.status in (400, 401, 403, 404, 408, 413, 500, 501):"},{"line_number":227,"context_line":"            raise ClientException(\u0027Auth GET failed\u0027, http_scheme\u003dparsed.scheme,"},{"line_number":228,"context_line":"                                  http_host\u003dconn.host,"},{"line_number":229,"context_line":"                                  http_port\u003dconn.port,"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BRs%3D","line":226,"in_reply_to":"AAAACX%2F%2F%2BTk%3D","updated":"2011-09-28 15:57:24.000000000","message":"Done","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"01d906480348d30be9c1453fdc1d1b98abbe63bb","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    resp, body \u003d json_request(\"POST\", token_url, body\u003dbody)"},{"line_number":238,"context_line":"    if not body:"},{"line_number":239,"context_line":"        raise ClientException(\"Error while getting answers from auth server\")"},{"line_number":240,"context_line":"    return body[\u0027auth\u0027][\u0027serviceCatalog\u0027][\u0027swift\u0027][0][\u0027publicURL\u0027], \\"},{"line_number":241,"context_line":"        body[\u0027auth\u0027][\u0027token\u0027][\u0027id\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BTU%3D","line":240,"updated":"2011-09-28 15:30:27.000000000","message":"seems ripe for a KeyError or IndexError here","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"05815f74604ab5fa535d2b5722866d2c0987a8e2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    resp, body \u003d json_request(\"POST\", token_url, body\u003dbody)"},{"line_number":238,"context_line":"    if not body:"},{"line_number":239,"context_line":"        raise ClientException(\"Error while getting answers from auth server\")"},{"line_number":240,"context_line":"    return body[\u0027auth\u0027][\u0027serviceCatalog\u0027][\u0027swift\u0027][0][\u0027publicURL\u0027], \\"},{"line_number":241,"context_line":"        body[\u0027auth\u0027][\u0027token\u0027][\u0027id\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BRk%3D","line":240,"in_reply_to":"AAAACX%2F%2F%2BRw%3D","updated":"2011-09-28 15:59:48.000000000","message":"I was thinking of a simple try/except block","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"81b56b5bbb107a01fd70e77bcc239f98dd5902d0","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    resp, body \u003d json_request(\"POST\", token_url, body\u003dbody)"},{"line_number":238,"context_line":"    if not body:"},{"line_number":239,"context_line":"        raise ClientException(\"Error while getting answers from auth server\")"},{"line_number":240,"context_line":"    return body[\u0027auth\u0027][\u0027serviceCatalog\u0027][\u0027swift\u0027][0][\u0027publicURL\u0027], \\"},{"line_number":241,"context_line":"        body[\u0027auth\u0027][\u0027token\u0027][\u0027id\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BRw%3D","line":240,"in_reply_to":"AAAACX%2F%2F%2BTU%3D","updated":"2011-09-28 15:57:24.000000000","message":"Yep I was thinking exactly the same but I am not sure how to streamline I can do bunch of :\n\nif \u0027auth\u0027 in body and \u0027serviceCatalog\u0027 in body[\u0027auth\u0027] etc.....\n\ndo you think that would make it more robust? I do make sure already that body is defined.","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"01d906480348d30be9c1453fdc1d1b98abbe63bb","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    if auth_version \u003d\u003d 1:"},{"line_number":263,"context_line":"        return _get_auth_v1(url, user, key, snet)"},{"line_number":264,"context_line":"    elif auth_version \u003d\u003d 2:"},{"line_number":265,"context_line":"        #Not supporting snet at the moment with v2"},{"line_number":266,"context_line":"        return _get_auth_v2(url, user, key)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAACX%2F%2F%2BTQ%3D","line":265,"updated":"2011-09-28 15:30:27.000000000","message":"why no snet in v2?","commit_id":"faa38e2f51d1d46011c3049c351a7c150fabe6a5"}]}