)]}'
{"test/unit/common/middleware/s3api/test_s3api.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b48c29ba3793f021edda005385c896c94f64cb31","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        _, _, headers \u003d self.swift.calls_with_headers[-1]"},{"line_number":511,"context_line":"        self.assertEqual(req.environ[\u0027s3api.auth_details\u0027], {"},{"line_number":512,"context_line":"            \u0027access_key\u0027: (u\u0027test:\\N{SNOWMAN}\u0027.encode(\u0027utf-8\u0027) if six.PY2"},{"line_number":513,"context_line":"                           else u\u0027test:\\N{SNOWMAN}\u0027),"},{"line_number":514,"context_line":"            \u0027signature\u0027: \u0027sig\u0027,"},{"line_number":515,"context_line":"            \u0027string_to_sign\u0027: b\u0027\\n\u0027.join(["},{"line_number":516,"context_line":"                b\u0027PUT\u0027, b\u0027\u0027, b\u0027\u0027, date_header.encode(\u0027ascii\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_795e9a79","line":513,"updated":"2020-01-29 15:08:23.000000000","message":"so in py2 we expect it to be unicode!?   This test doesn\u0027t seem to fail on py2 with the change reverted...","commit_id":"bd063b678992a710f423a86d392a34237a8379ba"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b9d5619f8ba819dfcf0e7d1d91bfa21d0333f481","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        _, _, headers \u003d self.swift.calls_with_headers[-1]"},{"line_number":511,"context_line":"        self.assertEqual(req.environ[\u0027s3api.auth_details\u0027], {"},{"line_number":512,"context_line":"            \u0027access_key\u0027: (u\u0027test:\\N{SNOWMAN}\u0027.encode(\u0027utf-8\u0027) if six.PY2"},{"line_number":513,"context_line":"                           else u\u0027test:\\N{SNOWMAN}\u0027),"},{"line_number":514,"context_line":"            \u0027signature\u0027: \u0027sig\u0027,"},{"line_number":515,"context_line":"            \u0027string_to_sign\u0027: b\u0027\\n\u0027.join(["},{"line_number":516,"context_line":"                b\u0027PUT\u0027, b\u0027\u0027, b\u0027\u0027, date_header.encode(\u0027ascii\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8ddc7017","line":513,"in_reply_to":"3fa7e38b_795e9a79","updated":"2020-01-29 18:11:39.000000000","message":"On py2 we expect it to be bytes -- u\u0027test:\\N{SNOWMAN}\u0027.encode(\u0027utf-8\u0027) gets you \u0027test:\\xe2\\x98\\x83\u0027.\n\nPreviously we had these as WSGI strings, which is to say, native strings on py2 and crazy-town bytes-masquerading-as-unicode on py3. This patch has no change in behavior on py2, so it makes sense that the new test would pass on master with py2.","commit_id":"bd063b678992a710f423a86d392a34237a8379ba"}]}