)]}'
{"id":"openstack%2Fswift~704435","triplet_id":"openstack%2Fswift~master~Ic53068867feb0c18c88ddbe029af83a970336545","project":"openstack/swift","branch":"master","topic":"bug/1300850","hashtags":[],"change_id":"Ic53068867feb0c18c88ddbe029af83a970336545","subject":"Mark a container reported if account was reclaimed","status":"NEW","created":"2020-01-27 21:29:06.000000000","updated":"2020-06-20 06:48:04.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"67949d6eb9ed726997038cc3662697f92a9a9b90","_number":704435,"virtual_id_number":704435,"owner":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-06-20 06:48:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":-1,"date":"2020-06-20 05:43:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-19 23:45:00.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2020-03-28 13:32:45.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2020-06-20 00:52:52.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2020-06-20 06:48:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"114c95883784f37d8d5f4a93567f6d15f3343691","author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"date":"2020-01-27 21:29:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aa8585e5c098452d0064f7f1fcb58d7c0a44a00f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-01-27 21:57:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ee5afe3b918a375003514bc5dd0576dfa301b9f3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-27 22:39:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d83782a8bc814820941a79d3c7d361b0 : SUCCESS in 11m 14s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/03ada8cb1e514c0ba2a9da51b1ca5576 : SUCCESS in 1h 04m 23s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/4915f4838fd2407780de911fbb7cdcaf : SUCCESS in 53m 40s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/4ef411f8780b4578a7d97fba1ab088d1 : SUCCESS in 12m 41s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/ffd6ce8aee3c46b4a44b9c4f453304a6 : SUCCESS in 12m 49s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/9f3501a9949b46f8becad66fb4c68d07 : SUCCESS in 15m 11s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/32ed09a752cc42c4b32d350ece077502 : SUCCESS in 16m 30s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/905a6628796046808493f2f87efbe16e : SUCCESS in 17m 28s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/a8f2a87af2684841a880a45148b747de : SUCCESS in 10m 30s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/f5dc6f22c8c44fa69cefe2ba46adb650 : SUCCESS in 18m 39s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/b48ad019cfaa4abe9e32b7928ff0db05 : SUCCESS in 16m 10s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/88b6389751304ea6bc0994c47ce17394 : SUCCESS in 14m 29s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/b8a2d1b5e073438a8fccdf13f98f35da : SUCCESS in 15m 37s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/13d229d57f804cfcbf20601af4e8078b : SUCCESS in 10m 37s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/377c6f4b1c654b42b26567a914872bf4 : SUCCESS in 13m 49s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/e32d469f46c1473abb40cfaa2ffe0bc5 : SUCCESS in 11m 22s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/a69d4e4d675d4b3e8c50aaa2aedc8117 : SUCCESS in 11m 49s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/23c0b392e4c84f44a3efe8ba965332bd : SUCCESS in 27m 25s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/54b8b80632b84585b05616faf825b883 : TIMED_OUT in 32m 16s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/c082e8afee41410a8fe4469c8db20d07 : SUCCESS in 46m 56s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1618d3ce8d434d57baab62b44691dc93 : SUCCESS in 28m 04s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/95da0df2942f46ad8d74419f2f79ec57 : SUCCESS in 28m 53s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/569a26cfc0b0407aafa2b7e205289b07 : SUCCESS in 34m 19s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9038930ba6c94648ba5cbe7382a47804 : SUCCESS in 13m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/991e36824021430a8ac4d4d18ebcafcf : SUCCESS in 6m 29s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/da0a511a804c4e32a46c890bf18f1180 : SUCCESS in 21m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d1101c268cf2474b8e5570e8995672ae : SUCCESS in 1h 05m 19s","accounts_in_message":[],"_revision_number":1},{"id":"3178704c05594b02a14b73d359b9c025c0578b91","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-03-19 23:45:00.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI like where this is going. It first I meant to see if it\u0027s better to trap DatabaseConnectError around put_container, but that error is imprecise and we cannot tell what gives unless we interpret the text of the error. So I resigned to adding another stat(2).\n\nAdding -1 for a question inline.","accounts_in_message":[],"_revision_number":1},{"id":"c0e1a2880c1ebbe6a60a0a53919cdf5b20609225","author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"date":"2020-03-26 21:54:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"70a9f877da25b01b077160cd8d7e75c73bd0e3b9","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-03-28 13:32:45.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI\u0027d love to have these bugs closed, and we know that the containers won\u0027t go away until they\u0027ve reported... so maybe this is worth pursuing?\n\nThe container\u0027s HAVE to be empty right?  No amount of \"I couldn\u0027t find the account\" will allow us to reap a non-empty container - there\u0027s gunna be logs and errors until it finds someway to communicate to the reaper?","accounts_in_message":[],"_revision_number":1},{"id":"35c44e96f8f1344897ccd46d3bc0fb9519feb1be","author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"date":"2020-03-31 19:52:18.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e (1 comment)\n \u003e \n \u003e I\u0027d love to have these bugs closed, and we know that the containers\n \u003e won\u0027t go away until they\u0027ve reported... so maybe this is worth\n \u003e pursuing?\n \u003e \n \u003e The container\u0027s HAVE to be empty right?  No amount of \"I couldn\u0027t\n \u003e find the account\" will allow us to reap a non-empty container -\n \u003e there\u0027s gunna be logs and errors until it finds someway to\n \u003e communicate to the reaper?\n\nActually, if the account does not exist aymore, no reaper will run to clean containers. It will be done by the replicator if the container is deleted AND empty.\nhttps://github.com/openstack/swift/blob/712bf3c9fb3720d37e8c4f0c5b20db9bc1446747/swift/container/backend.py#L802-L811\n\n\nSo I think it is safe. If an object appears (eg: because of a slow upload) after the status was fakely reported, the object count will not be zero, so the container will not be reclaimed.","accounts_in_message":[],"_revision_number":1},{"id":"e54d64c7febe4a7a72bb0196a5d1d5977516a3d8","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-05-28 23:01:47.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI\u0027m getting poked about this, and in older releases too (all the way down to Newton with Swift 2.10.0. What if we split it up into 1 part that just stuffs the traceback and 500 in the account server, and the rest of it, including the pool?","accounts_in_message":[],"_revision_number":1},{"id":"749e18fe74ae1c6dfe58224de465e228d0b7c6c0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-20 00:52:52.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nStill poking at probe tests, but FWIW, I found got tracebacks in the reaper after I\n\n* created a container and got it into cache\n* stopped container servers\n* created data in the container, writing out an async pending\n* started container servers\n* ran container updater, account reaper to clear out the account\n* ran object updater, container updater to resurrect the container and get it back in the account\n* ran reaper again\n\nJun 20 00:35:39 saio account-6012: Exception with 127.0.0.1:6021/sdb2: \nTraceback (most recent call last):\n  File \"/vagrant/swift/swift/account/reaper.py\", line 421, in reap_container\n    \u0027X-Timestamp\u0027: timestamp.internal})\n  File \"/vagrant/swift/swift/common/direct_client.py\", line 321, in direct_delete_container\n    \u0027Container\u0027, conn_timeout, response_timeout)\n  File \"/vagrant/swift/swift/common/direct_client.py\", line 134, in _make_req\n    raise DirectClientException(stype, method, node, part, path, resp)\nswift.common.direct_client.DirectClientException: Container server 127.0.0.1:6021 direct DELETE \u0027/sdb2/284/AUTH_test/cont\u0027 gave status 404: 127.0.0.1:6021 404 Not Found: device sdb2\n\nPretty harmless, fortunately; a subsequent reap doesn\u0027t find any work to do.\n\nThinking tactically, I think I\u0027m with Zaitcev that splitting the account-server change from the container-updater change will let us quiet the \"DB doesn\u0027t exist\" errors quickly, while we think more about what happens to the orphaned container.\n\nI feel like we\u0027re going to want a dark-data watcher for containers, too, now :/","accounts_in_message":[],"_revision_number":1},{"id":"15f01de2725aaba888f742dd534027a537554e48","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-20 05:43:31.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"2e9ba2ffc1415006fc30c01a3f8516e8a1873160","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-20 06:48:04.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5ecb10058b32483ba7bdaedd38e1b8b1 : SUCCESS in 8m 03s\n- grenade https://zuul.opendev.org/t/openstack/build/1c7a3462f42e43ea86ee75c4a04cef29 : SUCCESS in 57m 16s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/bb9d93a9cd6342c79e2878889d9cce78 : SUCCESS in 51m 43s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/5865c51c11a54913ae408fc557dcde45 : SUCCESS in 7m 58s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/e9999c77e8034c3980a96ca92d422e62 : SUCCESS in 9m 11s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/ee546aa3bd0d4fc394385513d90bc355 : SUCCESS in 13m 14s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/dddfa533631b45bab889b7a38a0c73f2 : SUCCESS in 24m 09s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f73e8b51fe264368b47ab66d33d6f618 : SUCCESS in 23m 23s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/64aae1e28ba84ff59434a2c64e5a958b : SUCCESS in 12m 33s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/205fda3ed8f34f7dabb9cbb19353737c : SUCCESS in 21m 42s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/f215aeef72514db8b43cdc6b769c2744 : SUCCESS in 18m 45s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/422188da63ed471d8d42f4be218f8d55 : SUCCESS in 35m 04s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/4207733a42f64703bc88bcdbcbefc7b9 : SUCCESS in 33m 51s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/03098905ef404e85b337dda2292b12e1 : FAILURE in 39m 09s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/0c870dc2ffde425187285e1e42770cac : SUCCESS in 35m 04s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/c78c5eb4efd04d9c81dbb4ce0dd8d4f2 : SUCCESS in 30m 23s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/cd1b2df1f42e458c8d5da47c039da21f : SUCCESS in 51m 07s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/dc3e66c04e5d473f8143d74708644ac1 : SUCCESS in 1h 03m 07s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/f10ffed2e72240f9991744b340cdbf40 : SUCCESS in 54m 42s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b43af664ea9d46f8b52e70257b669b68 : SUCCESS in 31m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8e16387a95c1439aa81fc8296c00c012 : SUCCESS in 7m 37s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/1a4c92047a2f4a83a41245967f7fb3a1 : FAILURE in 9m 26s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9743c13cda474c73af98e54109c7d9be : SUCCESS in 57m 23s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8cf67a1723c9cae4824885029e3db454771a9300","revisions":{"6fec67691d8d411f51491b98a946d3d4ee9af583":{"kind":"REWORK","_number":1,"created":"2020-01-27 21:29:06.000000000","uploader":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"ref":"refs/changes/35/704435/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/35/704435/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/35/704435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/35/704435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/35/704435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/35/704435/1"}}},"commit":{"parents":[{"commit":"742835a6ec12944f606d6cd65ca7f18fdf78a09c","subject":"Merge \"New Object Versioning mode\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/742835a6ec12944f606d6cd65ca7f18fdf78a09c"}]}],"author":{"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","date":"2019-08-16 12:35:49.000000000","tz":-240},"committer":{"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","date":"2020-01-27 21:25:02.000000000","tz":-300},"subject":"Mark a container reported if account was reclaimed","message":"Mark a container reported if account was reclaimed\n\nWhen a majority of replica of an account are reclaimed, a container\ncannot report its timestamps. If report is not done, container cannot be\nreclaimed.\n\nThis patch:\n- fixes an issue of account-server where a request from the\n  container-updater (containing the header\n  X-Account-Override-Deleted: yes) on a non-existant account returns 500\n  instead of 404\n- makes the container-updater aware of 404 from the account-server so it\n  can ask the entire account ring to check if the account exists\n  somewhere before deciding to mark the containe reported, giving it a\n  chance to be reclaimed later by the container-replicator.\n\nChange-Id: Ic53068867feb0c18c88ddbe029af83a970336545\nCloses-Bug: 1300850\nCloses-Bug: 1514528\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6fec67691d8d411f51491b98a946d3d4ee9af583"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6fec67691d8d411f51491b98a946d3d4ee9af583"}]},"branch":"refs/heads/master"},"8cf67a1723c9cae4824885029e3db454771a9300":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-06-20 05:43:31.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/35/704435/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/35/704435/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/35/704435/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/35/704435/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/35/704435/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/35/704435/2"}}},"commit":{"parents":[{"commit":"5cf5548a85286b09a3441176dc773c2874203a39","subject":"Merge \"s3api: Add basic support for ?tagging requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5cf5548a85286b09a3441176dc773c2874203a39"}]}],"author":{"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","date":"2019-08-16 12:35:49.000000000","tz":-240},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-19 20:35:14.000000000","tz":-420},"subject":"Mark a container reported if account was reclaimed","message":"Mark a container reported if account was reclaimed\n\nWhen a majority of replica of an account are reclaimed, a container\ncannot report its timestamps. If report is not done, container cannot be\nreclaimed.\n\nThis patch:\n- fixes an issue of account-server where a request from the\n  container-updater (containing the header\n  X-Account-Override-Deleted: yes) on a non-existant account returns 500\n  instead of 404\n- makes the container-updater aware of 404 from the account-server so it\n  can ask the entire account ring to check if the account exists\n  somewhere before deciding to mark the containe reported, giving it a\n  chance to be reclaimed later by the container-replicator.\n\nChange-Id: Ic53068867feb0c18c88ddbe029af83a970336545\nCloses-Bug: 1300850\nCloses-Bug: 1514528\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8cf67a1723c9cae4824885029e3db454771a9300"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8cf67a1723c9cae4824885029e3db454771a9300"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
