)]}'
{"id":"openstack%2Fswift~704659","triplet_id":"openstack%2Fswift~stable%2Fstein~I36f0954fd9949d7d1404a0c381b917d1cfb17ec5","project":"openstack/swift","branch":"stable/stein","topic":"bug/1669888","hashtags":[],"change_id":"I36f0954fd9949d7d1404a0c381b917d1cfb17ec5","subject":"s3api: Better handle 498/429 responses","status":"MERGED","created":"2020-01-28 18:39:59.000000000","updated":"2020-01-29 22:14:38.000000000","submitted":"2020-01-29 22:09:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"704659-1580335753745-c94174cc","meta_rev_id":"076199a3046a5ac6bea718b9f5a61703221dcc60","_number":704659,"virtual_id_number":704659,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-29 22:09:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-01-29 18:02:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-01-29 18:02:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-29 22:09:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"51d37936098c090415cf73765aff192e10fff0ba","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-01-28 18:39:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"20c3fc76fabcf00bd8bc73dc848f935dc76c54ed","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 21:49:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e773cd19997a440eaa30bee85fdb1090 : SUCCESS in 7m 21s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/85ea316af98b4987828346fa2e628eae : FAILURE in 16m 09s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/f297cddf36e642dda759dd4629427b44 : SUCCESS in 14m 44s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1a3115cc0de74ee58db04473abd2ce0b : SUCCESS in 10m 35s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/407e31e0688044f7a31835ed318987c2 : SUCCESS in 11m 48s (non-voting)\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/5920775d3e224c598d9a42ac6663b01c : SUCCESS in 9m 25s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/69fbe1b21a38401d87f60840b824935a : SUCCESS in 10m 13s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/c8aabe4f3b384a0ea989157fb04ff31e : SUCCESS in 11m 15s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/61a12269250143a7ad5d6c5e2e49c6ee : SUCCESS in 14m 00s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/ae26a95b1e884f8d934d96b4bd434c73 : SUCCESS in 16m 20s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/beb2427dcaf845bb90629b1bb7e4f004 : SUCCESS in 29m 44s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/378c493aed0845619aae06ddb8e2c99c : SUCCESS in 32m 46s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/0c09fa8194fd412188c0ba8ad4a9972c : SUCCESS in 32m 37s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/e15df98bc43341dc86d6f98fb5fe36b1 : SUCCESS in 28m 55s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7e2c380475d440959b99528d1391f26c : FAILURE in 18m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aeeb13c0d71244b1b2eecbee915cb6fd : SUCCESS in 7m 54s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/ca68a5416f2d4322b6db4333dda9c4a0 : SUCCESS in 18m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2a67f2d9ea9a260ae022edd8f7b0b863b7282418","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-01-28 21:55:54.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e4da96403ce48856c4129666691a37dd90992f88","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 23:39:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5fed35808a154f12a7c5fdc31eb73224 : SUCCESS in 6m 10s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/8a10c900c8cc4b1f8a22db6689370342 : SUCCESS in 10m 55s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/4b11abfa04eb43079b23364e06e44b66 : SUCCESS in 10m 37s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/a9f0e9a1f0ff420b898ac8568a675c44 : SUCCESS in 9m 11s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/ea205424c08b4e5ea16559b87fd455ac : SUCCESS in 10m 37s (non-voting)\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/ee1aa2f3fe6f4857a49108834b6928ed : SUCCESS in 11m 14s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/ff691be65ad842eba3cfc4405302c4ef : SUCCESS in 12m 47s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/8462c84ffec5445badeee47a2070cbcb : SUCCESS in 10m 35s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/9b4b6ee3ab0443899fbf621a4a5da2db : SUCCESS in 16m 17s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/06b3271e3f974c0182819ae89550a3e6 : SUCCESS in 14m 44s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/c5d1c5f782a246ecabeaea657b3dece6 : SUCCESS in 16m 28s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/67f553e8537a4e74b03df04f8820bf38 : SUCCESS in 28m 30s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ec9f942cb737444a9622aba829f0f2f4 : SUCCESS in 28m 04s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/cf9a151bc7aa4bb5b01c113ffd559b81 : SUCCESS in 25m 52s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2630d234b98146b09415c75139874ffa : SUCCESS in 15m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/132ebdbaa2194b309e5d30e61c47bc24 : SUCCESS in 7m 10s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/14be3dbeb31347d8a8ecc6962e484818 : SUCCESS in 21m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4cd8ca0616e3aec7dfb90fc166ad27f5b6f92e57","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-01-29 18:02:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e20d9a7134d9241123168b9e1d9772874f4c559c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 18:03:03.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"06ef881c5749ac0509ede90c23d0f5932895389b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 22:09:13.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cac1136665da47c4826492989946e285 : SUCCESS in 5m 11s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/c3604a1e197544b6a02959556408b812 : SUCCESS in 14m 14s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/150ef9b712954ff8b6d22f3bb34cf057 : SUCCESS in 10m 30s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/94e3d7242f024194ad9614dc20a94fe5 : SUCCESS in 9m 43s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/7ece2fe3cb374029b44fcee348279c75 : SUCCESS in 11m 38s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/02fbd82833f649b587e62355cff2355e : SUCCESS in 10m 49s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/5fb085d2490549a6930e48cd5c9ddff8 : SUCCESS in 11m 44s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/34d39dafc4804849b309ac0e45e98fca : SUCCESS in 13m 15s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/897a098cdd8440cb92e1be5ee575b425 : SUCCESS in 35m 53s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/87cc4a59175a454a9b6789e2ef50f127 : SUCCESS in 32m 24s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/70e64e72bb614707be75e40cfd5289b9 : SUCCESS in 35m 26s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9fba152db9fa40a3b19dc385ed065ff6 : SUCCESS in 15m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/221bcf3278834eb49624c241710a1c75 : SUCCESS in 8m 07s","accounts_in_message":[],"_revision_number":1},{"id":"06958d3ba2adeef0dba7da4fd8e5367c299283c5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 22:09:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7818e9ff1a1004eb785106942e7e040a4ddea314","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 22:14:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d5a468c5da248c48b4a08f5894b9124 : SUCCESS in 2m 15s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"778767f324e82dd7a075306cf8468aabbbc363b6","revisions":{"778767f324e82dd7a075306cf8468aabbbc363b6":{"kind":"REWORK","_number":1,"created":"2020-01-28 18:39:59.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/59/704659/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/59/704659/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/59/704659/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/59/704659/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/59/704659/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/59/704659/1"}}},"commit":{"parents":[{"commit":"12893195d34e029fcdc643e2a91b35cbb899ba06","subject":"s3api: Translate 503 to S3-style 503s","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/12893195d34e029fcdc643e2a91b35cbb899ba06"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-12-05 17:42:33.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-01-28 18:39:25.000000000","tz":-480},"subject":"s3api: Better handle 498/429 responses","message":"s3api: Better handle 498/429 responses\n\nCurrently, they just 500 as an unexpected response status. Much better\nwould be S3\u0027s \u0027503 Slow Down\u0027 response.\n\nOf course, that\u0027s all dependent on where you place ratelimit in your\npipeline -- and we haven\u0027t really given clear guidance on that. I\u0027m not\nactually sure you *want* ratelimit to be after s3api and auth... but if\nyou *do*, let\u0027s at least handle it gracefully.\n\nChange-Id: I36f0954fd9949d7d1404a0c381b917d1cfb17ec5\nRelated-Bug: 1669888\n(cherry picked from commit f33c061ae92f33ea467c58749d3f15d2b1cc942c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/778767f324e82dd7a075306cf8468aabbbc363b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/778767f324e82dd7a075306cf8468aabbbc363b6"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}