)]}'
{"id":"openstack%2Fswift~707247","triplet_id":"openstack%2Fswift~master~Ibb30098e3c280690cee9704cdecd32c449539127","project":"openstack/swift","branch":"master","topic":"700959","hashtags":[],"change_id":"Ibb30098e3c280690cee9704cdecd32c449539127","subject":"ov: Clean up app_iters better","status":"ABANDONED","created":"2020-02-11 20:45:51.000000000","updated":"2020-02-13 05:12:33.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2d1c2527c6acd572b9b9c93f35f3f32119ee5d83","_number":707247,"virtual_id_number":707247,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-02-12 00:36:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-02-13 05:12:25.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":-1,"date":"2020-02-11 22:30:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-11 22:30:54.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2020-02-12 00:36:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"afc38e9e0cb8a2b8baa757e100946e683533d2de","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-02-11 20:45:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3429b8502e56112a530d5249e26690083abaafc9","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-02-11 22:30:54.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI swear, every single one of these is right in front of close_if_possible(). Why cannot we have drain_and_close_if_possible() instead of scattering these loops all over the place?","accounts_in_message":[],"_revision_number":1},{"id":"dff537cbfeecf0fa4e1826c6f945a9ba7bf821a6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-12 00:36:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9af3627e39e2493496576b8ee17f0d06 : SUCCESS in 10m 18s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/aae6b7501840401ead1b3aac64bd7f2f : SUCCESS in 56m 41s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/05cdf3c5123f4e91a8f4a9ce5ff2827a : SUCCESS in 52m 39s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/bb83ceac1c884e9ca3346148f5c5d3f4 : SUCCESS in 12m 09s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/d7bb003d2ebf4aee89667823347d4d13 : SUCCESS in 11m 27s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/93f48e35e888415c9b01d8a0c343675b : SUCCESS in 17m 09s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/880419117305418aab971be93b77144b : SUCCESS in 17m 25s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/0a21bf8405874ca2b75e04bf52775168 : SUCCESS in 16m 53s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/925f1ecc4ddb4f8882f9e5c4e36d9289 : SUCCESS in 16m 54s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/1b9c886adb44496a83d936cf3fab14cf : SUCCESS in 15m 08s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/7fca7323f964490ab1aed3b0a7a8281f : SUCCESS in 16m 49s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/f8349c2f3c5b4c5fa95e1f69f4cb46c6 : SUCCESS in 12m 44s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/82041e43dece47b6bca568db9cc89a81 : SUCCESS in 14m 08s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/f9d897e7ede84e7a9e5efcdfc955a370 : FAILURE in 20m 53s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/abe9a1f25f484072a8386f4242a40bd3 : SUCCESS in 15m 52s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/90e4280a3deb494f8b2f5f87f16c3ee6 : SUCCESS in 19m 01s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/5b33cdc4a0f9470cba39025d2280373a : SUCCESS in 12m 35s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/ed8c51c4e58e466eabe657981df7d5b5 : SUCCESS in 12m 10s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/bcb755c069ec47f4a6d7299e93af9efc : SUCCESS in 21m 43s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0a9056c897dc4d44bf08eb8975c0ad58 : FAILURE in 8m 08s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/7bfad3c75ff343538880a3157b34a55a : SUCCESS in 52m 50s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/07274391ef424d578d91ac34ae37ad52 : SUCCESS in 30m 15s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/14c7ee418517481cbe5e24b49b9ed863 : SUCCESS in 34m 11s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/17310b7109e044a6a667fd4f02492778 : SUCCESS in 33m 48s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b84669ea6a7844559d0e1d87b3dfbd13 : SUCCESS in 19m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/007baf2fc140400092c93c37530fff1d : SUCCESS in 10m 01s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/eebdbd0054ba493ea993775e182bf573 : FAILURE in 13m 45s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/45b020d654494a7689026b0e4d5a09f4 : SUCCESS in 1h 05m 44s","accounts_in_message":[],"_revision_number":1},{"id":"fb4105eca61416112415a8d5036127f7c4b0ba79","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-02-13 05:12:25.000000000","message":"Patch Set 1:\n\nGood call; I was just coming around to the same idea. Also squashed all three into one patch.","accounts_in_message":[],"_revision_number":1},{"id":"594b7dddfa78ab54f7cc798580711e5a1dfd2017","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-02-13 05:12:33.000000000","message":"Abandoned\n\nSquashed into https://review.opendev.org/700959","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8519ea6bd5752e93c01dbfa91eaf39f021106298","revisions":{"8519ea6bd5752e93c01dbfa91eaf39f021106298":{"kind":"REWORK","_number":1,"created":"2020-02-11 20:45:51.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/47/707247/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/47/707247/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/47/707247/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/47/707247/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/47/707247/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/47/707247/1"}}},"commit":{"parents":[{"commit":"e4025086200c88251b6b3bb88bd0bd23f5d410f9","subject":"vw: Clean up app_iters better","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e4025086200c88251b6b3bb88bd0bd23f5d410f9"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-02-11 20:45:40.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-02-11 20:45:40.000000000","tz":-480},"subject":"ov: Clean up app_iters better","message":"ov: Clean up app_iters better\n\nChange-Id: Ibb30098e3c280690cee9704cdecd32c449539127\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8519ea6bd5752e93c01dbfa91eaf39f021106298"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8519ea6bd5752e93c01dbfa91eaf39f021106298"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}