)]}'
{"swift/cli/dispersion_report.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"53bf685d87d7557e1193d56aae837355906add08","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from swift.common import utils"},{"line_number":20,"context_line":"# Monkey patch early to avoid recursion issues."},{"line_number":21,"context_line":"# urllib needs to be imported after we monkey patch"},{"line_number":22,"context_line":"utils.eventlet_monkey_patch()  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import json"},{"line_number":25,"context_line":"from collections import defaultdict"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b76b79ec","line":22,"updated":"2020-02-20 03:00:19.000000000","message":"so but... this is still an import side effect - but with a reduced scope which is still helpful.  Did this change still resolve the issue for you?","commit_id":"190b794e6a02a428c5d892be32efd609ed276b38"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64eaa196cae13d207784b4eac434c7d8beee6cb4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from swift.common import utils"},{"line_number":20,"context_line":"# Monkey patch early to avoid recursion issues."},{"line_number":21,"context_line":"# urllib needs to be imported after we monkey patch"},{"line_number":22,"context_line":"utils.eventlet_monkey_patch()  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import json"},{"line_number":25,"context_line":"from collections import defaultdict"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c2b0a3e2","line":22,"in_reply_to":"3fa7e38b_b76b79ec","updated":"2020-02-20 21:59:07.000000000","message":"Yes, this patch as written will resolve it.","commit_id":"190b794e6a02a428c5d892be32efd609ed276b38"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"53bf685d87d7557e1193d56aae837355906add08","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from swift.common import direct_client"},{"line_number":35,"context_line":"try:"},{"line_number":36,"context_line":"    from swiftclient import get_auth"},{"line_number":37,"context_line":"except ImportError:"},{"line_number":38,"context_line":"    from swift.common.internal_client import get_auth"},{"line_number":39,"context_line":"from swift.common.internal_client import SimpleClient"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_976e7dfd","line":36,"updated":"2020-02-20 03:00:19.000000000","message":"I\u0027m guessing *this* is where we\u0027re importing urllib3 - but I\u0027m not sure I\u0027d confirm that.","commit_id":"190b794e6a02a428c5d892be32efd609ed276b38"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"64eaa196cae13d207784b4eac434c7d8beee6cb4","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from swift.common import direct_client"},{"line_number":35,"context_line":"try:"},{"line_number":36,"context_line":"    from swiftclient import get_auth"},{"line_number":37,"context_line":"except ImportError:"},{"line_number":38,"context_line":"    from swift.common.internal_client import get_auth"},{"line_number":39,"context_line":"from swift.common.internal_client import SimpleClient"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c2fe636c","line":36,"in_reply_to":"3fa7e38b_976e7dfd","updated":"2020-02-20 21:59:07.000000000","message":"For sure, this is the culprit. FWIW, a patch like http://paste.openstack.org/show/789819/ on the parent commit resolves the issue for me; I guess the question is, would we rather have imports with side-effects, or delayed imports?","commit_id":"190b794e6a02a428c5d892be32efd609ed276b38"}]}