)]}'
{"id":"openstack%2Fswift~709326","triplet_id":"openstack%2Fswift~master~Id5b7889dba826f4027e1b95ff65215fb58940890","project":"openstack/swift","branch":"master","topic":"waterfall-ec","hashtags":[],"change_id":"Id5b7889dba826f4027e1b95ff65215fb58940890","subject":"Enable more concurrency for EC GET","status":"ABANDONED","created":"2020-02-22 20:48:47.000000000","updated":"2020-08-04 20:17:00.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fad127b7d639382df7e8a219c0fa22981a39c96c","_number":709326,"virtual_id_number":709326,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-02-26 20:15:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"date":"2020-03-04 05:25:11.000000000","_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-02-26 16:47:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-26 20:15:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-04 05:25:11.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"}],"messages":[{"id":"6c386a2f797366861e50fe4b32efbdf119fd3147","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-02-22 20:48:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"60d3e3501e35ccd215f0b88d7f33eebb67b4d80e","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-02-22 21:15:01.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nnothing much to see here yet really","accounts_in_message":[],"_revision_number":1},{"id":"59916d51b18b4bd3ac6c062aa4ad460537c02e49","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-22 21:51:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/046e5953ba434e05a830f46254d3939f : SUCCESS in 10m 08s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/dc9ae25547cd427d9b08dad8334fc98e : SUCCESS in 10m 39s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/be2090285f974e599e4e4d3024c97e1a : SUCCESS in 10m 57s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/372687f5000144c891dba792889a639f : SUCCESS in 15m 29s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/132e77c5de3f4d069a979c840a6a77b8 : SUCCESS in 15m 00s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/5763ec3e5fce4135ac85847d0ccc430a : SUCCESS in 14m 53s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/882f11de7f2f480081851b83a7f723ff : SUCCESS in 15m 35s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/d374057b30f54ee3ac094693d933f39f : SUCCESS in 13m 41s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/dbf42cc11434468f8e6693b3f7c44269 : SUCCESS in 15m 53s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/ced36256258940babb18862fcc0d4c4e : SUCCESS in 12m 38s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/175d65d108574639b787798556ef97da : SUCCESS in 13m 16s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/f2fb956234db4d25af15f6356882b851 : SUCCESS in 18m 48s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/bdfd88b7b6ee473faed93fcb56dcbbe6 : SUCCESS in 11m 08s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/89c445ed577f4f6ca09e610558104d10 : SUCCESS in 16m 06s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/0de9283750bb464680f36ab5e8d96d5f : SUCCESS in 12m 17s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/f21d0c57ea6f4320ac7bd1750ed71a4e : SUCCESS in 15m 13s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/f6208eb3b14d498d9eaebcc4230b9818 : SUCCESS in 20m 00s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/8cd70cea17084e95acf9ea7bd682bca2 : SUCCESS in 30m 12s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/cebdcd6cf3f9431c9623e01404e8a7d7 : SUCCESS in 33m 13s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/a1713b5c1a3a499dbaff2adecfc55383 : SUCCESS in 35m 45s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9262f9a3a84049c6a7f67288a53b9963 : SUCCESS in 15m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3cfa60b1c4f84200b02e685f5bd0a206 : SUCCESS in 7m 02s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/11006be5f79e4fbbbfc1a1c4c8e56eeb : SUCCESS in 34m 27s","accounts_in_message":[],"_revision_number":1},{"id":"c5868214f7c6faf075f2b7642f70243799458868","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-02-26 16:25:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d419ff1b8f0b303234ff39c3200f6c6493781d97","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-02-26 16:47:51.000000000","message":"Patch Set 2: Code-Review-1\n\n(5 comments)\n\nI\u0027m going spend a little time trying to see if I can decouple replicated objects concurrent_gets from ResummingGetter - but they are pretty coupled at the moment - realistically it\u0027s the NodeIter that binds everyone together but EC already a number of extensions on that interface to support alt-frag requests.\n\nMy preference would be for EC and Replicated GET to share as much code as is useful, but more and more as we get better at optimizing EC and Replicated GETs they are diverging.  \n\nMaybe I\u0027ll learn something that brings me back around to wanting to further extend this design where the EC controller is pulling on strings in a more complicated and coupled ResummingGetter and NodeIter - but honestly the most likely outcome is to further split the EC and Replicated GET code paths.","accounts_in_message":[],"_revision_number":2},{"id":"8388c5dd8343116d5c00c0b8f23b7a74a11eed62","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-26 20:15:21.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/97000a1513e947daa79608d85f28b5fd : SUCCESS in 11m 58s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/7a3074133ada416da9081e61ef5f50a7 : FAILURE in 53m 10s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/73a62c522990467b9c4f4c69b6e2a58a : FAILURE in 28m 45s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/a701262eeaad47c3ae90dd2f0e684b9d : SUCCESS in 9m 59s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/9f7821fa9040494989a7d8e9352451ef : SUCCESS in 11m 46s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/9bf816d6ad3f47ceaadc2850e2e68094 : FAILURE in 13m 57s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/1514058b06fa4917844650e2154c4e9d : FAILURE in 10m 59s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/8f7ecfe3e27446b2afae2a732fd6cd21 : FAILURE in 13m 33s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/e73ad8d655574a258ae56d0d0a882f4c : FAILURE in 13m 51s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/3aadce31833c4862853e69af04c74e59 : SUCCESS in 11m 10s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/9636e9a1e4c2437396f40316d4b102f1 : SUCCESS in 16m 34s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/762b9f7dd97743429b2c4656d286f365 : SUCCESS in 13m 32s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/0f39c09574034ef9a0c5b05713323f05 : SUCCESS in 14m 23s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/4a4fad9146e84bfab612bfec4921fe15 : SUCCESS in 15m 59s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c5f48f9cb6b443a08178823d56268967 : FAILURE in 7m 21s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/d2d7c232facc4f40b6d5c3003b913654 : FAILURE in 9m 15s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/01f46451e18f490ca9c9d0ac36e1c6f7 : FAILURE in 7m 09s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/63b02eddd71b43d9890b9d6184df4ac8 : FAILURE in 7m 32s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/e4114fd51a45422696837c9a7f04cea5 : TIMED_OUT in 41m 05s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0da2853a7f744a7bb422c67ecf64ccaf : SUCCESS in 23m 03s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/bf189da0ad0b4df39b2f3f0d96d60469 : SUCCESS in 47m 07s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1e9e2da67c064ada9a8823b0bb5eb7ab : FAILURE in 20m 07s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/ea118800b8934c43833eedf2ac1042e0 : FAILURE in 17m 26s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/c62f9a1babb947bab9591ac9cf8011d5 : FAILURE in 21m 53s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e200e39d442a4ebe9d432c3d0a87f47f : FAILURE in 15m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fdd3716c5b254bf1a313d8902f1cb124 : SUCCESS in 7m 50s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/cdf9851e303c446f8208a04194120099 : SUCCESS in 28m 46s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6a80283675ac4867a7b45508917cba35 : FAILURE in 27m 33s","accounts_in_message":[],"_revision_number":2},{"id":"e39d11bddfc7e7815880d32a2c8545d1ba46fe67","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2020-03-04 05:25:11.000000000","message":"Patch Set 2:\n\nAccording to your own comments Clay, this seems to not have moved as much over the last week. Anything we can help with?\n\nI guess I\u0027ll found out in the meeting in the morning ;)","accounts_in_message":[],"_revision_number":2},{"id":"73819d1f87a03c281132a65843c202a05a4bc0a5","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-08-04 20:17:00.000000000","message":"Abandoned\n\nall about https://review.opendev.org/#/c/711342/ now","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9979aa8b2a2ebd363acbb339bad163176fb36cb4","revisions":{"a317aff1ea66a056fa50e4a8a5894d9d524376d1":{"kind":"REWORK","_number":1,"created":"2020-02-22 20:48:47.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/26/709326/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/26/709326/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/709326/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/709326/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/709326/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/26/709326/1"}}},"commit":{"parents":[{"commit":"0297ecfe1e271dab374c5cda7ae813fcb4c2828f","subject":"Lift concurrent_gets concurrency up one layer","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0297ecfe1e271dab374c5cda7ae813fcb4c2828f"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2020-02-19 23:12:28.000000000","tz":-360},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2020-02-22 20:48:38.000000000","tz":-360},"subject":"WIP: tests for waterfall-ec","message":"WIP: tests for waterfall-ec\n\nChange-Id: Id5b7889dba826f4027e1b95ff65215fb58940890\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a317aff1ea66a056fa50e4a8a5894d9d524376d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a317aff1ea66a056fa50e4a8a5894d9d524376d1"}]},"branch":"refs/heads/master"},"9979aa8b2a2ebd363acbb339bad163176fb36cb4":{"kind":"REWORK","_number":2,"created":"2020-02-26 16:25:47.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/26/709326/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/26/709326/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/709326/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/709326/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/26/709326/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/26/709326/2"}}},"commit":{"parents":[{"commit":"ecca23eb806e11cf6517f0456483da7a065350a8","subject":"Extend eventlet_debug logging to GreenAsyncPile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ecca23eb806e11cf6517f0456483da7a065350a8"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2020-02-21 21:36:19.000000000","tz":-360},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2020-02-26 16:19:55.000000000","tz":-360},"subject":"Enable more concurrency for EC GET","message":"Enable more concurrency for EC GET\n\nWe start off an EC GET but spawning ndata fragment requests, if any one\nof those requests to a primary is unfinished w/i a timeout we continue\nthrough the node_iter onto the remaining primaries and eventually to\nhandoffs.\n\nThis behavior is similar to how the proxy requests replicated objects\nwith when not using concurrent_gets \u003d True\n\nWith this change we refactor the ResummingGetter used by each \"frag\nlane\" so they no longer manage their concurrency individually and EC\nfrag requests do not force the ResummingGetter to a concurrency of 1.\nInstead each \"frag lane\" shares the concurency set on the NodeIter and\nwill (after the concurrency_timeout) spawn a new EC frag request to\nfulfil the needed ndata fragments required to rebuild the original\nobject for the client request.\n\nChange-Id: Id5b7889dba826f4027e1b95ff65215fb58940890\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9979aa8b2a2ebd363acbb339bad163176fb36cb4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9979aa8b2a2ebd363acbb339bad163176fb36cb4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}