)]}'
{"swift/common/middleware/versioned_writes/object_versioning.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"68df8aba80b86f37d8820b1afbf4a59c38f9299b","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"def build_listing(*to_splice, **kwargs):"},{"line_number":185,"context_line":"    reverse \u003d kwargs.pop(\u0027reverse\u0027)"},{"line_number":186,"context_line":"    limit \u003d kwargs.pop(\u0027limit\u0027, None)"},{"line_number":187,"context_line":"    if limit and limit.isdigit():"},{"line_number":188,"context_line":"        limit \u003d int(limit)"},{"line_number":189,"context_line":"    if kwargs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_701ac77d","line":186,"range":{"start_line":186,"start_character":32,"end_line":186,"end_character":36},"updated":"2020-02-28 18:30:22.000000000","message":"Should probably take the listing limit from constraints.","commit_id":"99689e29f500be73a56ee7c4e72a7e558de2857e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"68df8aba80b86f37d8820b1afbf4a59c38f9299b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        itertools.chain(*to_splice),"},{"line_number":199,"context_line":"        key\u003dmerge_key,"},{"line_number":200,"context_line":"        reverse\u003dreverse,"},{"line_number":201,"context_line":"    )[:limit]).encode(\u0027ascii\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"def non_expiry_header(header):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_2b09422b","line":201,"updated":"2020-02-28 18:30:22.000000000","message":"This\u0027ll blow up with a TypeError if limit is provided but not an integer.\n\nMaybe we want something like\n\ntry:\n    limit \u003d int(kwargs.pop(\u0027limit\u0027, constraints.CONTAINER_LISTING_LIMIT))\n    if limit \u003c 0:\n        raise ValueError\nexcept ValueError:\n    limit \u003d None\n\n?","commit_id":"99689e29f500be73a56ee7c4e72a7e558de2857e"}]}